From: Javier Martinez Canillas <javierm@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>, linux-kernel@vger.kernel.org
Cc: David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, Lyude Paul <lyude@redhat.com>,
Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH v2] drm/display: Select DP helper for DRM_DP_AUX_CHARDEV and DRM_DP_CEC
Date: Thu, 28 Apr 2022 10:13:28 +0200 [thread overview]
Message-ID: <262043e4-feee-5540-9a43-8871cb51764a@redhat.com> (raw)
In-Reply-To: <cdad47d0-939d-9eda-feae-78cf204a0ae6@suse.de>
On 4/28/22 10:04, Thomas Zimmermann wrote:
[snip]
>>
>> Right. So giving even more thought to this, now I think that we should just include
>> drm_dp_aux_dev.o, drm_dp_cec.o (and probably drm_dp_aux_bus.o?) unconditionally to
>> drm_display_helper-$(CONFIG_DRM_DISPLAY_DP_HELPER).
>>
>> After all, these are not big objects and drm_display_helper can now be built as module.
>>
>> I don't see that much value to have separate user-configurable config options...
>>
>
> I don't know the side effects of this. We're exporting another device
> file after all.
>
> For know I'd make them depend on DRM_DISPLAY_DP_HELPER. If someone
> complains we can revert and fix the linker error by adding stub
> functions for the missing symbols.
>
Ok, I'll just add the depends on then to fix the linking errors and then either
adding the stubs when disabled or just making it part of the DP_HELPER can be
done as a follow-up.
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javierm@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>, linux-kernel@vger.kernel.org
Cc: David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/display: Select DP helper for DRM_DP_AUX_CHARDEV and DRM_DP_CEC
Date: Thu, 28 Apr 2022 10:13:28 +0200 [thread overview]
Message-ID: <262043e4-feee-5540-9a43-8871cb51764a@redhat.com> (raw)
In-Reply-To: <cdad47d0-939d-9eda-feae-78cf204a0ae6@suse.de>
On 4/28/22 10:04, Thomas Zimmermann wrote:
[snip]
>>
>> Right. So giving even more thought to this, now I think that we should just include
>> drm_dp_aux_dev.o, drm_dp_cec.o (and probably drm_dp_aux_bus.o?) unconditionally to
>> drm_display_helper-$(CONFIG_DRM_DISPLAY_DP_HELPER).
>>
>> After all, these are not big objects and drm_display_helper can now be built as module.
>>
>> I don't see that much value to have separate user-configurable config options...
>>
>
> I don't know the side effects of this. We're exporting another device
> file after all.
>
> For know I'd make them depend on DRM_DISPLAY_DP_HELPER. If someone
> complains we can revert and fix the linker error by adding stub
> functions for the missing symbols.
>
Ok, I'll just add the depends on then to fix the linking errors and then either
adding the stubs when disabled or just making it part of the DP_HELPER can be
done as a follow-up.
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
next prev parent reply other threads:[~2022-04-28 8:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 21:55 [PATCH v2] drm/display: Select DP helper for DRM_DP_AUX_CHARDEV and DRM_DP_CEC Javier Martinez Canillas
2022-04-27 21:55 ` Javier Martinez Canillas
2022-04-28 7:02 ` Thomas Zimmermann
2022-04-28 7:02 ` Thomas Zimmermann
2022-04-28 7:26 ` Javier Martinez Canillas
2022-04-28 7:26 ` Javier Martinez Canillas
2022-04-28 7:45 ` Thomas Zimmermann
2022-04-28 7:52 ` Javier Martinez Canillas
2022-04-28 8:04 ` Thomas Zimmermann
2022-04-28 8:13 ` Javier Martinez Canillas [this message]
2022-04-28 8:13 ` Javier Martinez Canillas
2022-04-28 8:05 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=262043e4-feee-5540-9a43-8871cb51764a@redhat.com \
--to=javierm@redhat.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.