From: Thomas Zimmermann <tzimmermann@suse.de> To: Javier Martinez Canillas <javierm@redhat.com>, linux-kernel@vger.kernel.org Cc: Lyude Paul <lyude@redhat.com>, Jani Nikula <jani.nikula@linux.intel.com>, Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2] drm/display: Select DP helper for DRM_DP_AUX_CHARDEV and DRM_DP_CEC Date: Thu, 28 Apr 2022 09:02:32 +0200 [thread overview] Message-ID: <46446e78-60a6-1b8c-1bb6-1c005489d58c@suse.de> (raw) In-Reply-To: <20220427215528.237861-1-javierm@redhat.com> [-- Attachment #1.1: Type: text/plain, Size: 3397 bytes --] Hi Am 27.04.22 um 23:55 schrieb Javier Martinez Canillas: > The DRM_DP_AUX_CHARDEV and DRM_DP_CEC Kconfig symbols enable code that use > DP helper functions, that are only present if CONFIG_DRM_DISPLAY_DP_HELPER > is also enabled. > > But these don't select the DRM_DISPLAY_DP_HELPER symbol, meaning that it > is possible to enable any of them without CONFIG_DRM_DISPLAY_DP_HELPER. > > That will lead to the following linking errors with the mentioned config: > > LD vmlinux.o > MODPOST vmlinux.symvers > MODINFO modules.builtin.modinfo > GEN modules.builtin > LD .tmp_vmlinux.kallsyms1 > KSYMS .tmp_vmlinux.kallsyms1.S > AS .tmp_vmlinux.kallsyms1.S > LD .tmp_vmlinux.kallsyms2 > KSYMS .tmp_vmlinux.kallsyms2.S > AS .tmp_vmlinux.kallsyms2.S > LD vmlinux > SYSMAP System.map > SORTTAB vmlinux > OBJCOPY arch/arm64/boot/Image > MODPOST modules-only.symvers > ERROR: modpost: "drm_dp_dpcd_write" [drivers/gpu/drm/display/drm_display_helper.ko] undefined! > ERROR: modpost: "drm_dp_read_desc" [drivers/gpu/drm/display/drm_display_helper.ko] undefined! > ERROR: modpost: "drm_dp_dpcd_read" [drivers/gpu/drm/display/drm_display_helper.ko] undefined! > make[1]: *** [scripts/Makefile.modpost:134: modules-only.symvers] Error 1 > make[1]: *** Deleting file 'modules-only.symvers' > make: *** [Makefile:1749: modules] Error 2 > > Note: It seems this has been an issue for a long time but was made easier > to reproduce after the commit 1e0f66420b13 ("drm/display: Introduce a DRM > display-helper module"). Adding a Fixes: tag just to make sure that this > fix will be picked for stable once the mentioned change also lands there. > > Fixes: 1e0f66420b13 ("drm/display: Introduce a DRM display-helper module") > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> > --- > > Changes in v2: > - Explain better the issue in the change description. > - Only select DRM_DISPLAY_DP_HELPER and not DRM_DISPLAY_HELPER. > > drivers/gpu/drm/display/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/display/Kconfig b/drivers/gpu/drm/display/Kconfig > index f84f1b0cd23f..9fe80c4e555c 100644 > --- a/drivers/gpu/drm/display/Kconfig > +++ b/drivers/gpu/drm/display/Kconfig > @@ -32,6 +32,7 @@ config DRM_DISPLAY_HDMI_HELPER > config DRM_DP_AUX_CHARDEV > bool "DRM DP AUX Interface" > depends on DRM > + select DRM_DISPLAY_DP_HELPER You cannot select DISPLAY_DP_HELPER without DISPLAY_HELPER. Can't you simply make it depend on DISPLAY_DP_HELPER. The menu entry will show up as soon as there's a driver that selcets DISPLAY_DP_HELPER. Best regards Thomas > help > Choose this option to enable a /dev/drm_dp_auxN node that allows to > read and write values to arbitrary DPCD registers on the DP aux > @@ -40,6 +41,7 @@ config DRM_DP_AUX_CHARDEV > config DRM_DP_CEC > bool "Enable DisplayPort CEC-Tunneling-over-AUX HDMI support" > depends on DRM > + select DRM_DISPLAY_DP_HELPER > select CEC_CORE > help > Choose this option if you want to enable HDMI CEC support for -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 840 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de> To: Javier Martinez Canillas <javierm@redhat.com>, linux-kernel@vger.kernel.org Cc: David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2] drm/display: Select DP helper for DRM_DP_AUX_CHARDEV and DRM_DP_CEC Date: Thu, 28 Apr 2022 09:02:32 +0200 [thread overview] Message-ID: <46446e78-60a6-1b8c-1bb6-1c005489d58c@suse.de> (raw) In-Reply-To: <20220427215528.237861-1-javierm@redhat.com> [-- Attachment #1.1: Type: text/plain, Size: 3397 bytes --] Hi Am 27.04.22 um 23:55 schrieb Javier Martinez Canillas: > The DRM_DP_AUX_CHARDEV and DRM_DP_CEC Kconfig symbols enable code that use > DP helper functions, that are only present if CONFIG_DRM_DISPLAY_DP_HELPER > is also enabled. > > But these don't select the DRM_DISPLAY_DP_HELPER symbol, meaning that it > is possible to enable any of them without CONFIG_DRM_DISPLAY_DP_HELPER. > > That will lead to the following linking errors with the mentioned config: > > LD vmlinux.o > MODPOST vmlinux.symvers > MODINFO modules.builtin.modinfo > GEN modules.builtin > LD .tmp_vmlinux.kallsyms1 > KSYMS .tmp_vmlinux.kallsyms1.S > AS .tmp_vmlinux.kallsyms1.S > LD .tmp_vmlinux.kallsyms2 > KSYMS .tmp_vmlinux.kallsyms2.S > AS .tmp_vmlinux.kallsyms2.S > LD vmlinux > SYSMAP System.map > SORTTAB vmlinux > OBJCOPY arch/arm64/boot/Image > MODPOST modules-only.symvers > ERROR: modpost: "drm_dp_dpcd_write" [drivers/gpu/drm/display/drm_display_helper.ko] undefined! > ERROR: modpost: "drm_dp_read_desc" [drivers/gpu/drm/display/drm_display_helper.ko] undefined! > ERROR: modpost: "drm_dp_dpcd_read" [drivers/gpu/drm/display/drm_display_helper.ko] undefined! > make[1]: *** [scripts/Makefile.modpost:134: modules-only.symvers] Error 1 > make[1]: *** Deleting file 'modules-only.symvers' > make: *** [Makefile:1749: modules] Error 2 > > Note: It seems this has been an issue for a long time but was made easier > to reproduce after the commit 1e0f66420b13 ("drm/display: Introduce a DRM > display-helper module"). Adding a Fixes: tag just to make sure that this > fix will be picked for stable once the mentioned change also lands there. > > Fixes: 1e0f66420b13 ("drm/display: Introduce a DRM display-helper module") > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> > --- > > Changes in v2: > - Explain better the issue in the change description. > - Only select DRM_DISPLAY_DP_HELPER and not DRM_DISPLAY_HELPER. > > drivers/gpu/drm/display/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/display/Kconfig b/drivers/gpu/drm/display/Kconfig > index f84f1b0cd23f..9fe80c4e555c 100644 > --- a/drivers/gpu/drm/display/Kconfig > +++ b/drivers/gpu/drm/display/Kconfig > @@ -32,6 +32,7 @@ config DRM_DISPLAY_HDMI_HELPER > config DRM_DP_AUX_CHARDEV > bool "DRM DP AUX Interface" > depends on DRM > + select DRM_DISPLAY_DP_HELPER You cannot select DISPLAY_DP_HELPER without DISPLAY_HELPER. Can't you simply make it depend on DISPLAY_DP_HELPER. The menu entry will show up as soon as there's a driver that selcets DISPLAY_DP_HELPER. Best regards Thomas > help > Choose this option to enable a /dev/drm_dp_auxN node that allows to > read and write values to arbitrary DPCD registers on the DP aux > @@ -40,6 +41,7 @@ config DRM_DP_AUX_CHARDEV > config DRM_DP_CEC > bool "Enable DisplayPort CEC-Tunneling-over-AUX HDMI support" > depends on DRM > + select DRM_DISPLAY_DP_HELPER > select CEC_CORE > help > Choose this option if you want to enable HDMI CEC support for -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2022-04-28 7:02 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-27 21:55 [PATCH v2] drm/display: Select DP helper for DRM_DP_AUX_CHARDEV and DRM_DP_CEC Javier Martinez Canillas 2022-04-27 21:55 ` Javier Martinez Canillas 2022-04-28 7:02 ` Thomas Zimmermann [this message] 2022-04-28 7:02 ` Thomas Zimmermann 2022-04-28 7:26 ` Javier Martinez Canillas 2022-04-28 7:26 ` Javier Martinez Canillas 2022-04-28 7:45 ` Thomas Zimmermann 2022-04-28 7:52 ` Javier Martinez Canillas 2022-04-28 8:04 ` Thomas Zimmermann 2022-04-28 8:13 ` Javier Martinez Canillas 2022-04-28 8:13 ` Javier Martinez Canillas 2022-04-28 8:05 ` Thomas Zimmermann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=46446e78-60a6-1b8c-1bb6-1c005489d58c@suse.de \ --to=tzimmermann@suse.de \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=jani.nikula@linux.intel.com \ --cc=javierm@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=lyude@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.