From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Jacopo Mondi <jacopo+renesas@jmondi.org> Cc: architt@codeaurora.org, a.hajda@samsung.com, airlied@linux.ie, daniel@ffwll.ch, peda@axentia.se, linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/8] dt-bindings: display: bridge: thc63lvd1024: Add lvds map property Date: Mon, 23 Apr 2018 15:02:59 +0300 [thread overview] Message-ID: <2645564.GDIDDgbfar@avalon> (raw) In-Reply-To: <1524130269-32688-3-git-send-email-jacopo+renesas@jmondi.org> Hi Jacopo, Thank you for the patch. On Thursday, 19 April 2018 12:31:03 EEST Jacopo Mondi wrote: > The THC63LVD1024 LVDS to RGB bridge supports two different input mapping > modes, selectable by means of an external pin. > > Describe the LVDS mode map through a newly defined mandatory property in > device tree bindings. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > --- > .../devicetree/bindings/display/bridge/thine,thc63lvd1024.txt | 3 > +++ 1 file changed, 3 insertions(+) > > diff --git > a/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > index 37f0c04..0937595 100644 > --- > a/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > +++ > b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > @@ -12,6 +12,8 @@ Required properties: > - compatible: Shall be "thine,thc63lvd1024" > - vcc-supply: Power supply for TTL output, TTL CLOCKOUT signal, LVDS input, > PPL and digital circuitry > +- thine,map: LVDS mapping mode selection signal, pin name "MAP". Shall be > <1> > + for mapping mode 1, <0> for mapping mode 2 That's sounds like an odd mapping. I suppose you have modeled it based on the state of the MAP pin instead of the mode number (MAP low means mode 2, MAP high means mode 1). To avoid confusing readers I would write it as - thine,map: level of the MAP pin that selects the LVDS mapping mode. Shall be <0> for low level (mapping mode 2) or <1> for high level (mapping mode 1). Apart from that this patch looks good to me. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Optional properties: > - powerdown-gpios: Power down GPIO signal, pin name "/PDWN". Active low > @@ -36,6 +38,7 @@ Example: > > vcc-supply = <®_lvds_vcc>; > powerdown-gpios = <&gpio4 15 GPIO_ACTIVE_LOW>; > + thine,map = <1>; > > ports { > #address-cells = <1>; -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Jacopo Mondi <jacopo+renesas@jmondi.org> Cc: devicetree@vger.kernel.org, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, peda@axentia.se, linux-media@vger.kernel.org Subject: Re: [PATCH 2/8] dt-bindings: display: bridge: thc63lvd1024: Add lvds map property Date: Mon, 23 Apr 2018 15:02:59 +0300 [thread overview] Message-ID: <2645564.GDIDDgbfar@avalon> (raw) In-Reply-To: <1524130269-32688-3-git-send-email-jacopo+renesas@jmondi.org> Hi Jacopo, Thank you for the patch. On Thursday, 19 April 2018 12:31:03 EEST Jacopo Mondi wrote: > The THC63LVD1024 LVDS to RGB bridge supports two different input mapping > modes, selectable by means of an external pin. > > Describe the LVDS mode map through a newly defined mandatory property in > device tree bindings. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > --- > .../devicetree/bindings/display/bridge/thine,thc63lvd1024.txt | 3 > +++ 1 file changed, 3 insertions(+) > > diff --git > a/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > index 37f0c04..0937595 100644 > --- > a/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > +++ > b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > @@ -12,6 +12,8 @@ Required properties: > - compatible: Shall be "thine,thc63lvd1024" > - vcc-supply: Power supply for TTL output, TTL CLOCKOUT signal, LVDS input, > PPL and digital circuitry > +- thine,map: LVDS mapping mode selection signal, pin name "MAP". Shall be > <1> > + for mapping mode 1, <0> for mapping mode 2 That's sounds like an odd mapping. I suppose you have modeled it based on the state of the MAP pin instead of the mode number (MAP low means mode 2, MAP high means mode 1). To avoid confusing readers I would write it as - thine,map: level of the MAP pin that selects the LVDS mapping mode. Shall be <0> for low level (mapping mode 2) or <1> for high level (mapping mode 1). Apart from that this patch looks good to me. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Optional properties: > - powerdown-gpios: Power down GPIO signal, pin name "/PDWN". Active low > @@ -36,6 +38,7 @@ Example: > > vcc-supply = <®_lvds_vcc>; > powerdown-gpios = <&gpio4 15 GPIO_ACTIVE_LOW>; > + thine,map = <1>; > > ports { > #address-cells = <1>; -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-04-23 12:02 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-19 9:31 [PATCH 0/8] drm: bridge: Add support for static image formats Jacopo Mondi 2018-04-19 9:31 ` [PATCH 1/8] " Jacopo Mondi 2018-04-22 20:02 ` Peter Rosin 2018-04-26 18:44 ` jacopo mondi 2018-04-26 18:44 ` jacopo mondi 2018-04-23 9:27 ` Laurent Pinchart 2018-04-23 9:27 ` Laurent Pinchart 2018-04-26 18:40 ` jacopo mondi 2018-04-26 18:40 ` jacopo mondi 2018-04-26 19:57 ` Laurent Pinchart 2018-04-26 19:57 ` Laurent Pinchart 2018-04-19 9:31 ` [PATCH 2/8] dt-bindings: display: bridge: thc63lvd1024: Add lvds map property Jacopo Mondi 2018-04-22 20:02 ` Peter Rosin 2018-04-23 7:35 ` jacopo mondi 2018-04-23 7:35 ` jacopo mondi 2018-04-23 11:59 ` Laurent Pinchart 2018-04-23 11:59 ` Laurent Pinchart 2018-04-23 12:02 ` Laurent Pinchart [this message] 2018-04-23 12:02 ` Laurent Pinchart 2018-04-24 16:37 ` Rob Herring 2018-04-24 16:37 ` Rob Herring 2018-04-19 9:31 ` [PATCH 3/8] drm: bridge: thc63lvd1024: Add support for LVDS mode map Jacopo Mondi 2018-04-22 20:02 ` Peter Rosin 2018-04-23 7:41 ` jacopo mondi 2018-04-23 12:12 ` Laurent Pinchart 2018-04-23 12:12 ` Laurent Pinchart 2018-04-23 12:08 ` Laurent Pinchart 2018-04-23 12:08 ` Laurent Pinchart 2018-04-19 9:31 ` [PATCH 4/8] arm64: dts: renesas: eagle: Add thc63 LVDS map Jacopo Mondi 2018-04-23 10:29 ` Simon Horman 2018-04-23 13:07 ` Laurent Pinchart 2018-04-23 13:07 ` Laurent Pinchart 2018-04-19 9:31 ` [PATCH 5/8] media: Add LE version of RGB LVDS formats Jacopo Mondi 2018-04-23 13:06 ` Laurent Pinchart 2018-04-23 13:06 ` Laurent Pinchart 2018-04-24 7:16 ` jacopo mondi 2018-04-24 7:16 ` jacopo mondi 2018-04-19 9:31 ` [PATCH 6/8] drm: rcar-du: rcar-lvds: Add bridge format support Jacopo Mondi 2018-04-22 20:08 ` Peter Rosin 2018-04-23 7:28 ` jacopo mondi 2018-04-23 7:28 ` jacopo mondi 2018-04-23 7:59 ` Peter Rosin 2018-04-23 8:47 ` jacopo mondi 2018-04-23 8:47 ` jacopo mondi 2018-04-23 12:59 ` Laurent Pinchart 2018-04-23 12:59 ` Laurent Pinchart 2018-04-19 9:31 ` [PATCH 7/8] drm: panel: Use _LE LVDS formats for data mirroring Jacopo Mondi 2018-04-19 9:31 ` [PATCH 8/8] drm: connector: Remove DRM_BUS_FLAG_DATA_* flags Jacopo Mondi 2018-04-23 21:03 ` Laurent Pinchart 2018-04-23 21:03 ` Laurent Pinchart 2018-04-24 7:22 ` jacopo mondi 2018-04-24 7:22 ` jacopo mondi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2645564.GDIDDgbfar@avalon \ --to=laurent.pinchart@ideasonboard.com \ --cc=a.hajda@samsung.com \ --cc=airlied@linux.ie \ --cc=architt@codeaurora.org \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=jacopo+renesas@jmondi.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=peda@axentia.se \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.