From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Jacopo Mondi <jacopo+renesas@jmondi.org> Cc: architt@codeaurora.org, a.hajda@samsung.com, airlied@linux.ie, daniel@ffwll.ch, peda@axentia.se, linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 8/8] drm: connector: Remove DRM_BUS_FLAG_DATA_* flags Date: Tue, 24 Apr 2018 00:03:04 +0300 [thread overview] Message-ID: <5371494.OmLzBJ8YyX@avalon> (raw) In-Reply-To: <1524130269-32688-9-git-send-email-jacopo+renesas@jmondi.org> Hi Jacopo, Thank you for the patch. On Thursday, 19 April 2018 12:31:09 EEST Jacopo Mondi wrote: > DRM_BUS_FLAG_DATA_* flags, defined in drm_connector.h header file are > used to swap ordering of LVDS RGB format to accommodate DRM objects > that need to handle LVDS components ordering. > > Now that the only 2 users of DRM_BUS_FLAG_DATA_* flags have been ported > to use the newly introduced MEDIA_BUS_FMT_RGB888_1X7X*_LE media bus > formats, remove them. I'm not opposed to this (despite my review of patch 5/8), but I think the _LE suffix isn't the right name for the new formats. _BE and _LE relate to byte swapping, while here you really need to describe full mirroring. Maybe a _MIRROR variant would be more appropriate ? > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > --- > include/drm/drm_connector.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h > index 675cc3f..9e0d6d5 100644 > --- a/include/drm/drm_connector.h > +++ b/include/drm/drm_connector.h > @@ -286,10 +286,6 @@ struct drm_display_info { > #define DRM_BUS_FLAG_PIXDATA_POSEDGE (1<<2) > /* drive data on neg. edge */ > #define DRM_BUS_FLAG_PIXDATA_NEGEDGE (1<<3) > -/* data is transmitted MSB to LSB on the bus */ > -#define DRM_BUS_FLAG_DATA_MSB_TO_LSB (1<<4) > -/* data is transmitted LSB to MSB on the bus */ > -#define DRM_BUS_FLAG_DATA_LSB_TO_MSB (1<<5) > > /** > * @bus_flags: Additional information (like pixel signal polarity) for -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Jacopo Mondi <jacopo+renesas@jmondi.org> Cc: devicetree@vger.kernel.org, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, peda@axentia.se, linux-media@vger.kernel.org Subject: Re: [PATCH 8/8] drm: connector: Remove DRM_BUS_FLAG_DATA_* flags Date: Tue, 24 Apr 2018 00:03:04 +0300 [thread overview] Message-ID: <5371494.OmLzBJ8YyX@avalon> (raw) In-Reply-To: <1524130269-32688-9-git-send-email-jacopo+renesas@jmondi.org> Hi Jacopo, Thank you for the patch. On Thursday, 19 April 2018 12:31:09 EEST Jacopo Mondi wrote: > DRM_BUS_FLAG_DATA_* flags, defined in drm_connector.h header file are > used to swap ordering of LVDS RGB format to accommodate DRM objects > that need to handle LVDS components ordering. > > Now that the only 2 users of DRM_BUS_FLAG_DATA_* flags have been ported > to use the newly introduced MEDIA_BUS_FMT_RGB888_1X7X*_LE media bus > formats, remove them. I'm not opposed to this (despite my review of patch 5/8), but I think the _LE suffix isn't the right name for the new formats. _BE and _LE relate to byte swapping, while here you really need to describe full mirroring. Maybe a _MIRROR variant would be more appropriate ? > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > --- > include/drm/drm_connector.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h > index 675cc3f..9e0d6d5 100644 > --- a/include/drm/drm_connector.h > +++ b/include/drm/drm_connector.h > @@ -286,10 +286,6 @@ struct drm_display_info { > #define DRM_BUS_FLAG_PIXDATA_POSEDGE (1<<2) > /* drive data on neg. edge */ > #define DRM_BUS_FLAG_PIXDATA_NEGEDGE (1<<3) > -/* data is transmitted MSB to LSB on the bus */ > -#define DRM_BUS_FLAG_DATA_MSB_TO_LSB (1<<4) > -/* data is transmitted LSB to MSB on the bus */ > -#define DRM_BUS_FLAG_DATA_LSB_TO_MSB (1<<5) > > /** > * @bus_flags: Additional information (like pixel signal polarity) for -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-04-23 21:02 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-19 9:31 [PATCH 0/8] drm: bridge: Add support for static image formats Jacopo Mondi 2018-04-19 9:31 ` [PATCH 1/8] " Jacopo Mondi 2018-04-22 20:02 ` Peter Rosin 2018-04-26 18:44 ` jacopo mondi 2018-04-26 18:44 ` jacopo mondi 2018-04-23 9:27 ` Laurent Pinchart 2018-04-23 9:27 ` Laurent Pinchart 2018-04-26 18:40 ` jacopo mondi 2018-04-26 18:40 ` jacopo mondi 2018-04-26 19:57 ` Laurent Pinchart 2018-04-26 19:57 ` Laurent Pinchart 2018-04-19 9:31 ` [PATCH 2/8] dt-bindings: display: bridge: thc63lvd1024: Add lvds map property Jacopo Mondi 2018-04-22 20:02 ` Peter Rosin 2018-04-23 7:35 ` jacopo mondi 2018-04-23 7:35 ` jacopo mondi 2018-04-23 11:59 ` Laurent Pinchart 2018-04-23 11:59 ` Laurent Pinchart 2018-04-23 12:02 ` Laurent Pinchart 2018-04-23 12:02 ` Laurent Pinchart 2018-04-24 16:37 ` Rob Herring 2018-04-24 16:37 ` Rob Herring 2018-04-19 9:31 ` [PATCH 3/8] drm: bridge: thc63lvd1024: Add support for LVDS mode map Jacopo Mondi 2018-04-22 20:02 ` Peter Rosin 2018-04-23 7:41 ` jacopo mondi 2018-04-23 12:12 ` Laurent Pinchart 2018-04-23 12:12 ` Laurent Pinchart 2018-04-23 12:08 ` Laurent Pinchart 2018-04-23 12:08 ` Laurent Pinchart 2018-04-19 9:31 ` [PATCH 4/8] arm64: dts: renesas: eagle: Add thc63 LVDS map Jacopo Mondi 2018-04-23 10:29 ` Simon Horman 2018-04-23 13:07 ` Laurent Pinchart 2018-04-23 13:07 ` Laurent Pinchart 2018-04-19 9:31 ` [PATCH 5/8] media: Add LE version of RGB LVDS formats Jacopo Mondi 2018-04-23 13:06 ` Laurent Pinchart 2018-04-23 13:06 ` Laurent Pinchart 2018-04-24 7:16 ` jacopo mondi 2018-04-24 7:16 ` jacopo mondi 2018-04-19 9:31 ` [PATCH 6/8] drm: rcar-du: rcar-lvds: Add bridge format support Jacopo Mondi 2018-04-22 20:08 ` Peter Rosin 2018-04-23 7:28 ` jacopo mondi 2018-04-23 7:28 ` jacopo mondi 2018-04-23 7:59 ` Peter Rosin 2018-04-23 8:47 ` jacopo mondi 2018-04-23 8:47 ` jacopo mondi 2018-04-23 12:59 ` Laurent Pinchart 2018-04-23 12:59 ` Laurent Pinchart 2018-04-19 9:31 ` [PATCH 7/8] drm: panel: Use _LE LVDS formats for data mirroring Jacopo Mondi 2018-04-19 9:31 ` [PATCH 8/8] drm: connector: Remove DRM_BUS_FLAG_DATA_* flags Jacopo Mondi 2018-04-23 21:03 ` Laurent Pinchart [this message] 2018-04-23 21:03 ` Laurent Pinchart 2018-04-24 7:22 ` jacopo mondi 2018-04-24 7:22 ` jacopo mondi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5371494.OmLzBJ8YyX@avalon \ --to=laurent.pinchart@ideasonboard.com \ --cc=a.hajda@samsung.com \ --cc=airlied@linux.ie \ --cc=architt@codeaurora.org \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=jacopo+renesas@jmondi.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=peda@axentia.se \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.