All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Calvin Lee <cyrus296@gmail.com>, qemu-devel@nongnu.org
Cc: mst@redhat.com, dgilbert@redhat.com
Subject: Re: [Qemu-devel] [PATCH RFC v2 0/2] Fix UART serial implementation
Date: Sun, 15 Jul 2018 17:57:50 +0200	[thread overview]
Message-ID: <2645955d-3d57-3bc8-9325-07fb6830ac78@redhat.com> (raw)
In-Reply-To: <20180512000545.966-1-cyrus296@gmail.com>

On 12/05/2018 02:05, Calvin Lee wrote:
> While developing a serial implementation for my OS, I found several bugs
> in QEMU's serial device. I confirmed (by testing on my x64 laptop) that
> there are several inconsistancies between QEMU and hardware in this
> regard. For both patches, I used "http://www.sci.muni.cz/docs/pc/serport.txt"
> for reference.
> 
> First, QEMU has several errors for setting the UART divisor that are
> fixed in my first patch. Second, (and more importantly) QEMU does not
> transmit serial bytes at the correct rate, and this is fixed in my
> second patch.

Hi Calvin,

I am queuing the first patch.  Regarding the second, it's been debated
quite a few times over the years whether QEMU should respect the
transmit rate or not.  The main advantage of not doing so is that some
OSes use the serial port pretty heavily (e.g. Linux for boot messages,
or Windows for debugging), and throttling the serial port to just e.g.
115200 bps makes them unnecessarily slow.

Paolo

      parent reply	other threads:[~2018-07-15 15:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-12  0:05 [Qemu-devel] [PATCH RFC v2 0/2] Fix UART serial implementation Calvin Lee
2018-05-12  0:05 ` [Qemu-devel] [PATCH RFC v2 1/2] PC Chipset: Improve serial divisor calculation Calvin Lee
2018-05-12  0:05 ` [Qemu-devel] [PATCH RFC v2 2/2] PC Chipset: Send serial bytes at correct rate Calvin Lee
2018-05-14 19:13   ` Dr. David Alan Gilbert
2018-05-14 19:39     ` Calvin Lee
2018-07-15 15:57 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2645955d-3d57-3bc8-9325-07fb6830ac78@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=cyrus296@gmail.com \
    --cc=dgilbert@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.