All of lore.kernel.org
 help / color / mirror / Atom feed
From: Calvin Lee <cyrus296@gmail.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH RFC v2 2/2] PC Chipset: Send serial bytes at correct rate
Date: Mon, 14 May 2018 13:39:18 -0600	[thread overview]
Message-ID: <CAG7gSg1yyPOLKK6oxif_nAmEN0_t_D-6QKcs3MTxTMV_9auTFg@mail.gmail.com> (raw)
In-Reply-To: <20180514191306.GG2497@work-vm>

> So the question is, why move it?  If I understand what you've got, then
> it's the same flag with the same semantics - but moving it you break
> migration compatibility - so unless you need to, just leave it where it
> is.

Sorry if I did not make this clear.

This commit will delay flushing the THR until after the new timer has expired.
Before, it would be immediatly flushed into the TSR, and was saved by
`vmstate_serial_tsr`. However, now if the `xmit_timeout_timer` is pending it
needs to be saved, that's why I moved it into the new VMStateDescription.

>If you add a property/flag on the device, and check the property in that
>_needed function, then we can make it so that we don't save that section
>for older machine types.

I don't really understand. How do I make sure not to save this for
older machines?

Thanks,
Calvin

  reply	other threads:[~2018-05-14 19:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-12  0:05 [Qemu-devel] [PATCH RFC v2 0/2] Fix UART serial implementation Calvin Lee
2018-05-12  0:05 ` [Qemu-devel] [PATCH RFC v2 1/2] PC Chipset: Improve serial divisor calculation Calvin Lee
2018-05-12  0:05 ` [Qemu-devel] [PATCH RFC v2 2/2] PC Chipset: Send serial bytes at correct rate Calvin Lee
2018-05-14 19:13   ` Dr. David Alan Gilbert
2018-05-14 19:39     ` Calvin Lee [this message]
2018-07-15 15:57 ` [Qemu-devel] [PATCH RFC v2 0/2] Fix UART serial implementation Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAG7gSg1yyPOLKK6oxif_nAmEN0_t_D-6QKcs3MTxTMV_9auTFg@mail.gmail.com \
    --to=cyrus296@gmail.com \
    --cc=dgilbert@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.