All of lore.kernel.org
 help / color / mirror / Atom feed
From: Calvin Lee <cyrus296@gmail.com>
To: qemu-devel@nongnu.org
Cc: mst@redhat.com, pbonzini@redhat.com, dgilbert@redhat.com,
	Calvin Lee <cyrus296@gmail.com>
Subject: [Qemu-devel] [PATCH RFC v2 0/2] Fix UART serial implementation
Date: Fri, 11 May 2018 18:05:43 -0600	[thread overview]
Message-ID: <20180512000545.966-1-cyrus296@gmail.com> (raw)

Hello,

While developing a serial implementation for my OS, I found several bugs
in QEMU's serial device. I confirmed (by testing on my x64 laptop) that
there are several inconsistancies between QEMU and hardware in this
regard. For both patches, I used "http://www.sci.muni.cz/docs/pc/serport.txt"
for reference.

First, QEMU has several errors for setting the UART divisor that are
fixed in my first patch. Second, (and more importantly) QEMU does not
transmit serial bytes at the correct rate, and this is fixed in my
second patch.

I have neither contributed to QEMU nor sent patches to a mailing list
before, so I marked this patch-series as RFC. I would appreciate any
comments you have. Also, I am not very confident in VM migration between
versions, so I would appreciate if someone could help me make sure this
is correct in my patches.

v2:
fix build

Calvin Lee (2):
  PC Chipset: Improve serial divisor calculation
  PC Chipset: Send serial bytes at correct rate

 hw/char/serial.c         | 74 +++++++++++++++++++++++++++++++---------
 include/hw/char/serial.h |  2 ++
 2 files changed, 60 insertions(+), 16 deletions(-)

-- 
2.17.0

             reply	other threads:[~2018-05-12  0:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-12  0:05 Calvin Lee [this message]
2018-05-12  0:05 ` [Qemu-devel] [PATCH RFC v2 1/2] PC Chipset: Improve serial divisor calculation Calvin Lee
2018-05-12  0:05 ` [Qemu-devel] [PATCH RFC v2 2/2] PC Chipset: Send serial bytes at correct rate Calvin Lee
2018-05-14 19:13   ` Dr. David Alan Gilbert
2018-05-14 19:39     ` Calvin Lee
2018-07-15 15:57 ` [Qemu-devel] [PATCH RFC v2 0/2] Fix UART serial implementation Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180512000545.966-1-cyrus296@gmail.com \
    --to=cyrus296@gmail.com \
    --cc=dgilbert@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.