From: Tom Talpey <firstname.lastname@example.org> To: Ralph Boehme <email@example.com>, Jeremy Allison <firstname.lastname@example.org> Cc: Namjae Jeon <email@example.com>, firstname.lastname@example.org, Ronnie Sahlberg <email@example.com>, Steve French <firstname.lastname@example.org>, Hyunchul Lee <email@example.com>, Sergey Senozhatsky <firstname.lastname@example.org> Subject: Re: [PATCH v3 0/5] ksmbd: a bunch of patches Date: Wed, 29 Sep 2021 12:45:37 -0400 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> On 9/29/2021 12:38 PM, Ralph Boehme wrote: > Am 29.09.21 um 17:42 schrieb Jeremy Allison: >> On Wed, Sep 29, 2021 at 11:28:09AM -0400, Tom Talpey wrote: >>> >>> I completely agree that email is inefficient, but git is a terrible >>> way to have a discussion. We should attempt to be sure we have >>> those, and that everybody has a chance to see the proposals without >>> having to go to the web five times a day. >>> >>> Please take this as a request for regular git-send-email updates to >>> this list, so I can see them if I'm not online. Maybe add a boilerplate >>> line to direct to the git repo webui. I'm sure a few others will >>> appreciate it too. >> >> Samba does well with the web-based discussion mechanism >> around merge-requests (MR's) in gitlab. I assume github >> has something similar. >> >> Maybe send the initial patch to the list with a link >> to the github MR so people interested in reviewing/discussing >> can follow along there ? > > well, if I could have it the way I wanted, then this would be it. But I > understand that adopting new workflows is not something I can impose -- > at least not without paying for an insane amount of Lakritz-Gitarren > that I tend to use to bribe metze into doing something I want him to do. :) I'm in for github if you send me some too! https://www.gutschmecker.com/produkt/haevy-metal-salzige-gitarren-10-x-150-g-tuete/ > The problem is not so much doing the *review* on patches sent to the > list. While Samba has moved away from doing review on patch emails, it > can certainly be done. Clearly, this effort bridges the Linux and Samba processes. We can definitely try. I guess I'm going to take some convincing. Tom. > The point is, once you go beyond "review" by taking someone else's > patchset, modifying it deeply, reordering patches, adding patches, > rewriting patches, dropping patches and so on, that's when the > patchset-as-email workflow explodes and coordination via git is needed. > > Once such a collaboratively worked on patchset stabilizes, it can of > course again go to the mailing list. > > -slow >
next prev parent reply other threads:[~2021-09-29 16:45 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-26 13:55 Namjae Jeon 2021-09-26 13:55 ` [PATCH v3 1/5] ksmbd: add the check to vaildate if stream protocol length exceeds maximum value Namjae Jeon 2021-09-26 13:55 ` [PATCH v3 2/5] ksmbd: add validation in smb2_ioctl Namjae Jeon 2021-09-26 13:55 ` [PATCH v3 3/5] ksmbd: add request buffer validation in smb2_set_info Namjae Jeon 2021-09-26 13:55 ` [PATCH v3 4/5] ksmbd: check strictly data area in ksmbd_smb2_check_message() Namjae Jeon 2021-09-26 13:55 ` [PATCH v3 5/5] ksmbd: add validation in smb2 negotiate Namjae Jeon 2021-09-26 14:27 ` [PATCH v3 0/5] ksmbd: a bunch of patches Ralph Boehme 2021-09-26 15:32 ` Namjae Jeon 2021-09-27 15:42 ` Ralph Boehme 2021-09-27 23:57 ` Namjae Jeon 2021-09-28 3:26 ` Ralph Boehme 2021-09-28 13:43 ` Ralph Boehme 2021-09-28 14:23 ` Namjae Jeon 2021-09-28 16:33 ` Ralph Boehme 2021-09-28 17:33 ` Jeremy Allison 2021-09-29 15:28 ` Tom Talpey 2021-09-29 15:42 ` Jeremy Allison 2021-09-29 16:38 ` Ralph Boehme 2021-09-29 16:45 ` Tom Talpey [this message] 2021-09-29 17:08 ` Ralph Boehme 2021-09-29 17:11 ` Steve French 2021-09-29 17:18 ` Ralph Boehme 2021-09-30 0:32 ` Namjae Jeon 2021-09-30 0:51 ` Hyunchul Lee 2021-09-30 7:57 ` Ralph Boehme 2021-09-28 23:27 ` Namjae Jeon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH v3 0/5] ksmbd: a bunch of patches' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.