From: Shannon Nelson <shannon.nelson@oracle.com> To: "Nambiar, Amritha" <amritha.nambiar@intel.com>, intel-wired-lan@osuosl.org Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org> Subject: Re: [Intel-wired-lan] [jkirsher/next-queue PATCH v4 6/6] i40e: Enable cloud filters via tc-flower Date: Thu, 26 Oct 2017 14:35:41 -0700 [thread overview] Message-ID: <28335085-cc51-85a5-d602-4ae9d1e1088c@oracle.com> (raw) In-Reply-To: <888ad716-75c7-f1c0-439a-58fdeb9a7234@intel.com> On 10/26/2017 2:29 PM, Nambiar, Amritha wrote: > On 10/11/2017 4:30 PM, Shannon Nelson wrote: >> On 10/10/2017 5:24 PM, Amritha Nambiar wrote: [...] >>> + /* For Geneve, the VNI should be placed in offset shifted by a >>> + * byte than the offset for the Tenant ID for rest of the >> >> This comment isn't quite clear - maybe s/than/then/ ? > > How about, "For Geneve, the VNI should begin at an offset shifted by a > byte compared to the offset normally used for the Tenant ID for other > tunnel types" ? Or maybe "Due to hardware eccentricities, the VNI for Geneve is shifted one more byte further than normally used for Tenant ID in other tunnel types" [...] >>> + dev_err(&pf->pdev->dev, "Bad src port mask 0x%04x\n", >> >> Consider using %pI4 > > For ports, I'll keep the 0x%04x. I'll change to %pI4 for the IPv4 > address masks. Oh, right, that one's a port. sln
WARNING: multiple messages have this Message-ID (diff)
From: Shannon Nelson <shannon.nelson@oracle.com> To: intel-wired-lan@osuosl.org Subject: [Intel-wired-lan] [jkirsher/next-queue PATCH v4 6/6] i40e: Enable cloud filters via tc-flower Date: Thu, 26 Oct 2017 14:35:41 -0700 [thread overview] Message-ID: <28335085-cc51-85a5-d602-4ae9d1e1088c@oracle.com> (raw) In-Reply-To: <888ad716-75c7-f1c0-439a-58fdeb9a7234@intel.com> On 10/26/2017 2:29 PM, Nambiar, Amritha wrote: > On 10/11/2017 4:30 PM, Shannon Nelson wrote: >> On 10/10/2017 5:24 PM, Amritha Nambiar wrote: [...] >>> + /* For Geneve, the VNI should be placed in offset shifted by a >>> + * byte than the offset for the Tenant ID for rest of the >> >> This comment isn't quite clear - maybe s/than/then/ ? > > How about, "For Geneve, the VNI should begin at an offset shifted by a > byte compared to the offset normally used for the Tenant ID for other > tunnel types" ? Or maybe "Due to hardware eccentricities, the VNI for Geneve is shifted one more byte further than normally used for Tenant ID in other tunnel types" [...] >>> + dev_err(&pf->pdev->dev, "Bad src port mask 0x%04x\n", >> >> Consider using %pI4 > > For ports, I'll keep the 0x%04x. I'll change to %pI4 for the IPv4 > address masks. Oh, right, that one's a port. sln
next prev parent reply other threads:[~2017-10-26 21:35 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-10-11 0:24 [jkirsher/next-queue PATCH v4 0/6] tc-flower based cloud filters in i40e Amritha Nambiar 2017-10-11 0:24 ` [Intel-wired-lan] " Amritha Nambiar 2017-10-11 0:24 ` [jkirsher/next-queue PATCH v4 1/6] cls_flower: Offload classid to hardware Amritha Nambiar 2017-10-11 0:24 ` [Intel-wired-lan] " Amritha Nambiar 2017-10-11 0:24 ` [jkirsher/next-queue PATCH v4 2/6] i40e: Map TCs with the VSI seids Amritha Nambiar 2017-10-11 0:24 ` [Intel-wired-lan] " Amritha Nambiar 2017-10-11 0:24 ` [jkirsher/next-queue PATCH v4 3/6] i40e: Cloud filter mode for set_switch_config command Amritha Nambiar 2017-10-11 0:24 ` [Intel-wired-lan] " Amritha Nambiar 2017-10-11 23:30 ` Shannon Nelson 2017-10-11 23:30 ` Shannon Nelson 2017-10-26 21:10 ` Nambiar, Amritha 2017-10-26 21:10 ` Nambiar, Amritha 2017-10-11 0:24 ` [jkirsher/next-queue PATCH v4 4/6] i40e: Admin queue definitions for cloud filters Amritha Nambiar 2017-10-11 0:24 ` [Intel-wired-lan] " Amritha Nambiar 2017-10-11 23:30 ` Shannon Nelson 2017-10-11 23:30 ` Shannon Nelson 2017-10-11 0:24 ` [jkirsher/next-queue PATCH v4 5/6] i40e: Clean up of " Amritha Nambiar 2017-10-11 0:24 ` [Intel-wired-lan] " Amritha Nambiar 2017-10-11 23:30 ` Shannon Nelson 2017-10-11 23:30 ` Shannon Nelson 2017-10-11 0:24 ` [jkirsher/next-queue PATCH v4 6/6] i40e: Enable cloud filters via tc-flower Amritha Nambiar 2017-10-11 0:24 ` [Intel-wired-lan] " Amritha Nambiar 2017-10-11 23:30 ` Shannon Nelson 2017-10-11 23:30 ` Shannon Nelson 2017-10-26 21:29 ` Nambiar, Amritha 2017-10-26 21:29 ` Nambiar, Amritha 2017-10-26 21:35 ` Shannon Nelson [this message] 2017-10-26 21:35 ` Shannon Nelson 2017-10-26 21:47 ` Nambiar, Amritha 2017-10-26 21:47 ` Nambiar, Amritha 2017-10-11 12:42 ` [jkirsher/next-queue PATCH v4 0/6] tc-flower based cloud filters in i40e Jamal Hadi Salim 2017-10-11 12:42 ` [Intel-wired-lan] " Jamal Hadi Salim 2017-10-11 22:41 ` Nambiar, Amritha 2017-10-11 22:41 ` [Intel-wired-lan] " Nambiar, Amritha 2017-10-11 12:56 ` Jiri Pirko 2017-10-11 12:56 ` [Intel-wired-lan] " Jiri Pirko 2017-10-11 17:46 ` Alexander Duyck 2017-10-11 17:46 ` [Intel-wired-lan] " Alexander Duyck 2017-10-11 20:38 ` Jiri Pirko 2017-10-11 20:38 ` [Intel-wired-lan] " Jiri Pirko 2017-10-11 20:46 ` David Miller 2017-10-11 20:46 ` [Intel-wired-lan] " David Miller 2017-10-11 20:58 ` Jiri Pirko 2017-10-11 20:58 ` [Intel-wired-lan] " Jiri Pirko 2017-10-11 21:19 ` David Miller 2017-10-11 21:19 ` [Intel-wired-lan] " David Miller 2017-10-11 21:28 ` Jiri Pirko 2017-10-11 21:28 ` [Intel-wired-lan] " Jiri Pirko 2017-10-12 7:05 ` Alexander Duyck 2017-10-12 7:05 ` [Intel-wired-lan] " Alexander Duyck 2017-10-12 7:30 ` Jiri Pirko 2017-10-12 7:30 ` [Intel-wired-lan] " Jiri Pirko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=28335085-cc51-85a5-d602-4ae9d1e1088c@oracle.com \ --to=shannon.nelson@oracle.com \ --cc=amritha.nambiar@intel.com \ --cc=intel-wired-lan@osuosl.org \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.