All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Kevin Hilman <khilman@baylibre.com>
Cc: Finlye Xiao <finley.xiao@rock-chips.com>,
	srinivas.kandagatla@linaro.org, maxime.ripard@free-electrons.com,
	robh+dt@kernel.org, frowand.list@gmail.com, sre@kernel.org,
	dbaryshkov@gmail.com, dwmw2@infradead.org, mark.rutland@arm.com,
	nm@ti.com, rjw@rjwysocki.net, viresh.kumar@linaro.org,
	sboyd@codeaurora.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	wxt@rock-chips.com, jay.xu@rock-chips.com,
	rocky.hao@rock-chips.com, tim.chen@rock-chips.com,
	tony.xie@rock-chips.com, ulysses.huang@rock-chips.com,
	lin.huang@rock-chips.com
Subject: Re: [PATCH v2 1/4] nvmem: rockchip-efuse: Change initcall to subsys
Date: Fri, 19 Aug 2016 00:29:55 +0200	[thread overview]
Message-ID: <2844104.lMUOkH8YJy@phil> (raw)
In-Reply-To: <m2mvkaq6c5.fsf@baylibre.com>

Am Donnerstag, 18. August 2016, 13:28:58 CEST schrieb Kevin Hilman:
> Finlye Xiao <finley.xiao@rock-chips.com> writes:
> > From: Finley Xiao <finley.xiao@rock-chips.com>
> > 
> > We will register a cpufreq notifier for adjusting opp's voltage, and it
> > need to fetch cpu's leakage from efuse in the notifier_call. so the efuse
> > driver should probe before cpufreq driver.
> > 
> > Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com>
> 
> Why can't this be handled with deferred probling?  initcall ordering is
> a can of worms.

I think the issue is less between efuse and avs driver, but more between avs 
driver and cpufreq. The avs driver aims to modify the opp table and thus wants 
to do that / register the notifier before cpufreq starts.

And as there is no direct connection between cpufreq and the avs driver, 
making cpufreq defer probing is probably not really easy.

WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Kevin Hilman <khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org,
	nm-l0cyMroinI0@public.gmane.org,
	viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	tony.xie-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	tim.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	ulysses.huang-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	jay.xu-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	lin.huang-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org,
	sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	Finlye Xiao <finley.xiao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	rocky.hao-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org
Subject: Re: [PATCH v2 1/4] nvmem: rockchip-efuse: Change initcall to subsys
Date: Fri, 19 Aug 2016 00:29:55 +0200	[thread overview]
Message-ID: <2844104.lMUOkH8YJy@phil> (raw)
In-Reply-To: <m2mvkaq6c5.fsf-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>

Am Donnerstag, 18. August 2016, 13:28:58 CEST schrieb Kevin Hilman:
> Finlye Xiao <finley.xiao-TNX95d0MmH7DzftRWevZcw@public.gmane.org> writes:
> > From: Finley Xiao <finley.xiao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> > 
> > We will register a cpufreq notifier for adjusting opp's voltage, and it
> > need to fetch cpu's leakage from efuse in the notifier_call. so the efuse
> > driver should probe before cpufreq driver.
> > 
> > Signed-off-by: Finley Xiao <finley.xiao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> 
> Why can't this be handled with deferred probling?  initcall ordering is
> a can of worms.

I think the issue is less between efuse and avs driver, but more between avs 
driver and cpufreq. The avs driver aims to modify the opp table and thus wants 
to do that / register the notifier before cpufreq starts.

And as there is no direct connection between cpufreq and the avs driver, 
making cpufreq defer probing is probably not really easy.

WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/4] nvmem: rockchip-efuse: Change initcall to subsys
Date: Fri, 19 Aug 2016 00:29:55 +0200	[thread overview]
Message-ID: <2844104.lMUOkH8YJy@phil> (raw)
In-Reply-To: <m2mvkaq6c5.fsf@baylibre.com>

Am Donnerstag, 18. August 2016, 13:28:58 CEST schrieb Kevin Hilman:
> Finlye Xiao <finley.xiao@rock-chips.com> writes:
> > From: Finley Xiao <finley.xiao@rock-chips.com>
> > 
> > We will register a cpufreq notifier for adjusting opp's voltage, and it
> > need to fetch cpu's leakage from efuse in the notifier_call. so the efuse
> > driver should probe before cpufreq driver.
> > 
> > Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com>
> 
> Why can't this be handled with deferred probling?  initcall ordering is
> a can of worms.

I think the issue is less between efuse and avs driver, but more between avs 
driver and cpufreq. The avs driver aims to modify the opp table and thus wants 
to do that / register the notifier before cpufreq starts.

And as there is no direct connection between cpufreq and the avs driver, 
making cpufreq defer probing is probably not really easy.

  reply	other threads:[~2016-08-19  0:53 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-18  8:52 [PATCH v2 0/4] PM / AVS: add Rockchip cpu avs Finlye Xiao
2016-08-18  8:52 ` Finlye Xiao
2016-08-18  8:52 ` Finlye Xiao
2016-08-18  8:52 ` [PATCH v2 1/4] nvmem: rockchip-efuse: Change initcall to subsys Finlye Xiao
2016-08-18  8:52   ` Finlye Xiao
2016-08-18  8:52   ` Finlye Xiao
2016-08-18 18:28   ` Kevin Hilman
2016-08-18 18:28     ` Kevin Hilman
2016-08-18 18:28     ` Kevin Hilman
2016-08-18 22:29     ` Heiko Stuebner [this message]
2016-08-18 22:29       ` Heiko Stuebner
2016-08-18 22:29       ` Heiko Stuebner
2016-08-19 16:19       ` Kevin Hilman
2016-08-19 16:19         ` Kevin Hilman
2016-08-19 16:19         ` Kevin Hilman
2016-08-18  8:52 ` [PATCH v2 2/4] of: introduce of_property_read_s32_index Finlye Xiao
2016-08-18  8:52   ` Finlye Xiao
2016-08-18  8:52   ` Finlye Xiao
2016-08-18  8:52 ` [PATCH v2 3/4] dt-bindings: add binding document for Rockchip cpu avs Finlye Xiao
2016-08-18  8:52   ` Finlye Xiao
2016-08-18  8:52   ` Finlye Xiao
2016-08-18  8:52 ` [PATCH v2 4/4] PM / AVS: rockchip-cpu-avs: add driver handling " Finlye Xiao
2016-08-18  8:52   ` Finlye Xiao
2016-08-18  8:52   ` Finlye Xiao
2016-08-18 19:02   ` Kevin Hilman
2016-08-18 19:02     ` Kevin Hilman
2016-08-18 19:02     ` Kevin Hilman
2016-08-29  6:08   ` Viresh Kumar
2016-08-29  6:08     ` Viresh Kumar
2016-08-29  6:08     ` Viresh Kumar
2016-09-12 21:55     ` Stephen Boyd
2016-09-12 21:55       ` Stephen Boyd
2016-09-26  3:55       ` Viresh Kumar
2016-09-26  3:55         ` Viresh Kumar
2016-09-26  3:55         ` Viresh Kumar
2016-09-26  8:05         ` Heiko Stuebner
2016-09-26  8:05           ` Heiko Stuebner
2016-09-27  8:40           ` Finley Xiao
2016-09-27  8:40             ` Finley Xiao
2016-09-27  8:40             ` Finley Xiao
2016-09-27 22:14           ` Stephen Boyd
2016-09-27 22:14             ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2844104.lMUOkH8YJy@phil \
    --to=heiko@sntech.de \
    --cc=dbaryshkov@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=finley.xiao@rock-chips.com \
    --cc=frowand.list@gmail.com \
    --cc=jay.xu@rock-chips.com \
    --cc=khilman@baylibre.com \
    --cc=lin.huang@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=nm@ti.com \
    --cc=rjw@rjwysocki.net \
    --cc=robh+dt@kernel.org \
    --cc=rocky.hao@rock-chips.com \
    --cc=sboyd@codeaurora.org \
    --cc=sre@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tim.chen@rock-chips.com \
    --cc=tony.xie@rock-chips.com \
    --cc=ulysses.huang@rock-chips.com \
    --cc=viresh.kumar@linaro.org \
    --cc=wxt@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.