* [PATCH] tools: PCI: exit with error code when test fails
@ 2018-09-20 15:02 Jean-Jacques Hiblot
2018-10-04 11:11 ` Lorenzo Pieralisi
2019-03-22 11:06 ` Lorenzo Pieralisi
0 siblings, 2 replies; 6+ messages in thread
From: Jean-Jacques Hiblot @ 2018-09-20 15:02 UTC (permalink / raw)
To: kishon, lorenzo.pieralisi, linux-pci; +Cc: linux-kernel, Jean-Jacques Hiblot
This makes it easier to use pcitest in automated setups.
Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
---
tools/pci/pcitest.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c
index af146bb..5adc8cd 100644
--- a/tools/pci/pcitest.c
+++ b/tools/pci/pcitest.c
@@ -143,6 +143,7 @@ static int run_test(struct pci_test *test)
}
fflush(stdout);
+ return (ret < 0) ? ret : 1 - ret; /* return 0 if test succeeded */
}
int main(int argc, char **argv)
@@ -231,6 +232,5 @@ int main(int argc, char **argv)
return -EINVAL;
}
- run_test(test);
- return 0;
+ return run_test(test);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] tools: PCI: exit with error code when test fails
2018-09-20 15:02 [PATCH] tools: PCI: exit with error code when test fails Jean-Jacques Hiblot
@ 2018-10-04 11:11 ` Lorenzo Pieralisi
2018-11-16 12:01 ` Lorenzo Pieralisi
2019-03-22 11:06 ` Lorenzo Pieralisi
1 sibling, 1 reply; 6+ messages in thread
From: Lorenzo Pieralisi @ 2018-10-04 11:11 UTC (permalink / raw)
To: Jean-Jacques Hiblot, kishon; +Cc: linux-pci, linux-kernel
On Thu, Sep 20, 2018 at 05:02:53PM +0200, Jean-Jacques Hiblot wrote:
> This makes it easier to use pcitest in automated setups.
>
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> ---
> tools/pci/pcitest.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c
> index af146bb..5adc8cd 100644
> --- a/tools/pci/pcitest.c
> +++ b/tools/pci/pcitest.c
> @@ -143,6 +143,7 @@ static int run_test(struct pci_test *test)
> }
>
> fflush(stdout);
> + return (ret < 0) ? ret : 1 - ret; /* return 0 if test succeeded */
> }
>
> int main(int argc, char **argv)
> @@ -231,6 +232,5 @@ int main(int argc, char **argv)
> return -EINVAL;
> }
>
> - run_test(test);
> - return 0;
> + return run_test(test);
> }
> --
> 2.7.4
>
Hi Kishon,
are you OK with this patch ? Please let me know.
Thanks,
Lorenzo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tools: PCI: exit with error code when test fails
2018-10-04 11:11 ` Lorenzo Pieralisi
@ 2018-11-16 12:01 ` Lorenzo Pieralisi
2019-03-19 15:43 ` Lorenzo Pieralisi
0 siblings, 1 reply; 6+ messages in thread
From: Lorenzo Pieralisi @ 2018-11-16 12:01 UTC (permalink / raw)
To: Jean-Jacques Hiblot, kishon; +Cc: linux-pci, linux-kernel
On Thu, Oct 04, 2018 at 12:11:44PM +0100, Lorenzo Pieralisi wrote:
> On Thu, Sep 20, 2018 at 05:02:53PM +0200, Jean-Jacques Hiblot wrote:
> > This makes it easier to use pcitest in automated setups.
> >
> > Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> > ---
> > tools/pci/pcitest.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c
> > index af146bb..5adc8cd 100644
> > --- a/tools/pci/pcitest.c
> > +++ b/tools/pci/pcitest.c
> > @@ -143,6 +143,7 @@ static int run_test(struct pci_test *test)
> > }
> >
> > fflush(stdout);
> > + return (ret < 0) ? ret : 1 - ret; /* return 0 if test succeeded */
> > }
> >
> > int main(int argc, char **argv)
> > @@ -231,6 +232,5 @@ int main(int argc, char **argv)
> > return -EINVAL;
> > }
> >
> > - run_test(test);
> > - return 0;
> > + return run_test(test);
> > }
> > --
> > 2.7.4
> >
>
> Hi Kishon,
>
> are you OK with this patch ? Please let me know.
Please let me know, I need your ACK on this to queue it.
Lorenzo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tools: PCI: exit with error code when test fails
2018-11-16 12:01 ` Lorenzo Pieralisi
@ 2019-03-19 15:43 ` Lorenzo Pieralisi
2019-03-20 5:12 ` Kishon Vijay Abraham I
0 siblings, 1 reply; 6+ messages in thread
From: Lorenzo Pieralisi @ 2019-03-19 15:43 UTC (permalink / raw)
To: Jean-Jacques Hiblot, kishon; +Cc: linux-pci, linux-kernel
On Fri, Nov 16, 2018 at 12:01:13PM +0000, Lorenzo Pieralisi wrote:
> On Thu, Oct 04, 2018 at 12:11:44PM +0100, Lorenzo Pieralisi wrote:
> > On Thu, Sep 20, 2018 at 05:02:53PM +0200, Jean-Jacques Hiblot wrote:
> > > This makes it easier to use pcitest in automated setups.
> > >
> > > Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> > > ---
> > > tools/pci/pcitest.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c
> > > index af146bb..5adc8cd 100644
> > > --- a/tools/pci/pcitest.c
> > > +++ b/tools/pci/pcitest.c
> > > @@ -143,6 +143,7 @@ static int run_test(struct pci_test *test)
> > > }
> > >
> > > fflush(stdout);
> > > + return (ret < 0) ? ret : 1 - ret; /* return 0 if test succeeded */
> > > }
> > >
> > > int main(int argc, char **argv)
> > > @@ -231,6 +232,5 @@ int main(int argc, char **argv)
> > > return -EINVAL;
> > > }
> > >
> > > - run_test(test);
> > > - return 0;
> > > + return run_test(test);
> > > }
> > > --
> > > 2.7.4
> > >
> >
> > Hi Kishon,
> >
> > are you OK with this patch ? Please let me know.
>
> Please let me know, I need your ACK on this to queue it.
Hi Kishon,
I will merge this patch unless you have something against it,
please let me know.
Thanks,
Lorenzo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tools: PCI: exit with error code when test fails
2019-03-19 15:43 ` Lorenzo Pieralisi
@ 2019-03-20 5:12 ` Kishon Vijay Abraham I
0 siblings, 0 replies; 6+ messages in thread
From: Kishon Vijay Abraham I @ 2019-03-20 5:12 UTC (permalink / raw)
To: Lorenzo Pieralisi, Jean-Jacques Hiblot; +Cc: linux-pci, linux-kernel
On 19/03/19 9:13 PM, Lorenzo Pieralisi wrote:
> On Fri, Nov 16, 2018 at 12:01:13PM +0000, Lorenzo Pieralisi wrote:
>> On Thu, Oct 04, 2018 at 12:11:44PM +0100, Lorenzo Pieralisi wrote:
>>> On Thu, Sep 20, 2018 at 05:02:53PM +0200, Jean-Jacques Hiblot wrote:
>>>> This makes it easier to use pcitest in automated setups.
>>>>
>>>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
>>>> ---
>>>> tools/pci/pcitest.c | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c
>>>> index af146bb..5adc8cd 100644
>>>> --- a/tools/pci/pcitest.c
>>>> +++ b/tools/pci/pcitest.c
>>>> @@ -143,6 +143,7 @@ static int run_test(struct pci_test *test)
>>>> }
>>>>
>>>> fflush(stdout);
>>>> + return (ret < 0) ? ret : 1 - ret; /* return 0 if test succeeded */
>>>> }
>>>>
>>>> int main(int argc, char **argv)
>>>> @@ -231,6 +232,5 @@ int main(int argc, char **argv)
>>>> return -EINVAL;
>>>> }
>>>>
>>>> - run_test(test);
>>>> - return 0;
>>>> + return run_test(test);
>>>> }
>>>> --
>>>> 2.7.4
>>>>
>>>
>>> Hi Kishon,
>>>
>>> are you OK with this patch ? Please let me know.
>>
>> Please let me know, I need your ACK on this to queue it.
>
> Hi Kishon,
>
> I will merge this patch unless you have something against it,
> please let me know.
Sorry for missing this earlier.
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
>
> Thanks,
> Lorenzo
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tools: PCI: exit with error code when test fails
2018-09-20 15:02 [PATCH] tools: PCI: exit with error code when test fails Jean-Jacques Hiblot
2018-10-04 11:11 ` Lorenzo Pieralisi
@ 2019-03-22 11:06 ` Lorenzo Pieralisi
1 sibling, 0 replies; 6+ messages in thread
From: Lorenzo Pieralisi @ 2019-03-22 11:06 UTC (permalink / raw)
To: Jean-Jacques Hiblot; +Cc: kishon, linux-pci, linux-kernel
On Thu, Sep 20, 2018 at 05:02:53PM +0200, Jean-Jacques Hiblot wrote:
> This makes it easier to use pcitest in automated setups.
>
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> ---
> tools/pci/pcitest.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to pci/misc for v5.2, thanks.
Lorenzo
> diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c
> index af146bb..5adc8cd 100644
> --- a/tools/pci/pcitest.c
> +++ b/tools/pci/pcitest.c
> @@ -143,6 +143,7 @@ static int run_test(struct pci_test *test)
> }
>
> fflush(stdout);
> + return (ret < 0) ? ret : 1 - ret; /* return 0 if test succeeded */
> }
>
> int main(int argc, char **argv)
> @@ -231,6 +232,5 @@ int main(int argc, char **argv)
> return -EINVAL;
> }
>
> - run_test(test);
> - return 0;
> + return run_test(test);
> }
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-22 11:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-20 15:02 [PATCH] tools: PCI: exit with error code when test fails Jean-Jacques Hiblot
2018-10-04 11:11 ` Lorenzo Pieralisi
2018-11-16 12:01 ` Lorenzo Pieralisi
2019-03-19 15:43 ` Lorenzo Pieralisi
2019-03-20 5:12 ` Kishon Vijay Abraham I
2019-03-22 11:06 ` Lorenzo Pieralisi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.