[Qemu-devel] [PATCH] vscsi: send the CHECK_CONDITION status down together with autosense data

* [Qemu-devel] [PATCH] vscsi: send the CHECK_CONDITION status down together with autosense data
@ 2011-08-24 15:28 Paolo Bonzini
  2011-08-24 21:41 ` Alexander Graf
  2011-08-25  1:18 ` David Gibson
  0 siblings, 2 replies; 5+ messages in thread
From: Paolo Bonzini @ 2011-08-24 15:28 UTC (permalink / raw)
  To: qemu-devel; +Cc: thuth, agraf

I introduced this bug in commit 05751d3 (vscsi: always use get_sense,
2011-08-03) because at the time there was no way to expose a sense
condition to SLOF and Linux manages to work around the bug.  However,
the bug becomes evident now that SCSI devices also report unit
attention on reset.

SLOF also has problems dealing with unit attention conditions, so
it still will not boot even with this fix (just like OpenBIOS).
IBM folks are aware of their part of the bug. :-)

Reported-by: Thomas Huth <thuth@linux.vnet.ibm.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/spapr_vscsi.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/hw/spapr_vscsi.c b/hw/spapr_vscsi.c
index fc9ac6a..ee6f6bf 100644
--- a/hw/spapr_vscsi.c
+++ b/hw/spapr_vscsi.c
@@ -483,7 +483,6 @@ static void vscsi_command_complete(SCSIRequest *sreq, uint32_t status)
     if (status == CHECK_CONDITION) {
         req->senselen = scsi_req_get_sense(req->sreq, req->sense,
                                            sizeof(req->sense));
-        status = 0;
         dprintf("VSCSI: Sense data, %d bytes:\n", len);
         dprintf("       %02x  %02x  %02x  %02x  %02x  %02x  %02x  %02x\n",
                 req->sense[0], req->sense[1], req->sense[2], req->sense[3],
-- 
1.7.6

^ permalink raw reply related	[flat|nested] 5+ messages in thread