* [Qemu-devel] [PATCH] vscsi: send the CHECK_CONDITION status down together with autosense data
@ 2011-08-24 15:28 Paolo Bonzini
2011-08-24 21:41 ` Alexander Graf
2011-08-25 1:18 ` David Gibson
0 siblings, 2 replies; 5+ messages in thread
From: Paolo Bonzini @ 2011-08-24 15:28 UTC (permalink / raw)
To: qemu-devel; +Cc: thuth, agraf
I introduced this bug in commit 05751d3 (vscsi: always use get_sense,
2011-08-03) because at the time there was no way to expose a sense
condition to SLOF and Linux manages to work around the bug. However,
the bug becomes evident now that SCSI devices also report unit
attention on reset.
SLOF also has problems dealing with unit attention conditions, so
it still will not boot even with this fix (just like OpenBIOS).
IBM folks are aware of their part of the bug. :-)
Reported-by: Thomas Huth <thuth@linux.vnet.ibm.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/spapr_vscsi.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/hw/spapr_vscsi.c b/hw/spapr_vscsi.c
index fc9ac6a..ee6f6bf 100644
--- a/hw/spapr_vscsi.c
+++ b/hw/spapr_vscsi.c
@@ -483,7 +483,6 @@ static void vscsi_command_complete(SCSIRequest *sreq, uint32_t status)
if (status == CHECK_CONDITION) {
req->senselen = scsi_req_get_sense(req->sreq, req->sense,
sizeof(req->sense));
- status = 0;
dprintf("VSCSI: Sense data, %d bytes:\n", len);
dprintf(" %02x %02x %02x %02x %02x %02x %02x %02x\n",
req->sense[0], req->sense[1], req->sense[2], req->sense[3],
--
1.7.6
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] vscsi: send the CHECK_CONDITION status down together with autosense data
2011-08-24 15:28 [Qemu-devel] [PATCH] vscsi: send the CHECK_CONDITION status down together with autosense data Paolo Bonzini
@ 2011-08-24 21:41 ` Alexander Graf
2011-08-25 2:23 ` David Gibson
2011-08-25 1:18 ` David Gibson
1 sibling, 1 reply; 5+ messages in thread
From: Alexander Graf @ 2011-08-24 21:41 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: David Gibson, qemu-devel Developers, thuth
On 24.08.2011, at 10:28, Paolo Bonzini wrote:
> I introduced this bug in commit 05751d3 (vscsi: always use get_sense,
> 2011-08-03) because at the time there was no way to expose a sense
> condition to SLOF and Linux manages to work around the bug. However,
> the bug becomes evident now that SCSI devices also report unit
> attention on reset.
>
> SLOF also has problems dealing with unit attention conditions, so
> it still will not boot even with this fix (just like OpenBIOS).
> IBM folks are aware of their part of the bug. :-)
David, please ack.
Alex
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] vscsi: send the CHECK_CONDITION status down together with autosense data
2011-08-24 21:41 ` Alexander Graf
@ 2011-08-25 2:23 ` David Gibson
2011-08-25 2:56 ` Alexander Graf
0 siblings, 1 reply; 5+ messages in thread
From: David Gibson @ 2011-08-25 2:23 UTC (permalink / raw)
To: Alexander Graf; +Cc: Paolo Bonzini, qemu-devel Developers, thuth
On Wed, Aug 24, 2011 at 04:41:34PM -0500, Alexander Graf wrote:
>
> On 24.08.2011, at 10:28, Paolo Bonzini wrote:
>
> > I introduced this bug in commit 05751d3 (vscsi: always use get_sense,
> > 2011-08-03) because at the time there was no way to expose a sense
> > condition to SLOF and Linux manages to work around the bug. However,
> > the bug becomes evident now that SCSI devices also report unit
> > attention on reset.
> >
> > SLOF also has problems dealing with unit attention conditions, so
> > it still will not boot even with this fix (just like OpenBIOS).
> > IBM folks are aware of their part of the bug. :-)
>
> David, please ack.
Done.
We also need to get the updated SLOF into place, I can't remember how
we sent commits involving binary blobs previously.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] vscsi: send the CHECK_CONDITION status down together with autosense data
2011-08-25 2:23 ` David Gibson
@ 2011-08-25 2:56 ` Alexander Graf
0 siblings, 0 replies; 5+ messages in thread
From: Alexander Graf @ 2011-08-25 2:56 UTC (permalink / raw)
To: David Gibson; +Cc: Paolo Bonzini, qemu-devel Developers, thuth
On 24.08.2011, at 21:23, David Gibson wrote:
> On Wed, Aug 24, 2011 at 04:41:34PM -0500, Alexander Graf wrote:
>>
>> On 24.08.2011, at 10:28, Paolo Bonzini wrote:
>>
>>> I introduced this bug in commit 05751d3 (vscsi: always use get_sense,
>>> 2011-08-03) because at the time there was no way to expose a sense
>>> condition to SLOF and Linux manages to work around the bug. However,
>>> the bug becomes evident now that SCSI devices also report unit
>>> attention on reset.
>>>
>>> SLOF also has problems dealing with unit attention conditions, so
>>> it still will not boot even with this fix (just like OpenBIOS).
>>> IBM folks are aware of their part of the bug. :-)
>>
>> David, please ack.
>
> Done.
>
> We also need to get the updated SLOF into place, I can't remember how
> we sent commits involving binary blobs previously.
git-format-patch should spit out a git binary diff just fine :)
Alex
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] vscsi: send the CHECK_CONDITION status down together with autosense data
2011-08-24 15:28 [Qemu-devel] [PATCH] vscsi: send the CHECK_CONDITION status down together with autosense data Paolo Bonzini
2011-08-24 21:41 ` Alexander Graf
@ 2011-08-25 1:18 ` David Gibson
1 sibling, 0 replies; 5+ messages in thread
From: David Gibson @ 2011-08-25 1:18 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: agraf, qemu-devel, thuth
On Wed, Aug 24, 2011 at 05:28:52PM +0200, Paolo Bonzini wrote:
> I introduced this bug in commit 05751d3 (vscsi: always use get_sense,
> 2011-08-03) because at the time there was no way to expose a sense
> condition to SLOF and Linux manages to work around the bug. However,
> the bug becomes evident now that SCSI devices also report unit
> attention on reset.
>
> SLOF also has problems dealing with unit attention conditions, so
> it still will not boot even with this fix (just like OpenBIOS).
> IBM folks are aware of their part of the bug. :-)
>
> Reported-by: Thomas Huth <thuth@linux.vnet.ibm.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
With both this, and the SLOF update from Thomas, we can boot again.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-08-25 2:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-24 15:28 [Qemu-devel] [PATCH] vscsi: send the CHECK_CONDITION status down together with autosense data Paolo Bonzini
2011-08-24 21:41 ` Alexander Graf
2011-08-25 2:23 ` David Gibson
2011-08-25 2:56 ` Alexander Graf
2011-08-25 1:18 ` David Gibson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.