* [meta-networking][PATCH] cifs-utils: add 5.9
@ 2013-03-18 7:40 Koen Kooi
2013-03-18 18:33 ` Joe MacDonald
0 siblings, 1 reply; 4+ messages in thread
From: Koen Kooi @ 2013-03-18 7:40 UTC (permalink / raw)
To: openembedded-devel; +Cc: Koen Kooi
Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---
meta-networking/recipes-support/cifs/cifs-utils_git.bb | 15 +++++++++++++++
1 file changed, 15 insertions(+)
create mode 100644 meta-networking/recipes-support/cifs/cifs-utils_git.bb
diff --git a/meta-networking/recipes-support/cifs/cifs-utils_git.bb b/meta-networking/recipes-support/cifs/cifs-utils_git.bb
new file mode 100644
index 0000000..c78527e
--- /dev/null
+++ b/meta-networking/recipes-support/cifs/cifs-utils_git.bb
@@ -0,0 +1,15 @@
+DESCRIPTION = "A a package of utilities for doing and managing mounts of the Linux CIFS filesystem."
+HOMEPAGE = "http://wiki.samba.org/index.php/LinuxCIFS_utils"
+
+LICENSE = "GPLv3 && LGPLv3"
+LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
+
+PV = "5.9"
+
+SRCREV = "353d491dcb5d69d31434abeb962c8e9a49c36867"
+SRC_URI = "git://git.samba.org/cifs-utils.git"
+
+S = "${WORKDIR}/git"
+
+inherit autotools
+
--
1.8.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [meta-networking][PATCH] cifs-utils: add 5.9
2013-03-18 7:40 [meta-networking][PATCH] cifs-utils: add 5.9 Koen Kooi
@ 2013-03-18 18:33 ` Joe MacDonald
2013-03-18 18:36 ` Koen Kooi
0 siblings, 1 reply; 4+ messages in thread
From: Joe MacDonald @ 2013-03-18 18:33 UTC (permalink / raw)
To: openembedded-devel; +Cc: Koen Kooi
[-- Attachment #1: Type: text/plain, Size: 2073 bytes --]
Hey Koen,
[[oe] [meta-networking][PATCH] cifs-utils: add 5.9] On 13.03.18 (Mon 08:40) Koen Kooi wrote:
> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> ---
> meta-networking/recipes-support/cifs/cifs-utils_git.bb | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
> create mode 100644 meta-networking/recipes-support/cifs/cifs-utils_git.bb
>
> diff --git a/meta-networking/recipes-support/cifs/cifs-utils_git.bb b/meta-networking/recipes-support/cifs/cifs-utils_git.bb
> new file mode 100644
> index 0000000..c78527e
> --- /dev/null
> +++ b/meta-networking/recipes-support/cifs/cifs-utils_git.bb
> @@ -0,0 +1,15 @@
> +DESCRIPTION = "A a package of utilities for doing and managing mounts of the Linux CIFS filesystem."
> +HOMEPAGE = "http://wiki.samba.org/index.php/LinuxCIFS_utils"
> +
> +LICENSE = "GPLv3 && LGPLv3"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
> +
> +PV = "5.9"
> +
> +SRCREV = "353d491dcb5d69d31434abeb962c8e9a49c36867"
> +SRC_URI = "git://git.samba.org/cifs-utils.git"
> +
> +S = "${WORKDIR}/git"
> +
> +inherit autotools
> +
I had to make two changes to this recipe to address the following QA:
WARNING: cifs-utils-5.9-r0: Failed to parse it's LICENSE field.
WARNING: QA Issue: cifs-utils: Files/directories were installed but not shipped
/usr/bin
/usr/sbin
First one's easy, I changed:
+LICENSE = "GPLv3 && LGPLv3"
to
+LICENSE = "GPLv3 & LGPLv3"
The second one I wasn't completely sure I was capturing what you
intended to do with this, but I added this to the bottom of your recipe:
+do_install_append() {
+ # Remove empty /usr/*bin directory since the mount helper is installed to /sbin
+ rmdir ${D}${bindir} ${D}${sbindir}
+}
This actually kind of seems like the wrong thing to do, but it also
looks like cifs-utils don't care what sbindir and bindir point at.
If you're okay with this, I'll merge the modified patch I have in tree
now, or you can send an updated patch, whichever you prefer.
--
-Joe MacDonald.
:wq
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [meta-networking][PATCH] cifs-utils: add 5.9
2013-03-18 18:33 ` Joe MacDonald
@ 2013-03-18 18:36 ` Koen Kooi
2013-03-18 19:18 ` Joe MacDonald
0 siblings, 1 reply; 4+ messages in thread
From: Koen Kooi @ 2013-03-18 18:36 UTC (permalink / raw)
To: Joe MacDonald; +Cc: <openembedded-devel@lists.openembedded.org>
Op 18 mrt. 2013 om 19:33 heeft Joe MacDonald <Joe.MacDonald@windriver.com> het volgende geschreven:
> Hey Koen,
>
> [[oe] [meta-networking][PATCH] cifs-utils: add 5.9] On 13.03.18 (Mon 08:40) Koen Kooi wrote:
>
>> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
>> ---
>> meta-networking/recipes-support/cifs/cifs-utils_git.bb | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>> create mode 100644 meta-networking/recipes-support/cifs/cifs-utils_git.bb
>>
>> diff --git a/meta-networking/recipes-support/cifs/cifs-utils_git.bb b/meta-networking/recipes-support/cifs/cifs-utils_git.bb
>> new file mode 100644
>> index 0000000..c78527e
>> --- /dev/null
>> +++ b/meta-networking/recipes-support/cifs/cifs-utils_git.bb
>> @@ -0,0 +1,15 @@
>> +DESCRIPTION = "A a package of utilities for doing and managing mounts of the Linux CIFS filesystem."
>> +HOMEPAGE = "http://wiki.samba.org/index.php/LinuxCIFS_utils"
>> +
>> +LICENSE = "GPLv3 && LGPLv3"
>> +LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
>> +
>> +PV = "5.9"
>> +
>> +SRCREV = "353d491dcb5d69d31434abeb962c8e9a49c36867"
>> +SRC_URI = "git://git.samba.org/cifs-utils.git"
>> +
>> +S = "${WORKDIR}/git"
>> +
>> +inherit autotools
>> +
>
> I had to make two changes to this recipe to address the following QA:
>
> WARNING: cifs-utils-5.9-r0: Failed to parse it's LICENSE field.
> WARNING: QA Issue: cifs-utils: Files/directories were installed but not shipped
> /usr/bin
> /usr/sbin
>
> First one's easy, I changed:
>
> +LICENSE = "GPLv3 && LGPLv3"
>
> to
>
> +LICENSE = "GPLv3 & LGPLv3"
>
> The second one I wasn't completely sure I was capturing what you
> intended to do with this, but I added this to the bottom of your recipe:
>
> +do_install_append() {
> + # Remove empty /usr/*bin directory since the mount helper is installed to /sbin
> + rmdir ${D}${bindir} ${D}${sbindir}
> +}
>
> This actually kind of seems like the wrong thing to do, but it also
> looks like cifs-utils don't care what sbindir and bindir point at.
>
> If you're okay with this, I'll merge the modified patch I have in tree
> now, or you can send an updated patch, whichever you prefer.
Yes, thanks for fixing that!
>
> --
> -Joe MacDonald.
> :wq
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [meta-networking][PATCH] cifs-utils: add 5.9
2013-03-18 18:36 ` Koen Kooi
@ 2013-03-18 19:18 ` Joe MacDonald
0 siblings, 0 replies; 4+ messages in thread
From: Joe MacDonald @ 2013-03-18 19:18 UTC (permalink / raw)
To: Koen Kooi; +Cc: <openembedded-devel@lists.openembedded.org>
[-- Attachment #1: Type: text/plain, Size: 2575 bytes --]
[Re: [oe] [meta-networking][PATCH] cifs-utils: add 5.9] On 13.03.18 (Mon 19:36) Koen Kooi wrote:
>
>
> Op 18 mrt. 2013 om 19:33 heeft Joe MacDonald <Joe.MacDonald@windriver.com> het volgende geschreven:
>
> > Hey Koen,
> >
> > [[oe] [meta-networking][PATCH] cifs-utils: add 5.9] On 13.03.18 (Mon 08:40) Koen Kooi wrote:
> >
> >> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> >> ---
> >> meta-networking/recipes-support/cifs/cifs-utils_git.bb | 15 +++++++++++++++
> >> 1 file changed, 15 insertions(+)
> >> create mode 100644 meta-networking/recipes-support/cifs/cifs-utils_git.bb
> >>
> >> diff --git a/meta-networking/recipes-support/cifs/cifs-utils_git.bb b/meta-networking/recipes-support/cifs/cifs-utils_git.bb
> >> new file mode 100644
> >> index 0000000..c78527e
> >> --- /dev/null
> >> +++ b/meta-networking/recipes-support/cifs/cifs-utils_git.bb
> >> @@ -0,0 +1,15 @@
> >> +DESCRIPTION = "A a package of utilities for doing and managing mounts of the Linux CIFS filesystem."
> >> +HOMEPAGE = "http://wiki.samba.org/index.php/LinuxCIFS_utils"
> >> +
> >> +LICENSE = "GPLv3 && LGPLv3"
> >> +LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
> >> +
> >> +PV = "5.9"
> >> +
> >> +SRCREV = "353d491dcb5d69d31434abeb962c8e9a49c36867"
> >> +SRC_URI = "git://git.samba.org/cifs-utils.git"
> >> +
> >> +S = "${WORKDIR}/git"
> >> +
> >> +inherit autotools
> >> +
> >
> > I had to make two changes to this recipe to address the following QA:
> >
> > WARNING: cifs-utils-5.9-r0: Failed to parse it's LICENSE field.
> > WARNING: QA Issue: cifs-utils: Files/directories were installed but not shipped
> > /usr/bin
> > /usr/sbin
> >
> > First one's easy, I changed:
> >
> > +LICENSE = "GPLv3 && LGPLv3"
> >
> > to
> >
> > +LICENSE = "GPLv3 & LGPLv3"
> >
> > The second one I wasn't completely sure I was capturing what you
> > intended to do with this, but I added this to the bottom of your recipe:
> >
> > +do_install_append() {
> > + # Remove empty /usr/*bin directory since the mount helper is installed to /sbin
> > + rmdir ${D}${bindir} ${D}${sbindir}
> > +}
> >
> > This actually kind of seems like the wrong thing to do, but it also
> > looks like cifs-utils don't care what sbindir and bindir point at.
> >
> > If you're okay with this, I'll merge the modified patch I have in tree
> > now, or you can send an updated patch, whichever you prefer.
>
> Yes, thanks for fixing that!
No problem. So, merged. Thanks.
--
-Joe MacDonald.
:wq
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-18 19:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-18 7:40 [meta-networking][PATCH] cifs-utils: add 5.9 Koen Kooi
2013-03-18 18:33 ` Joe MacDonald
2013-03-18 18:36 ` Koen Kooi
2013-03-18 19:18 ` Joe MacDonald
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.