From: Vlastimil Babka <vbabka@suse.cz> To: Michal Hocko <mhocko@kernel.org>, Andrew Morton <akpm@linux-foundation.org> Cc: David Rientjes <rientjes@google.com>, Mel Gorman <mgorman@suse.de>, Johannes Weiner <hannes@cmpxchg.org>, Al Viro <viro@zeniv.linux.org.uk>, linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>, Michal Hocko <mhocko@suse.com>, Kent Overstreet <kent.overstreet@gmail.com> Subject: Re: [PATCH 8/9] bcache: use kvmalloc Date: Mon, 30 Jan 2017 17:47:31 +0100 [thread overview] Message-ID: <28e7a4de-6940-5626-d382-1381640d58f0@suse.cz> (raw) In-Reply-To: <20170130094940.13546-9-mhocko@kernel.org> On 01/30/2017 10:49 AM, Michal Hocko wrote: > From: Michal Hocko <mhocko@suse.com> > > bcache_device_init uses kmalloc for small requests and vmalloc for those > which are larger than 64 pages. This alone is a strange criterion. > Moreover kmalloc can fallback to vmalloc on the failure. Let's simply > use kvmalloc instead as it knows how to handle the fallback properly I don't see why separate patch, some of the conversions in 5/9 were quite similar (except comparing with PAGE_SIZE, not 64*PAGE_SIZE), but nevermind. > Cc: Kent Overstreet <kent.overstreet@gmail.com> > Signed-off-by: Michal Hocko <mhocko@suse.com> Acked-by: Vlastimil Babka <vbabka@suse.cz> > --- > drivers/md/bcache/super.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c > index 3a19cbc8b230..4cb6b88a1465 100644 > --- a/drivers/md/bcache/super.c > +++ b/drivers/md/bcache/super.c > @@ -767,16 +767,12 @@ static int bcache_device_init(struct bcache_device *d, unsigned block_size, > } > > n = d->nr_stripes * sizeof(atomic_t); > - d->stripe_sectors_dirty = n < PAGE_SIZE << 6 > - ? kzalloc(n, GFP_KERNEL) > - : vzalloc(n); > + d->stripe_sectors_dirty = kvzalloc(n, GFP_KERNEL); > if (!d->stripe_sectors_dirty) > return -ENOMEM; > > n = BITS_TO_LONGS(d->nr_stripes) * sizeof(unsigned long); > - d->full_dirty_stripes = n < PAGE_SIZE << 6 > - ? kzalloc(n, GFP_KERNEL) > - : vzalloc(n); > + d->full_dirty_stripes = kvzalloc(n, GFP_KERNEL); > if (!d->full_dirty_stripes) > return -ENOMEM; > >
WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz> To: Michal Hocko <mhocko@kernel.org>, Andrew Morton <akpm@linux-foundation.org> Cc: David Rientjes <rientjes@google.com>, Mel Gorman <mgorman@suse.de>, Johannes Weiner <hannes@cmpxchg.org>, Al Viro <viro@zeniv.linux.org.uk>, linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>, Michal Hocko <mhocko@suse.com>, Kent Overstreet <kent.overstreet@gmail.com> Subject: Re: [PATCH 8/9] bcache: use kvmalloc Date: Mon, 30 Jan 2017 17:47:31 +0100 [thread overview] Message-ID: <28e7a4de-6940-5626-d382-1381640d58f0@suse.cz> (raw) In-Reply-To: <20170130094940.13546-9-mhocko@kernel.org> On 01/30/2017 10:49 AM, Michal Hocko wrote: > From: Michal Hocko <mhocko@suse.com> > > bcache_device_init uses kmalloc for small requests and vmalloc for those > which are larger than 64 pages. This alone is a strange criterion. > Moreover kmalloc can fallback to vmalloc on the failure. Let's simply > use kvmalloc instead as it knows how to handle the fallback properly I don't see why separate patch, some of the conversions in 5/9 were quite similar (except comparing with PAGE_SIZE, not 64*PAGE_SIZE), but nevermind. > Cc: Kent Overstreet <kent.overstreet@gmail.com> > Signed-off-by: Michal Hocko <mhocko@suse.com> Acked-by: Vlastimil Babka <vbabka@suse.cz> > --- > drivers/md/bcache/super.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c > index 3a19cbc8b230..4cb6b88a1465 100644 > --- a/drivers/md/bcache/super.c > +++ b/drivers/md/bcache/super.c > @@ -767,16 +767,12 @@ static int bcache_device_init(struct bcache_device *d, unsigned block_size, > } > > n = d->nr_stripes * sizeof(atomic_t); > - d->stripe_sectors_dirty = n < PAGE_SIZE << 6 > - ? kzalloc(n, GFP_KERNEL) > - : vzalloc(n); > + d->stripe_sectors_dirty = kvzalloc(n, GFP_KERNEL); > if (!d->stripe_sectors_dirty) > return -ENOMEM; > > n = BITS_TO_LONGS(d->nr_stripes) * sizeof(unsigned long); > - d->full_dirty_stripes = n < PAGE_SIZE << 6 > - ? kzalloc(n, GFP_KERNEL) > - : vzalloc(n); > + d->full_dirty_stripes = kvzalloc(n, GFP_KERNEL); > if (!d->full_dirty_stripes) > return -ENOMEM; > > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-01-30 16:48 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-01-30 9:49 [PATCH 0/6 v3] kvmalloc Michal Hocko 2017-01-30 9:49 ` Michal Hocko 2017-01-30 9:49 ` [PATCH 1/9] mm: introduce kv[mz]alloc helpers Michal Hocko 2017-01-30 9:49 ` Michal Hocko 2017-01-30 9:49 ` [PATCH 2/9] mm: support __GFP_REPEAT in kvmalloc_node for >32kB Michal Hocko 2017-01-30 9:49 ` Michal Hocko 2017-01-30 9:49 ` [PATCH 3/9] rhashtable: simplify a strange allocation pattern Michal Hocko 2017-01-30 9:49 ` Michal Hocko 2017-01-30 14:04 ` Vlastimil Babka 2017-01-30 14:04 ` Vlastimil Babka 2017-01-30 9:49 ` [PATCH 4/9] ila: " Michal Hocko 2017-01-30 9:49 ` Michal Hocko 2017-01-30 15:21 ` Vlastimil Babka 2017-01-30 15:21 ` Vlastimil Babka 2017-01-30 9:49 ` [PATCH 5/9] treewide: use kv[mz]alloc* rather than opencoded variants Michal Hocko 2017-01-30 9:49 ` Michal Hocko 2017-01-30 9:49 ` Michal Hocko 2017-01-30 10:21 ` Leon Romanovsky 2017-01-30 10:21 ` Leon Romanovsky 2017-01-30 16:14 ` Vlastimil Babka 2017-01-30 16:14 ` Vlastimil Babka 2017-01-30 16:14 ` Vlastimil Babka 2017-01-30 19:24 ` Kees Cook 2017-01-30 19:24 ` Kees Cook 2017-01-30 19:24 ` Kees Cook 2017-01-30 9:49 ` [PATCH 6/9] net: use kvmalloc with __GFP_REPEAT rather than open coded variant Michal Hocko 2017-01-30 9:49 ` Michal Hocko 2017-01-30 9:49 ` Michal Hocko 2017-01-30 16:36 ` Vlastimil Babka 2017-01-30 16:36 ` Vlastimil Babka 2017-01-30 9:49 ` [PATCH 7/9] md: use kvmalloc rather than opencoded variant Michal Hocko 2017-01-30 9:49 ` Michal Hocko 2017-01-30 16:42 ` Vlastimil Babka 2017-01-30 16:42 ` Vlastimil Babka 2017-02-01 17:29 ` Mikulas Patocka 2017-02-01 17:29 ` Mikulas Patocka 2017-02-01 17:58 ` Michal Hocko 2017-02-01 17:58 ` Michal Hocko 2017-01-30 9:49 ` [PATCH 8/9] bcache: use kvmalloc Michal Hocko 2017-01-30 9:49 ` Michal Hocko 2017-01-30 16:47 ` Vlastimil Babka [this message] 2017-01-30 16:47 ` Vlastimil Babka 2017-01-30 17:25 ` Michal Hocko 2017-01-30 17:25 ` Michal Hocko 2017-01-30 9:49 ` [PATCH 9/9] net, bpf: use kvzalloc helper Michal Hocko 2017-01-30 9:49 ` Michal Hocko 2017-01-30 17:20 ` Michal Hocko 2017-01-30 17:20 ` Michal Hocko 2017-02-05 10:23 ` [PATCH 0/6 v3] kvmalloc Michal Hocko 2017-02-05 10:23 ` Michal Hocko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=28e7a4de-6940-5626-d382-1381640d58f0@suse.cz \ --to=vbabka@suse.cz \ --cc=akpm@linux-foundation.org \ --cc=hannes@cmpxchg.org \ --cc=kent.overstreet@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=mhocko@kernel.org \ --cc=mhocko@suse.com \ --cc=rientjes@google.com \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.