From: Vlastimil Babka <vbabka@suse.cz> To: Michal Hocko <mhocko@kernel.org>, Andrew Morton <akpm@linux-foundation.org> Cc: David Rientjes <rientjes@google.com>, Mel Gorman <mgorman@suse.de>, Johannes Weiner <hannes@cmpxchg.org>, Al Viro <viro@zeniv.linux.org.uk>, linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>, Michal Hocko <mhocko@suse.com>, Mikulas Patocka <mpatocka@redhat.com>, Mike Snitzer <snitzer@redhat.com> Subject: Re: [PATCH 7/9] md: use kvmalloc rather than opencoded variant Date: Mon, 30 Jan 2017 17:42:18 +0100 [thread overview] Message-ID: <d80af165-9af1-97dc-edda-b1f8701164cd@suse.cz> (raw) In-Reply-To: <20170130094940.13546-8-mhocko@kernel.org> On 01/30/2017 10:49 AM, Michal Hocko wrote: > From: Michal Hocko <mhocko@suse.com> > > copy_params uses kmalloc with vmalloc fallback. We already have a helper > for that - kvmalloc. This caller requires GFP_NOIO semantic so it hasn't > been converted with many others by previous patches. All we need to > achieve this semantic is to use the scope memalloc_noio_{save,restore} > around kvmalloc. > > Cc: Mikulas Patocka <mpatocka@redhat.com> > Cc: Mike Snitzer <snitzer@redhat.com> > Signed-off-by: Michal Hocko <mhocko@suse.com> Acked-by: Vlastimil Babka <vbabka@suse.cz> > --- > drivers/md/dm-ioctl.c | 13 ++++--------- > 1 file changed, 4 insertions(+), 9 deletions(-) > > diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c > index a5a9b17f0f7f..dbf5b981f7d7 100644 > --- a/drivers/md/dm-ioctl.c > +++ b/drivers/md/dm-ioctl.c > @@ -1698,6 +1698,7 @@ static int copy_params(struct dm_ioctl __user *user, struct dm_ioctl *param_kern > struct dm_ioctl *dmi; > int secure_data; > const size_t minimum_data_size = offsetof(struct dm_ioctl, data); > + unsigned noio_flag; > > if (copy_from_user(param_kernel, user, minimum_data_size)) > return -EFAULT; > @@ -1720,15 +1721,9 @@ static int copy_params(struct dm_ioctl __user *user, struct dm_ioctl *param_kern > * Use kmalloc() rather than vmalloc() when we can. > */ > dmi = NULL; > - if (param_kernel->data_size <= KMALLOC_MAX_SIZE) > - dmi = kmalloc(param_kernel->data_size, GFP_NOIO | __GFP_NORETRY | __GFP_NOMEMALLOC | __GFP_NOWARN); > - > - if (!dmi) { > - unsigned noio_flag; > - noio_flag = memalloc_noio_save(); > - dmi = __vmalloc(param_kernel->data_size, GFP_NOIO | __GFP_HIGH | __GFP_HIGHMEM, PAGE_KERNEL); > - memalloc_noio_restore(noio_flag); > - } > + noio_flag = memalloc_noio_save(); > + dmi = kvmalloc(param_kernel->data_size, GFP_KERNEL); > + memalloc_noio_restore(noio_flag); > > if (!dmi) { > if (secure_data && clear_user(user, param_kernel->data_size)) >
WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz> To: Michal Hocko <mhocko@kernel.org>, Andrew Morton <akpm@linux-foundation.org> Cc: David Rientjes <rientjes@google.com>, Mel Gorman <mgorman@suse.de>, Johannes Weiner <hannes@cmpxchg.org>, Al Viro <viro@zeniv.linux.org.uk>, linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>, Michal Hocko <mhocko@suse.com>, Mikulas Patocka <mpatocka@redhat.com>, Mike Snitzer <snitzer@redhat.com> Subject: Re: [PATCH 7/9] md: use kvmalloc rather than opencoded variant Date: Mon, 30 Jan 2017 17:42:18 +0100 [thread overview] Message-ID: <d80af165-9af1-97dc-edda-b1f8701164cd@suse.cz> (raw) In-Reply-To: <20170130094940.13546-8-mhocko@kernel.org> On 01/30/2017 10:49 AM, Michal Hocko wrote: > From: Michal Hocko <mhocko@suse.com> > > copy_params uses kmalloc with vmalloc fallback. We already have a helper > for that - kvmalloc. This caller requires GFP_NOIO semantic so it hasn't > been converted with many others by previous patches. All we need to > achieve this semantic is to use the scope memalloc_noio_{save,restore} > around kvmalloc. > > Cc: Mikulas Patocka <mpatocka@redhat.com> > Cc: Mike Snitzer <snitzer@redhat.com> > Signed-off-by: Michal Hocko <mhocko@suse.com> Acked-by: Vlastimil Babka <vbabka@suse.cz> > --- > drivers/md/dm-ioctl.c | 13 ++++--------- > 1 file changed, 4 insertions(+), 9 deletions(-) > > diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c > index a5a9b17f0f7f..dbf5b981f7d7 100644 > --- a/drivers/md/dm-ioctl.c > +++ b/drivers/md/dm-ioctl.c > @@ -1698,6 +1698,7 @@ static int copy_params(struct dm_ioctl __user *user, struct dm_ioctl *param_kern > struct dm_ioctl *dmi; > int secure_data; > const size_t minimum_data_size = offsetof(struct dm_ioctl, data); > + unsigned noio_flag; > > if (copy_from_user(param_kernel, user, minimum_data_size)) > return -EFAULT; > @@ -1720,15 +1721,9 @@ static int copy_params(struct dm_ioctl __user *user, struct dm_ioctl *param_kern > * Use kmalloc() rather than vmalloc() when we can. > */ > dmi = NULL; > - if (param_kernel->data_size <= KMALLOC_MAX_SIZE) > - dmi = kmalloc(param_kernel->data_size, GFP_NOIO | __GFP_NORETRY | __GFP_NOMEMALLOC | __GFP_NOWARN); > - > - if (!dmi) { > - unsigned noio_flag; > - noio_flag = memalloc_noio_save(); > - dmi = __vmalloc(param_kernel->data_size, GFP_NOIO | __GFP_HIGH | __GFP_HIGHMEM, PAGE_KERNEL); > - memalloc_noio_restore(noio_flag); > - } > + noio_flag = memalloc_noio_save(); > + dmi = kvmalloc(param_kernel->data_size, GFP_KERNEL); > + memalloc_noio_restore(noio_flag); > > if (!dmi) { > if (secure_data && clear_user(user, param_kernel->data_size)) > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-01-30 16:53 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-01-30 9:49 [PATCH 0/6 v3] kvmalloc Michal Hocko 2017-01-30 9:49 ` Michal Hocko 2017-01-30 9:49 ` [PATCH 1/9] mm: introduce kv[mz]alloc helpers Michal Hocko 2017-01-30 9:49 ` Michal Hocko 2017-01-30 9:49 ` [PATCH 2/9] mm: support __GFP_REPEAT in kvmalloc_node for >32kB Michal Hocko 2017-01-30 9:49 ` Michal Hocko 2017-01-30 9:49 ` [PATCH 3/9] rhashtable: simplify a strange allocation pattern Michal Hocko 2017-01-30 9:49 ` Michal Hocko 2017-01-30 14:04 ` Vlastimil Babka 2017-01-30 14:04 ` Vlastimil Babka 2017-01-30 9:49 ` [PATCH 4/9] ila: " Michal Hocko 2017-01-30 9:49 ` Michal Hocko 2017-01-30 15:21 ` Vlastimil Babka 2017-01-30 15:21 ` Vlastimil Babka 2017-01-30 9:49 ` [PATCH 5/9] treewide: use kv[mz]alloc* rather than opencoded variants Michal Hocko 2017-01-30 9:49 ` Michal Hocko 2017-01-30 9:49 ` Michal Hocko 2017-01-30 10:21 ` Leon Romanovsky 2017-01-30 10:21 ` Leon Romanovsky 2017-01-30 16:14 ` Vlastimil Babka 2017-01-30 16:14 ` Vlastimil Babka 2017-01-30 16:14 ` Vlastimil Babka 2017-01-30 19:24 ` Kees Cook 2017-01-30 19:24 ` Kees Cook 2017-01-30 19:24 ` Kees Cook 2017-01-30 9:49 ` [PATCH 6/9] net: use kvmalloc with __GFP_REPEAT rather than open coded variant Michal Hocko 2017-01-30 9:49 ` Michal Hocko 2017-01-30 9:49 ` Michal Hocko 2017-01-30 16:36 ` Vlastimil Babka 2017-01-30 16:36 ` Vlastimil Babka 2017-01-30 9:49 ` [PATCH 7/9] md: use kvmalloc rather than opencoded variant Michal Hocko 2017-01-30 9:49 ` Michal Hocko 2017-01-30 16:42 ` Vlastimil Babka [this message] 2017-01-30 16:42 ` Vlastimil Babka 2017-02-01 17:29 ` Mikulas Patocka 2017-02-01 17:29 ` Mikulas Patocka 2017-02-01 17:58 ` Michal Hocko 2017-02-01 17:58 ` Michal Hocko 2017-01-30 9:49 ` [PATCH 8/9] bcache: use kvmalloc Michal Hocko 2017-01-30 9:49 ` Michal Hocko 2017-01-30 16:47 ` Vlastimil Babka 2017-01-30 16:47 ` Vlastimil Babka 2017-01-30 17:25 ` Michal Hocko 2017-01-30 17:25 ` Michal Hocko 2017-01-30 9:49 ` [PATCH 9/9] net, bpf: use kvzalloc helper Michal Hocko 2017-01-30 9:49 ` Michal Hocko 2017-01-30 17:20 ` Michal Hocko 2017-01-30 17:20 ` Michal Hocko 2017-02-05 10:23 ` [PATCH 0/6 v3] kvmalloc Michal Hocko 2017-02-05 10:23 ` Michal Hocko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d80af165-9af1-97dc-edda-b1f8701164cd@suse.cz \ --to=vbabka@suse.cz \ --cc=akpm@linux-foundation.org \ --cc=hannes@cmpxchg.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=mhocko@kernel.org \ --cc=mhocko@suse.com \ --cc=mpatocka@redhat.com \ --cc=rientjes@google.com \ --cc=snitzer@redhat.com \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.