From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Arnd Bergmann <arnd@arndb.de> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>, David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] drm/omap: displays: panel-dpi: add backlight dependency Date: Wed, 19 Apr 2017 23:21:35 +0300 [thread overview] Message-ID: <2979804.i6EKSW6ohY@avalon> (raw) In-Reply-To: <20170419175939.189098-1-arnd@arndb.de> Hi Arnd, Thank you for the patch. On Wednesday 19 Apr 2017 19:59:17 Arnd Bergmann wrote: > The panel driver gained support for backlight but fails to link now > when that is disabled: > > drivers/gpu/drm/omapdrm/displays/panel-dpi.o: In function > `panel_dpi_probe_of': panel-dpi.c:(.text.panel_dpi_probe_of+0xe8): > undefined reference to `of_find_backlight_by_node' > > This adds a dependency like we have for the other panel drivers. I believe the dependency should be made optional. DPI panels that don't need backlight control should be supported by a kernel that has backlight support compiled out. How about something like >From 07a98ab23b2080c79abbf8b5e7479123c50e6be7 Mon Sep 17 00:00:00 2001 From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Date: Wed, 19 Apr 2017 23:13:43 +0300 Subject: [PATCH] backlight: Define API stub when backlight support is disabled The of_find_backlight_by_node() function has a stubbed when CONFIG_OF is disabled, but drivers that use backlights optionally will still fail to link if backlight support is disabled. Fix it by defining the stub when CONFIG_BACKLIGHT_CLASS_DEVICE is disabled. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- include/linux/backlight.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/backlight.h b/include/linux/backlight.h index 5f2fd61ef4fb..fae0b189f7b4 100644 --- a/include/linux/backlight.h +++ b/include/linux/backlight.h @@ -162,7 +162,7 @@ struct generic_bl_info { void (*kick_battery)(void); }; -#ifdef CONFIG_OF +#if IS_ENABLED(CONFIG_OF) && IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) struct backlight_device *of_find_backlight_by_node(struct device_node *node); #else static inline struct backlight_device * We might need to create stubs for backlight_force_update() and backlight_device_set_brightness() too. > Fixes: 39135a305a0f ("drm/omap: displays: panel-dpi: Support for handling > backlight devices") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/gpu/drm/omapdrm/displays/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/omapdrm/displays/Kconfig > b/drivers/gpu/drm/omapdrm/displays/Kconfig index c226da145fb3..a349cb61961e > 100644 > --- a/drivers/gpu/drm/omapdrm/displays/Kconfig > +++ b/drivers/gpu/drm/omapdrm/displays/Kconfig > @@ -35,6 +35,7 @@ config DRM_OMAP_CONNECTOR_ANALOG_TV > > config DRM_OMAP_PANEL_DPI > tristate "Generic DPI panel" > + depends on BACKLIGHT_CLASS_DEVICE > help > Driver for generic DPI panels. -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Arnd Bergmann <arnd@arndb.de> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 1/3] drm/omap: displays: panel-dpi: add backlight dependency Date: Wed, 19 Apr 2017 23:21:35 +0300 [thread overview] Message-ID: <2979804.i6EKSW6ohY@avalon> (raw) In-Reply-To: <20170419175939.189098-1-arnd@arndb.de> Hi Arnd, Thank you for the patch. On Wednesday 19 Apr 2017 19:59:17 Arnd Bergmann wrote: > The panel driver gained support for backlight but fails to link now > when that is disabled: > > drivers/gpu/drm/omapdrm/displays/panel-dpi.o: In function > `panel_dpi_probe_of': panel-dpi.c:(.text.panel_dpi_probe_of+0xe8): > undefined reference to `of_find_backlight_by_node' > > This adds a dependency like we have for the other panel drivers. I believe the dependency should be made optional. DPI panels that don't need backlight control should be supported by a kernel that has backlight support compiled out. How about something like From 07a98ab23b2080c79abbf8b5e7479123c50e6be7 Mon Sep 17 00:00:00 2001 From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Date: Wed, 19 Apr 2017 23:13:43 +0300 Subject: [PATCH] backlight: Define API stub when backlight support is disabled The of_find_backlight_by_node() function has a stubbed when CONFIG_OF is disabled, but drivers that use backlights optionally will still fail to link if backlight support is disabled. Fix it by defining the stub when CONFIG_BACKLIGHT_CLASS_DEVICE is disabled. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- include/linux/backlight.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/backlight.h b/include/linux/backlight.h index 5f2fd61ef4fb..fae0b189f7b4 100644 --- a/include/linux/backlight.h +++ b/include/linux/backlight.h @@ -162,7 +162,7 @@ struct generic_bl_info { void (*kick_battery)(void); }; -#ifdef CONFIG_OF +#if IS_ENABLED(CONFIG_OF) && IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) struct backlight_device *of_find_backlight_by_node(struct device_node *node); #else static inline struct backlight_device * We might need to create stubs for backlight_force_update() and backlight_device_set_brightness() too. > Fixes: 39135a305a0f ("drm/omap: displays: panel-dpi: Support for handling > backlight devices") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/gpu/drm/omapdrm/displays/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/omapdrm/displays/Kconfig > b/drivers/gpu/drm/omapdrm/displays/Kconfig index c226da145fb3..a349cb61961e > 100644 > --- a/drivers/gpu/drm/omapdrm/displays/Kconfig > +++ b/drivers/gpu/drm/omapdrm/displays/Kconfig > @@ -35,6 +35,7 @@ config DRM_OMAP_CONNECTOR_ANALOG_TV > > config DRM_OMAP_PANEL_DPI > tristate "Generic DPI panel" > + depends on BACKLIGHT_CLASS_DEVICE > help > Driver for generic DPI panels. -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-04-19 20:20 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-19 17:59 [PATCH 1/3] drm/omap: displays: panel-dpi: add backlight dependency Arnd Bergmann 2017-04-19 17:59 ` Arnd Bergmann 2017-04-19 17:59 ` [PATCH 2/3] drm/panel: S6E3HA2 needs backlight code Arnd Bergmann 2017-04-19 17:59 ` Arnd Bergmann 2017-04-19 18:03 ` [PATCH 3/3] drm/panel: add backlight dependency for sitronix-st7789v Arnd Bergmann 2017-04-20 1:37 ` Hoegeun Kwon 2017-06-14 18:13 ` Thierry Reding 2017-06-14 18:13 ` Thierry Reding 2017-04-20 1:34 ` [PATCH 2/3] drm/panel: S6E3HA2 needs backlight code Hoegeun Kwon 2017-06-14 18:13 ` Thierry Reding 2017-06-14 18:13 ` Thierry Reding 2017-04-19 20:21 ` Laurent Pinchart [this message] 2017-04-19 20:21 ` [PATCH 1/3] drm/omap: displays: panel-dpi: add backlight dependency Laurent Pinchart 2017-04-19 20:39 ` Arnd Bergmann 2017-04-19 20:39 ` Arnd Bergmann 2017-04-20 9:01 ` Jani Nikula
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2979804.i6EKSW6ohY@avalon \ --to=laurent.pinchart@ideasonboard.com \ --cc=airlied@linux.ie \ --cc=arnd@arndb.de \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=tomi.valkeinen@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.