All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	y2038@lists.linaro.org
Subject: Re: [PATCH 4/4] input: serio: Replace timeval by timespec64
Date: Tue, 13 Sep 2016 17:13:48 +0200	[thread overview]
Message-ID: <2982423.lGps9KTD1c@wuerfel> (raw)
In-Reply-To: <1473775805-2242-5-git-send-email-deepa.kernel@gmail.com>

On Tuesday, September 13, 2016 7:10:05 AM CEST Deepa Dinamani wrote:
> struct timeval is not y2038 safe.
> All references to timeval will be deleted from the
> kernel to make it y2038 safe.
> Replace its uses by y2038 safe struct timespec64.
> 
> The timestamps changed here only keep track of delta
> times. These timestamps are also internal to kernel.
> Hence, monotonic times are sufficient here.
> The unit of the delta times is also changed in certain
> cases to nanoseconds rather than microseconds. This is
> in line with timespec64 which keeps time in nanoseconds.
> 
> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
> 

Looks all correct to me,

Acked-by: Arnd Bergmann <arnd@arndb.de>

I think it could be done a little nicer using ktime_get()
instead of ktime_get_ts64(), but probably nobody cares with
this driver.

	Arnd

  reply	other threads:[~2016-09-13 15:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-13 14:10 [PATCH 0/4] Make input drivers y2038 safe Deepa Dinamani
2016-09-13 14:10 ` [PATCH 1/4] uinput: Add ioctl for using monotonic/ boot times Deepa Dinamani
2016-09-13 14:10   ` Deepa Dinamani
2016-09-13 15:07   ` Arnd Bergmann
2016-09-15 17:11     ` Deepa Dinamani
2016-09-13 14:10 ` [PATCH 2/4] input: evdev: Replace timeval with timespec64 Deepa Dinamani
2016-09-13 15:08   ` Arnd Bergmann
2016-09-13 14:10 ` [PATCH 3/4] input: Deprecate real timestamps beyond year 2106 Deepa Dinamani
2016-09-13 14:59   ` Arnd Bergmann
2016-09-13 16:06   ` kbuild test robot
2016-09-13 16:06     ` kbuild test robot
2016-09-13 16:34     ` Deepa Dinamani
2016-09-13 20:10       ` Deepa Dinamani
2016-09-13 20:40         ` Arnd Bergmann
2016-09-13 20:40           ` Arnd Bergmann
2016-09-13 14:10 ` [PATCH 4/4] input: serio: Replace timeval by timespec64 Deepa Dinamani
2016-09-13 15:13   ` Arnd Bergmann [this message]
2016-09-15 17:21     ` Deepa Dinamani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2982423.lGps9KTD1c@wuerfel \
    --to=arnd@arndb.de \
    --cc=deepa.kernel@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=y2038@lists.linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.