* [PATCH] config: Enable USB Keyboard support on RPi4
2020-05-05 14:51 ` [PATCH] config: Enable USB Keyboard support on RPi4 Nicolas Saenz Julienne
@ 2020-05-05 15:21 ` Sylwester Nawrocki
2020-05-06 5:35 ` Bin Meng
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Sylwester Nawrocki @ 2020-05-05 15:21 UTC (permalink / raw)
To: u-boot
On 05.05.2020 16:51, Nicolas Saenz Julienne wrote:
> Supporting USB keyboards out of the box is both handy for development
> and production. Notably if u-boot is used to boot into GRUB.
>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
> Note that rpi_arm64_defconfig already supports USB keyboard. This is to
> be applied on top of Sylwester Nawrocki's PCIe/xHCI on RPi4 series.
Thanks for the patch, USB keyboard worked well for me on rpi4. I actually
used that feature to verify my PCIe/xHCI patch series.
--
Regards,
Sylwester
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH] config: Enable USB Keyboard support on RPi4
2020-05-05 14:51 ` [PATCH] config: Enable USB Keyboard support on RPi4 Nicolas Saenz Julienne
2020-05-05 15:21 ` Sylwester Nawrocki
@ 2020-05-06 5:35 ` Bin Meng
2020-05-08 15:55 ` Matthias Brugger
2020-07-08 15:49 ` Matthias Brugger
3 siblings, 0 replies; 7+ messages in thread
From: Bin Meng @ 2020-05-06 5:35 UTC (permalink / raw)
To: u-boot
On Tue, May 5, 2020 at 10:51 PM Nicolas Saenz Julienne
<nsaenzjulienne@suse.de> wrote:
>
> Supporting USB keyboards out of the box is both handy for development
> and production. Notably if u-boot is used to boot into GRUB.
>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
>
> ---
>
> Note that rpi_arm64_defconfig already supports USB keyboard. This is to
> be applied on top of Sylwester Nawrocki's PCIe/xHCI on RPi4 series.
>
> configs/rpi_4_32b_defconfig | 1 +
> configs/rpi_4_defconfig | 1 +
> 2 files changed, 2 insertions(+)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] config: Enable USB Keyboard support on RPi4
2020-05-05 14:51 ` [PATCH] config: Enable USB Keyboard support on RPi4 Nicolas Saenz Julienne
2020-05-05 15:21 ` Sylwester Nawrocki
2020-05-06 5:35 ` Bin Meng
@ 2020-05-08 15:55 ` Matthias Brugger
2020-05-08 16:41 ` Sylwester Nawrocki
2020-07-08 15:49 ` Matthias Brugger
3 siblings, 1 reply; 7+ messages in thread
From: Matthias Brugger @ 2020-05-08 15:55 UTC (permalink / raw)
To: u-boot
On 05/05/2020 16:51, Nicolas Saenz Julienne wrote:
> Supporting USB keyboards out of the box is both handy for development
> and production. Notably if u-boot is used to boot into GRUB.
>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
>
> ---
>
> Note that rpi_arm64_defconfig already supports USB keyboard. This is to
> be applied on top of Sylwester Nawrocki's PCIe/xHCI on RPi4 series.
>
> configs/rpi_4_32b_defconfig | 1 +
> configs/rpi_4_defconfig | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/configs/rpi_4_32b_defconfig b/configs/rpi_4_32b_defconfig
> index dd7da1cf06..9c5ad7684e 100644
> --- a/configs/rpi_4_32b_defconfig
> +++ b/configs/rpi_4_32b_defconfig
> @@ -42,6 +42,7 @@ CONFIG_DM_USB=y
> CONFIG_DM_USB_GADGET=y
> CONFIG_USB_XHCI_HCD=y
> CONFIG_USB_XHCI_PCI=y
> +CONFIG_USB_KEYBOARD=y
> CONFIG_USB_GADGET=y
> CONFIG_USB_GADGET_MANUFACTURER="FSL"
> CONFIG_USB_GADGET_VENDOR_NUM=0x0525
It seems we are missing
CONFIG_SYS_STDIO_DEREGISTER=y
at least for me without this, U-Boot does not build.
Regards,
Matthias
> diff --git a/configs/rpi_4_defconfig b/configs/rpi_4_defconfig
> index 6eeec4592e..1a92cd637e 100644
> --- a/configs/rpi_4_defconfig
> +++ b/configs/rpi_4_defconfig
> @@ -42,6 +42,7 @@ CONFIG_DM_USB=y
> CONFIG_DM_USB_GADGET=y
> CONFIG_USB_XHCI_HCD=y
> CONFIG_USB_XHCI_PCI=y
> +CONFIG_USB_KEYBOARD=y
> CONFIG_USB_GADGET=y
> CONFIG_USB_GADGET_MANUFACTURER="FSL"
> CONFIG_USB_GADGET_VENDOR_NUM=0x0525
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] config: Enable USB Keyboard support on RPi4
2020-05-08 15:55 ` Matthias Brugger
@ 2020-05-08 16:41 ` Sylwester Nawrocki
2020-05-08 19:07 ` Matthias Brugger
0 siblings, 1 reply; 7+ messages in thread
From: Sylwester Nawrocki @ 2020-05-08 16:41 UTC (permalink / raw)
To: u-boot
Hi Matthias,
On 08.05.2020 17:55, Matthias Brugger wrote:
> It seems we are missing
> CONFIG_SYS_STDIO_DEREGISTER=y
> at least for me without this, U-Boot does not build.
Isn't it selected by USB_KEYBOARD? I also had related build issues
which disappeared after running "make clean".
--
Regards,
Sylwester
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] config: Enable USB Keyboard support on RPi4
2020-05-08 16:41 ` Sylwester Nawrocki
@ 2020-05-08 19:07 ` Matthias Brugger
0 siblings, 0 replies; 7+ messages in thread
From: Matthias Brugger @ 2020-05-08 19:07 UTC (permalink / raw)
To: u-boot
On 08/05/2020 18:41, Sylwester Nawrocki wrote:
> Hi Matthias,
>
> On 08.05.2020 17:55, Matthias Brugger wrote:
>> It seems we are missing
>> CONFIG_SYS_STDIO_DEREGISTER=y
>> at least for me without this, U-Boot does not build.
>
> Isn't it selected by USB_KEYBOARD? I also had related build issues
> which disappeared after running "make clean".
>
Correct. Sorry for the noise.
Matthias
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] config: Enable USB Keyboard support on RPi4
2020-05-05 14:51 ` [PATCH] config: Enable USB Keyboard support on RPi4 Nicolas Saenz Julienne
` (2 preceding siblings ...)
2020-05-08 15:55 ` Matthias Brugger
@ 2020-07-08 15:49 ` Matthias Brugger
3 siblings, 0 replies; 7+ messages in thread
From: Matthias Brugger @ 2020-07-08 15:49 UTC (permalink / raw)
To: u-boot
On 05/05/2020 16:51, Nicolas Saenz Julienne wrote:
> Supporting USB keyboards out of the box is both handy for development
> and production. Notably if u-boot is used to boot into GRUB.
>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
>
Applied to rpi-next now.
I dropped the hunk for 32 bit for now, please resend once 32 bit support got
accepted.
Regards,
Matthias
> ---
>
> Note that rpi_arm64_defconfig already supports USB keyboard. This is to
> be applied on top of Sylwester Nawrocki's PCIe/xHCI on RPi4 series.
>
> configs/rpi_4_32b_defconfig | 1 +
> configs/rpi_4_defconfig | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/configs/rpi_4_32b_defconfig b/configs/rpi_4_32b_defconfig
> index dd7da1cf06..9c5ad7684e 100644
> --- a/configs/rpi_4_32b_defconfig
> +++ b/configs/rpi_4_32b_defconfig
> @@ -42,6 +42,7 @@ CONFIG_DM_USB=y
> CONFIG_DM_USB_GADGET=y
> CONFIG_USB_XHCI_HCD=y
> CONFIG_USB_XHCI_PCI=y
> +CONFIG_USB_KEYBOARD=y
> CONFIG_USB_GADGET=y
> CONFIG_USB_GADGET_MANUFACTURER="FSL"
> CONFIG_USB_GADGET_VENDOR_NUM=0x0525
> diff --git a/configs/rpi_4_defconfig b/configs/rpi_4_defconfig
> index 6eeec4592e..1a92cd637e 100644
> --- a/configs/rpi_4_defconfig
> +++ b/configs/rpi_4_defconfig
> @@ -42,6 +42,7 @@ CONFIG_DM_USB=y
> CONFIG_DM_USB_GADGET=y
> CONFIG_USB_XHCI_HCD=y
> CONFIG_USB_XHCI_PCI=y
> +CONFIG_USB_KEYBOARD=y
> CONFIG_USB_GADGET=y
> CONFIG_USB_GADGET_MANUFACTURER="FSL"
> CONFIG_USB_GADGET_VENDOR_NUM=0x0525
>
^ permalink raw reply [flat|nested] 7+ messages in thread