* Re: [Buildroot] [PATCH 1/2] board/kontron/pitx-imx8m: use extlinux instead of U-Boot boot script
2022-01-22 14:11 ` [Buildroot] [PATCH 1/2] board/kontron/pitx-imx8m: use extlinux instead of U-Boot boot script Thomas Petazzoni
@ 2022-01-22 15:59 ` Heiko Thiery
2022-01-23 22:01 ` Giulio Benetti
2022-02-12 13:50 ` Arnout Vandecappelle
2 siblings, 0 replies; 9+ messages in thread
From: Heiko Thiery @ 2022-01-22 15:59 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: Yann E. MORIN, buildroot
Hi Thomas,
Am Sa., 22. Jan. 2022 um 15:11 Uhr schrieb Thomas Petazzoni
<thomas.petazzoni@bootlin.com>:
>
> On Mon, 17 Jan 2022 09:06:16 +0100
> Heiko Thiery <heiko.thiery@gmail.com> wrote:
>
> > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> > ---
> > board/kontron/pitx-imx8m/boot.cmd | 8 --------
> > board/kontron/pitx-imx8m/extlinux.conf | 4 ++++
> > board/kontron/pitx-imx8m/genimage.cfg | 5 +++--
> > board/kontron/pitx-imx8m/post-build.sh | 7 +++++--
> > board/kontron/pitx-imx8m/post-image.sh | 2 +-
> > configs/kontron_pitx_imx8m_defconfig | 3 +--
> > 6 files changed, 14 insertions(+), 15 deletions(-)
> > delete mode 100644 board/kontron/pitx-imx8m/boot.cmd
> > create mode 100644 board/kontron/pitx-imx8m/extlinux.conf
>
> I have applied, but I am a bit worried about things are going on with
> this switch to extlinux.conf.
I was not aware of the different approaches.
> Indeed, we have:
>
> * Platforms where the UUID is hardcoded into genimage.cfg and
> extlinux.conf, such as board/beaglev/
>
> * We have platforms where a "uuid" variable in filled in U-Boot before
> triggering the extlinux.conf logic, and therefore extlinux.conf uses
> root=PARTUUID=${uuid}. For example
> board/freescale/imx7dsdb/rootfs_overlay/boot/extlinux/extlinux.conf,
> board/orangepi/orangepi-zero/boot.cmd,
> board/solidrun/mx6cubox/rootfs_overlay/boot/extlinux/extlinux.conf,
> board/technexion/imx6ulpico/rootfs_overlay/boot/extlinux/extlinux.conf,
> and a few others.
For the technexion board there is some logic in u-boot to setp and
discover the uuid of the root partition.
https://source.denx.de/u-boot/u-boot/-/blob/master/include/configs/pico-imx6ul.h#L90
> * We now have platforms (kontron/smarc-sal28 and kontron/pitx-imx8m)
> where a random UUID is generated in the post-build script, and used
> in genimage and extlinux.conf.
With this approach it is independent if the image is installed on the
SD card or the eMMC or what else. But here one pitfall is when the
image is installed on more devices.
> I'm not sure where we want to go, and how much we want to enforce "best
> practices" that are common on all platforms, or just let each platform
> do its little business.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [Buildroot] [PATCH 1/2] board/kontron/pitx-imx8m: use extlinux instead of U-Boot boot script
2022-01-22 14:11 ` [Buildroot] [PATCH 1/2] board/kontron/pitx-imx8m: use extlinux instead of U-Boot boot script Thomas Petazzoni
2022-01-22 15:59 ` Heiko Thiery
@ 2022-01-23 22:01 ` Giulio Benetti
2022-01-24 5:42 ` Sergey Kuzminov
2022-02-12 13:50 ` Arnout Vandecappelle
2 siblings, 1 reply; 9+ messages in thread
From: Giulio Benetti @ 2022-01-23 22:01 UTC (permalink / raw)
To: Thomas Petazzoni, Heiko Thiery; +Cc: Yann E. MORIN, buildroot
Hi Thomas,
On 22/01/22 15:11, Thomas Petazzoni wrote:
> On Mon, 17 Jan 2022 09:06:16 +0100
> Heiko Thiery <heiko.thiery@gmail.com> wrote:
>
>> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
>> ---
>> board/kontron/pitx-imx8m/boot.cmd | 8 --------
>> board/kontron/pitx-imx8m/extlinux.conf | 4 ++++
>> board/kontron/pitx-imx8m/genimage.cfg | 5 +++--
>> board/kontron/pitx-imx8m/post-build.sh | 7 +++++--
>> board/kontron/pitx-imx8m/post-image.sh | 2 +-
>> configs/kontron_pitx_imx8m_defconfig | 3 +--
>> 6 files changed, 14 insertions(+), 15 deletions(-)
>> delete mode 100644 board/kontron/pitx-imx8m/boot.cmd
>> create mode 100644 board/kontron/pitx-imx8m/extlinux.conf
>
> I have applied, but I am a bit worried about things are going on with
> this switch to extlinux.conf.
>
> Indeed, we have:
>
> * Platforms where the UUID is hardcoded into genimage.cfg and
> extlinux.conf, such as board/beaglev/
>
> * We have platforms where a "uuid" variable in filled in U-Boot before
> triggering the extlinux.conf logic, and therefore extlinux.conf uses
> root=PARTUUID=${uuid}. For example
> board/freescale/imx7dsdb/rootfs_overlay/boot/extlinux/extlinux.conf,
> board/orangepi/orangepi-zero/boot.cmd,
> board/solidrun/mx6cubox/rootfs_overlay/boot/extlinux/extlinux.conf,
> board/technexion/imx6ulpico/rootfs_overlay/boot/extlinux/extlinux.conf,
> and a few others.
>
> * We now have platforms (kontron/smarc-sal28 and kontron/pitx-imx8m)
> where a random UUID is generated in the post-build script, and used
> in genimage and extlinux.conf.
>
> I'm not sure where we want to go, and how much we want to enforce "best
> practices" that are common on all platforms, or just let each platform
> do its little business.
IMHO the worst drawback I see while using extlinux.conf VS boot.scr is
the missing checksum. Especially on embedded systems we deeply treat.
Not having such checksum can make system booting without a parameter on
linux command line for example, only because 1 ASCII has been corrupted.
I prefer the system to not boot at all in general instead of having it
"working" while hiding some potential problem.
What do you and All think about this?
Best regards
--
Giulio Benetti
Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [Buildroot] [PATCH 1/2] board/kontron/pitx-imx8m: use extlinux instead of U-Boot boot script
2022-01-23 22:01 ` Giulio Benetti
@ 2022-01-24 5:42 ` Sergey Kuzminov
2022-01-24 8:12 ` Giulio Benetti
0 siblings, 1 reply; 9+ messages in thread
From: Sergey Kuzminov @ 2022-01-24 5:42 UTC (permalink / raw)
To: Giulio Benetti, Thomas Petazzoni, Heiko Thiery; +Cc: Yann E. MORIN, buildroot
Hi All,
24.01.2022 01:01, Giulio Benetti:
> IMHO the worst drawback I see while using extlinux.conf VS boot.scr is
> the missing checksum. Especially on embedded systems we deeply treat.
> Not having such checksum can make system booting without a parameter on
> linux command line for example, only because 1 ASCII has been corrupted.
> I prefer the system to not boot at all in general instead of having it
> "working" while hiding some potential problem.
>
> What do you and All think about this?
IMHO extlinux.conf is more debugging friendly.
Boot.scr requires the following command:
mkimage -C none -A arm -T script -d boot.cmd boot.scr
The mkimage utility (BR2_PACKAGE_HOST_UBOOT_TOOLS) is not on the board,
you need to transfer the converted file over the network. Or reconnect
the microSD card.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH 1/2] board/kontron/pitx-imx8m: use extlinux instead of U-Boot boot script
2022-01-24 5:42 ` Sergey Kuzminov
@ 2022-01-24 8:12 ` Giulio Benetti
0 siblings, 0 replies; 9+ messages in thread
From: Giulio Benetti @ 2022-01-24 8:12 UTC (permalink / raw)
To: Sergey Kuzminov; +Cc: Heiko Thiery, Yann E. MORIN, Thomas Petazzoni, buildroot
> Il giorno 24 gen 2022, alle ore 06:43, Sergey Kuzminov <kuzminov.sergey81@gmail.com> ha scritto:
>
> Hi All,
>
> 24.01.2022 01:01, Giulio Benetti:
>> IMHO the worst drawback I see while using extlinux.conf VS boot.scr is the missing checksum. Especially on embedded systems we deeply treat.
>> Not having such checksum can make system booting without a parameter on linux command line for example, only because 1 ASCII has been corrupted.
>> I prefer the system to not boot at all in general instead of having it "working" while hiding some potential problem.
>> What do you and All think about this?
>
> IMHO extlinux.conf is more debugging friendly.
>
> Boot.scr requires the following command:
> mkimage -C none -A arm -T script -d boot.cmd boot.scr
>
> The mkimage utility (BR2_PACKAGE_HOST_UBOOT_TOOLS) is not on the board, you need to transfer the converted file over the network. Or reconnect the microSD card.
I agree with this too. I’ve found myself many times blaming because I couldn’t simply modify boot.scr on target and reboot.
But I find it still dangerous.
Another thing that I don’t find possible to do with extlinux.conf is using uboot scripting possibility that enables you to do lot or things, like fdt-overlay expand and apply, show a bmp instead of having a static splashscreen and so on.
I don’t think this is achievable with extlinux.conf
These are only my thoughts but I still don’t have a solution honestly. In particular to uniform boards.
Best regards
Giulio
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Buildroot] [PATCH 1/2] board/kontron/pitx-imx8m: use extlinux instead of U-Boot boot script
2022-01-22 14:11 ` [Buildroot] [PATCH 1/2] board/kontron/pitx-imx8m: use extlinux instead of U-Boot boot script Thomas Petazzoni
2022-01-22 15:59 ` Heiko Thiery
2022-01-23 22:01 ` Giulio Benetti
@ 2022-02-12 13:50 ` Arnout Vandecappelle
2 siblings, 0 replies; 9+ messages in thread
From: Arnout Vandecappelle @ 2022-02-12 13:50 UTC (permalink / raw)
To: Thomas Petazzoni, Heiko Thiery; +Cc: Yann E. MORIN, buildroot
On 22/01/2022 15:11, Thomas Petazzoni wrote:
> On Mon, 17 Jan 2022 09:06:16 +0100
> Heiko Thiery <heiko.thiery@gmail.com> wrote:
>
>> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
>> ---
>> board/kontron/pitx-imx8m/boot.cmd | 8 --------
>> board/kontron/pitx-imx8m/extlinux.conf | 4 ++++
>> board/kontron/pitx-imx8m/genimage.cfg | 5 +++--
>> board/kontron/pitx-imx8m/post-build.sh | 7 +++++--
>> board/kontron/pitx-imx8m/post-image.sh | 2 +-
>> configs/kontron_pitx_imx8m_defconfig | 3 +--
>> 6 files changed, 14 insertions(+), 15 deletions(-)
>> delete mode 100644 board/kontron/pitx-imx8m/boot.cmd
>> create mode 100644 board/kontron/pitx-imx8m/extlinux.conf
>
> I have applied, but I am a bit worried about things are going on with
> this switch to extlinux.conf.
>
> Indeed, we have:
>
> * Platforms where the UUID is hardcoded into genimage.cfg and
> extlinux.conf, such as board/beaglev/
>
> * We have platforms where a "uuid" variable in filled in U-Boot before
> triggering the extlinux.conf logic, and therefore extlinux.conf uses
> root=PARTUUID=${uuid}. For example
> board/freescale/imx7dsdb/rootfs_overlay/boot/extlinux/extlinux.conf,
> board/orangepi/orangepi-zero/boot.cmd,
> board/solidrun/mx6cubox/rootfs_overlay/boot/extlinux/extlinux.conf,
> board/technexion/imx6ulpico/rootfs_overlay/boot/extlinux/extlinux.conf,
> and a few others.
>
> * We now have platforms (kontron/smarc-sal28 and kontron/pitx-imx8m)
> where a random UUID is generated in the post-build script, and used
> in genimage and extlinux.conf.
>
> I'm not sure where we want to go, and how much we want to enforce "best
> practices" that are common on all platforms, or just let each platform
> do its little business.
It's like the preference we have for extlinux.conf in an ext4 filesystem: we
prefer it over FAT, but it's not a really hard requirement, and we're definitely
not going to update existing defconfigs unless an actual developer with the
board tests them.
Between all of those options, I think the randomly generated UUID is probably
the best one. Well, actually, the automatic filling in by U-Boot is the best one
but not all boards support that I guess.
Regards,
Arnout
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 9+ messages in thread