* [meta-oe][PATCH 1/2] chrpath: fix SRC_URI
@ 2018-06-01 22:14 Oleksandr Kravchuk
2018-06-01 22:14 ` [meta-oe][PATCH 2/2] iso-codes: " Oleksandr Kravchuk
2018-06-02 5:24 ` [meta-oe][PATCH 1/2] chrpath: " Alexander Kanavin
0 siblings, 2 replies; 9+ messages in thread
From: Oleksandr Kravchuk @ 2018-06-01 22:14 UTC (permalink / raw)
To: openembedded-core; +Cc: Oleksandr Kravchuk
Signed-off-by: Oleksandr Kravchuk <dev@sashko.rv.ua>
---
meta/recipes-devtools/chrpath/chrpath_0.16.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-devtools/chrpath/chrpath_0.16.bb b/meta/recipes-devtools/chrpath/chrpath_0.16.bb
index b61eef9c8b..0428210567 100644
--- a/meta/recipes-devtools/chrpath/chrpath_0.16.bb
+++ b/meta/recipes-devtools/chrpath/chrpath_0.16.bb
@@ -7,7 +7,7 @@ BUGTRACKER = "http://alioth.debian.org/tracker/?atid=412807&group_id=31052"
LICENSE = "GPLv2"
LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552"
-SRC_URI = "https://alioth.debian.org/frs/download.php/file/3979/chrpath-0.16.tar.gz \
+SRC_URI = "https://src.fedoraproject.org/lookaside/extras/chrpath/chrpath-0.16.tar.gz/2bf8d1d1ee345fc8a7915576f5649982/chrpath-0.16.tar.gz \
file://standarddoc.patch"
SRC_URI[md5sum] = "2bf8d1d1ee345fc8a7915576f5649982"
--
2.17.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [meta-oe][PATCH 2/2] iso-codes: fix SRC_URI
2018-06-01 22:14 [meta-oe][PATCH 1/2] chrpath: fix SRC_URI Oleksandr Kravchuk
@ 2018-06-01 22:14 ` Oleksandr Kravchuk
2018-06-02 5:19 ` Alexander Kanavin
2018-06-02 5:24 ` [meta-oe][PATCH 1/2] chrpath: " Alexander Kanavin
1 sibling, 1 reply; 9+ messages in thread
From: Oleksandr Kravchuk @ 2018-06-01 22:14 UTC (permalink / raw)
To: openembedded-core; +Cc: Oleksandr Kravchuk
Signed-off-by: Oleksandr Kravchuk <dev@sashko.rv.ua>
---
meta/recipes-support/iso-codes/iso-codes_3.77.bb | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/recipes-support/iso-codes/iso-codes_3.77.bb b/meta/recipes-support/iso-codes/iso-codes_3.77.bb
index bd613ac573..d899a7fa82 100644
--- a/meta/recipes-support/iso-codes/iso-codes_3.77.bb
+++ b/meta/recipes-support/iso-codes/iso-codes_3.77.bb
@@ -3,6 +3,7 @@ LICENSE = "LGPLv2.1"
LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c"
SRC_URI = "https://pkg-isocodes.alioth.debian.org/downloads/iso-codes-${PV}.tar.xz"
+SRC_URI = "https://ftp.osuosl.org/pub/blfs/conglomeration/iso-codes/iso-codes-${PV}.tar.xz"
SRC_URI[md5sum] = "9d0d06cfb4634428b300845edcd7140a"
SRC_URI[sha256sum] = "21cd73a4c6f95d9474ebfcffd4e065223857720f24858e564f4409b19f7f0d90"
--
2.17.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [meta-oe][PATCH 2/2] iso-codes: fix SRC_URI
2018-06-01 22:14 ` [meta-oe][PATCH 2/2] iso-codes: " Oleksandr Kravchuk
@ 2018-06-02 5:19 ` Alexander Kanavin
2018-06-02 13:35 ` Oleksandr Kravchuk
0 siblings, 1 reply; 9+ messages in thread
From: Alexander Kanavin @ 2018-06-02 5:19 UTC (permalink / raw)
To: Oleksandr Kravchuk; +Cc: Oleksandr Kravchuk, openembedded-core
2018-06-02 1:14 GMT+03:00 Oleksandr Kravchuk
<open.source@oleksandr-kravchuk.com>:
> SRC_URI = "https://pkg-isocodes.alioth.debian.org/downloads/iso-codes-${PV}.tar.xz"
> +SRC_URI = "https://ftp.osuosl.org/pub/blfs/conglomeration/iso-codes/iso-codes-${PV}.tar.xz"
The correct new URI is
https://salsa.debian.org/iso-codes-team/iso-codes, don't grab a random
ftp from google search results please.
Alex
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-oe][PATCH 1/2] chrpath: fix SRC_URI
2018-06-01 22:14 [meta-oe][PATCH 1/2] chrpath: fix SRC_URI Oleksandr Kravchuk
2018-06-01 22:14 ` [meta-oe][PATCH 2/2] iso-codes: " Oleksandr Kravchuk
@ 2018-06-02 5:24 ` Alexander Kanavin
2018-06-02 13:45 ` Oleksandr Kravchuk
1 sibling, 1 reply; 9+ messages in thread
From: Alexander Kanavin @ 2018-06-02 5:24 UTC (permalink / raw)
To: Oleksandr Kravchuk; +Cc: Oleksandr Kravchuk, openembedded-core
2018-06-02 1:14 GMT+03:00 Oleksandr Kravchuk
<open.source@oleksandr-kravchuk.com>:
> -SRC_URI = "https://alioth.debian.org/frs/download.php/file/3979/chrpath-0.16.tar.gz \
> +SRC_URI = "https://src.fedoraproject.org/lookaside/extras/chrpath/chrpath-0.16.tar.gz/2bf8d1d1ee345fc8a7915576f5649982/chrpath-0.16.tar.gz \
> file://standarddoc.patch"
It's better to stick with debian, the tarball is still available
through ${DEBIAN_MIRROR}:
http://http.debian.net/debian/pool/main/c/chrpath/chrpath_0.16.orig.tar.gz
Can you also investigate the other instances of alioth, namely shadow
and minicom please?
Alex
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-oe][PATCH 2/2] iso-codes: fix SRC_URI
2018-06-02 5:19 ` Alexander Kanavin
@ 2018-06-02 13:35 ` Oleksandr Kravchuk
2018-06-02 21:35 ` Alexander Kanavin
0 siblings, 1 reply; 9+ messages in thread
From: Oleksandr Kravchuk @ 2018-06-02 13:35 UTC (permalink / raw)
To: Alexander Kanavin, Oleksandr Kravchuk; +Cc: openembedded-core
On 02/06/18 07:19, Alexander Kanavin wrote:
> 2018-06-02 1:14 GMT+03:00 Oleksandr Kravchuk
> <open.source@oleksandr-kravchuk.com>:
>> SRC_URI = "https://pkg-isocodes.alioth.debian.org/downloads/iso-codes-${PV}.tar.xz"
>> +SRC_URI = "https://ftp.osuosl.org/pub/blfs/conglomeration/iso-codes/iso-codes-${PV}.tar.xz"
> The correct new URI is
> https://salsa.debian.org/iso-codes-team/iso-codes, don't grab a random
> ftp from google search results please.
>
> Alex
It is not always easy to find "the new" official URI. I took the one
that was around for a long time, not "a random ftp from google search
results".
I will fix and resend the patch.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-oe][PATCH 1/2] chrpath: fix SRC_URI
2018-06-02 5:24 ` [meta-oe][PATCH 1/2] chrpath: " Alexander Kanavin
@ 2018-06-02 13:45 ` Oleksandr Kravchuk
2018-06-02 21:40 ` Alexander Kanavin
0 siblings, 1 reply; 9+ messages in thread
From: Oleksandr Kravchuk @ 2018-06-02 13:45 UTC (permalink / raw)
To: Alexander Kanavin, Oleksandr Kravchuk; +Cc: openembedded-core
On 02/06/18 07:24, Alexander Kanavin wrote:
> 2018-06-02 1:14 GMT+03:00 Oleksandr Kravchuk
> <open.source@oleksandr-kravchuk.com>:
>> -SRC_URI = "https://alioth.debian.org/frs/download.php/file/3979/chrpath-0.16.tar.gz \
>> +SRC_URI = "https://src.fedoraproject.org/lookaside/extras/chrpath/chrpath-0.16.tar.gz/2bf8d1d1ee345fc8a7915576f5649982/chrpath-0.16.tar.gz \
>> file://standarddoc.patch"
> It's better to stick with debian, the tarball is still available
> through ${DEBIAN_MIRROR}:
> http://http.debian.net/debian/pool/main/c/chrpath/chrpath_0.16.orig.tar.gz
>
> Can you also investigate the other instances of alioth, namely shadow
> and minicom please?
>
> Alex
This is a subjective statement. Having mirrors is great, but having a
working SRC_URI in the recipe and mirrors five times great: I have seen
both original source and the mirror being inaccessible for a period of
time multiple times.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-oe][PATCH 2/2] iso-codes: fix SRC_URI
2018-06-02 13:35 ` Oleksandr Kravchuk
@ 2018-06-02 21:35 ` Alexander Kanavin
2018-06-02 21:38 ` Oleksandr Kravchuk
0 siblings, 1 reply; 9+ messages in thread
From: Alexander Kanavin @ 2018-06-02 21:35 UTC (permalink / raw)
To: Oleksandr Kravchuk; +Cc: openembedded-core
I'm sorry for being terse. Reviewing patches before morning coffee is
not always a great idea.
When changing SRC_URI, you still need to explain in the commit message
what's wrong with the old URI and how the new URI was chosen.
Specifically here, alioth is not temporarily down, it has been
deliberately taken offline:
https://wiki.debian.org/Alioth
and the same wiki page lists salsa.debian.org as the successor. Any
debian-driven projects are likely to have been moved there, and so
that's the first place I had checked.
Alex
2018-06-02 16:35 GMT+03:00 Oleksandr Kravchuk
<open.source@oleksandr-kravchuk.com>:
> On 02/06/18 07:19, Alexander Kanavin wrote:
>>
>> 2018-06-02 1:14 GMT+03:00 Oleksandr Kravchuk
>> <open.source@oleksandr-kravchuk.com>:
>>>
>>> SRC_URI =
>>> "https://pkg-isocodes.alioth.debian.org/downloads/iso-codes-${PV}.tar.xz"
>>> +SRC_URI =
>>> "https://ftp.osuosl.org/pub/blfs/conglomeration/iso-codes/iso-codes-${PV}.tar.xz"
>>
>> The correct new URI is
>> https://salsa.debian.org/iso-codes-team/iso-codes, don't grab a random
>> ftp from google search results please.
>>
>> Alex
>
> It is not always easy to find "the new" official URI. I took the one that
> was around for a long time, not "a random ftp from google search results".
>
> I will fix and resend the patch.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-oe][PATCH 2/2] iso-codes: fix SRC_URI
2018-06-02 21:35 ` Alexander Kanavin
@ 2018-06-02 21:38 ` Oleksandr Kravchuk
0 siblings, 0 replies; 9+ messages in thread
From: Oleksandr Kravchuk @ 2018-06-02 21:38 UTC (permalink / raw)
To: Alexander Kanavin, Oleksandr Kravchuk; +Cc: openembedded-core
No feelings were touched. I should have indeed explained why the SRC_URI
was changed.
I'll update the patch. Cheers.
On 02/06/18 23:35, Alexander Kanavin wrote:
> I'm sorry for being terse. Reviewing patches before morning coffee is
> not always a great idea.
>
> When changing SRC_URI, you still need to explain in the commit message
> what's wrong with the old URI and how the new URI was chosen.
>
> Specifically here, alioth is not temporarily down, it has been
> deliberately taken offline:
>
> https://wiki.debian.org/Alioth
>
> and the same wiki page lists salsa.debian.org as the successor. Any
> debian-driven projects are likely to have been moved there, and so
> that's the first place I had checked.
>
> Alex
>
> 2018-06-02 16:35 GMT+03:00 Oleksandr Kravchuk
> <open.source@oleksandr-kravchuk.com>:
>> On 02/06/18 07:19, Alexander Kanavin wrote:
>>> 2018-06-02 1:14 GMT+03:00 Oleksandr Kravchuk
>>> <open.source@oleksandr-kravchuk.com>:
>>>> SRC_URI =
>>>> "https://pkg-isocodes.alioth.debian.org/downloads/iso-codes-${PV}.tar.xz"
>>>> +SRC_URI =
>>>> "https://ftp.osuosl.org/pub/blfs/conglomeration/iso-codes/iso-codes-${PV}.tar.xz"
>>> The correct new URI is
>>> https://salsa.debian.org/iso-codes-team/iso-codes, don't grab a random
>>> ftp from google search results please.
>>>
>>> Alex
>> It is not always easy to find "the new" official URI. I took the one that
>> was around for a long time, not "a random ftp from google search results".
>>
>> I will fix and resend the patch.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-oe][PATCH 1/2] chrpath: fix SRC_URI
2018-06-02 13:45 ` Oleksandr Kravchuk
@ 2018-06-02 21:40 ` Alexander Kanavin
0 siblings, 0 replies; 9+ messages in thread
From: Alexander Kanavin @ 2018-06-02 21:40 UTC (permalink / raw)
To: Oleksandr Kravchuk; +Cc: openembedded-core
2018-06-02 16:45 GMT+03:00 Oleksandr Kravchuk
<open.source@oleksandr-kravchuk.com>:
>> It's better to stick with debian, the tarball is still available
>> through ${DEBIAN_MIRROR}:
>> http://http.debian.net/debian/pool/main/c/chrpath/chrpath_0.16.orig.tar.gz
>>
>> Can you also investigate the other instances of alioth, namely shadow
>> and minicom please?
>>
>> Alex
>
>
> This is a subjective statement. Having mirrors is great, but having a
> working SRC_URI in the recipe and mirrors five times great: I have seen both
> original source and the mirror being inaccessible for a period of time
> multiple times.
${DEBIAN_MIRROR} is not a mirror for alioth, it's a mirror for debian
packages repository and their original tarballs. The place where
apt-get looks for .deb packages in Debian. So it's unlikely to go
offline.
As chrpath is a debian project, we should prefer taking it from Debian
rather than other sources. That way it is more likely that it will be
kept up to date.
Alex
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-06-02 21:40 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-01 22:14 [meta-oe][PATCH 1/2] chrpath: fix SRC_URI Oleksandr Kravchuk
2018-06-01 22:14 ` [meta-oe][PATCH 2/2] iso-codes: " Oleksandr Kravchuk
2018-06-02 5:19 ` Alexander Kanavin
2018-06-02 13:35 ` Oleksandr Kravchuk
2018-06-02 21:35 ` Alexander Kanavin
2018-06-02 21:38 ` Oleksandr Kravchuk
2018-06-02 5:24 ` [meta-oe][PATCH 1/2] chrpath: " Alexander Kanavin
2018-06-02 13:45 ` Oleksandr Kravchuk
2018-06-02 21:40 ` Alexander Kanavin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.