From: Julien Grall <julien.grall@arm.com> To: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org> Cc: "tee-dev@lists.linaro.org" <tee-dev@lists.linaro.org>, Wei Liu <wei.liu2@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com> Subject: Re: [PATCH v5 09/10] tools/arm: tee: add "tee" option for xl.cfg Date: Mon, 3 Jun 2019 13:44:25 +0100 [thread overview] Message-ID: <2b7d24b8-02a0-3ff6-bfa3-56811063a70e@arm.com> (raw) In-Reply-To: <20190521212530.12706-10-volodymyr_babchuk@epam.com> Hi Volodymyr, Some comment on the documentation, the rest looks good to me. On 21/05/2019 22:26, Volodymyr Babchuk wrote: > diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in > index c7d70e618b..73c64dc896 100644 > --- a/docs/man/xl.cfg.5.pod.in > +++ b/docs/man/xl.cfg.5.pod.in > @@ -1544,6 +1544,25 @@ Set maximum height for pointer device. > > =back > > +=item B<tee=["none", "optee"]> This will become quite difficult to read if we add more TEE. How about: <tee="STRING">? > + > +Set TEE type for the guest. TEE is a Trusted Execution Environment -- separate > +secuse OS found on some platforms. s/secuse/secure/ I would also mention this is Arm only so far. Maybe: B<Arm only> Set TEE... > + > +=over 4 > + > +=item B<"none"> > + > +Disable TEE support at all. This is the default value. > + > +=item B<"optee"> > + > +Allow guest to access to OP-TEE enabled on the platform. Guest will not be created > +if platform does not have OP-TEE with virtualization feature or if OP-TEE will > +deny access. I have some trouble to read this paragraph. How about: "Allow a guest to use OP-TEE. Note that a virtualization-aware OP-TEE is required for this.". > + > +=back > + > =back > > =head2 Paravirtualised (PV) Guest Specific Options Cheers, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Julien Grall <julien.grall@arm.com> To: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org> Cc: "tee-dev@lists.linaro.org" <tee-dev@lists.linaro.org>, Wei Liu <wei.liu2@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com> Subject: Re: [Xen-devel] [PATCH v5 09/10] tools/arm: tee: add "tee" option for xl.cfg Date: Mon, 3 Jun 2019 13:44:25 +0100 [thread overview] Message-ID: <2b7d24b8-02a0-3ff6-bfa3-56811063a70e@arm.com> (raw) Message-ID: <20190603124425.mGXDFlFp_IEmv7qZQR0tSE3VgVK3SpsdRVLxh0Q9B1k@z> (raw) In-Reply-To: <20190521212530.12706-10-volodymyr_babchuk@epam.com> Hi Volodymyr, Some comment on the documentation, the rest looks good to me. On 21/05/2019 22:26, Volodymyr Babchuk wrote: > diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in > index c7d70e618b..73c64dc896 100644 > --- a/docs/man/xl.cfg.5.pod.in > +++ b/docs/man/xl.cfg.5.pod.in > @@ -1544,6 +1544,25 @@ Set maximum height for pointer device. > > =back > > +=item B<tee=["none", "optee"]> This will become quite difficult to read if we add more TEE. How about: <tee="STRING">? > + > +Set TEE type for the guest. TEE is a Trusted Execution Environment -- separate > +secuse OS found on some platforms. s/secuse/secure/ I would also mention this is Arm only so far. Maybe: B<Arm only> Set TEE... > + > +=over 4 > + > +=item B<"none"> > + > +Disable TEE support at all. This is the default value. > + > +=item B<"optee"> > + > +Allow guest to access to OP-TEE enabled on the platform. Guest will not be created > +if platform does not have OP-TEE with virtualization feature or if OP-TEE will > +deny access. I have some trouble to read this paragraph. How about: "Allow a guest to use OP-TEE. Note that a virtualization-aware OP-TEE is required for this.". > + > +=back > + > =back > > =head2 Paravirtualised (PV) Guest Specific Options Cheers, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-06-03 12:44 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-21 21:25 [PATCH v5 00/10] TEE mediator (and OP-TEE) support in XEN Volodymyr Babchuk 2019-05-21 21:25 ` [Xen-devel] " Volodymyr Babchuk 2019-05-21 21:25 ` [PATCH v5 01/10] xen/arm: add generic TEE mediator framework Volodymyr Babchuk 2019-05-21 21:25 ` [Xen-devel] " Volodymyr Babchuk 2019-05-22 8:45 ` Jan Beulich 2019-05-22 8:45 ` [Xen-devel] " Jan Beulich 2019-05-22 9:27 ` Julien Grall 2019-05-22 9:27 ` [Xen-devel] " Julien Grall 2019-05-22 10:02 ` Jan Beulich 2019-05-22 10:02 ` [Xen-devel] " Jan Beulich 2019-05-22 12:04 ` Julien Grall 2019-05-22 12:04 ` [Xen-devel] " Julien Grall 2019-06-03 11:46 ` Julien Grall 2019-06-03 11:46 ` [Xen-devel] " Julien Grall 2019-06-03 11:48 ` Julien Grall 2019-06-03 11:48 ` [Xen-devel] " Julien Grall 2019-06-06 16:02 ` Julien Grall 2019-06-07 9:36 ` Julien Grall 2019-06-11 18:18 ` Volodymyr Babchuk 2019-06-11 18:26 ` Julien Grall 2019-05-21 21:25 ` [PATCH v5 02/10] xen/arm: optee: add OP-TEE header files Volodymyr Babchuk 2019-05-21 21:25 ` [Xen-devel] " Volodymyr Babchuk 2019-06-03 11:49 ` Julien Grall 2019-06-03 11:49 ` [Xen-devel] " Julien Grall 2019-06-10 18:20 ` Volodymyr Babchuk 2019-06-10 18:53 ` Julien Grall 2019-05-21 21:25 ` [PATCH v5 03/10] xen/arm: optee: add OP-TEE mediator skeleton Volodymyr Babchuk 2019-05-21 21:25 ` [Xen-devel] " Volodymyr Babchuk 2019-06-03 12:34 ` Julien Grall 2019-06-03 12:34 ` [Xen-devel] " Julien Grall 2019-05-21 21:25 ` [PATCH v5 04/10] xen/arm: optee: add fast calls handling Volodymyr Babchuk 2019-05-21 21:25 ` [Xen-devel] " Volodymyr Babchuk 2019-06-03 12:34 ` Julien Grall 2019-06-03 12:34 ` [Xen-devel] " Julien Grall 2019-05-21 21:26 ` [PATCH v5 05/10] xen/arm: optee: add std call handling Volodymyr Babchuk 2019-05-21 21:26 ` [Xen-devel] " Volodymyr Babchuk 2019-06-03 12:34 ` Julien Grall 2019-06-03 12:34 ` [Xen-devel] " Julien Grall 2019-05-21 21:26 ` [PATCH v5 06/10] xen/arm: optee: add support for RPC SHM buffers Volodymyr Babchuk 2019-05-21 21:26 ` [Xen-devel] " Volodymyr Babchuk 2019-06-03 12:33 ` Julien Grall 2019-06-03 12:33 ` [Xen-devel] " Julien Grall 2019-05-21 21:26 ` [PATCH v5 07/10] xen/arm: optee: add support for arbitrary shared memory Volodymyr Babchuk 2019-05-21 21:26 ` [Xen-devel] " Volodymyr Babchuk 2019-06-03 12:29 ` Julien Grall 2019-06-03 12:29 ` [Xen-devel] " Julien Grall 2019-05-21 21:26 ` [PATCH v5 08/10] xen/arm: optee: add support for RPC commands Volodymyr Babchuk 2019-05-21 21:26 ` [Xen-devel] " Volodymyr Babchuk 2019-06-03 12:33 ` Julien Grall 2019-06-03 12:33 ` [Xen-devel] " Julien Grall 2019-05-21 21:26 ` [PATCH v5 09/10] tools/arm: tee: add "tee" option for xl.cfg Volodymyr Babchuk 2019-05-21 21:26 ` [Xen-devel] " Volodymyr Babchuk 2019-06-03 12:44 ` Julien Grall [this message] 2019-06-03 12:44 ` Julien Grall 2019-06-03 14:47 ` Ian Jackson 2019-06-03 14:47 ` [Xen-devel] " Ian Jackson 2019-05-21 21:26 ` [PATCH v5 10/10] tools/arm: optee: create optee firmware node in DT if tee=optee Volodymyr Babchuk 2019-05-21 21:26 ` [Xen-devel] " Volodymyr Babchuk 2019-06-03 14:50 ` Ian Jackson 2019-06-03 14:50 ` [Xen-devel] " Ian Jackson 2019-06-01 14:50 ` [PATCH v5 00/10] TEE mediator (and OP-TEE) support in XEN Julien Grall 2019-06-01 14:50 ` [Xen-devel] " Julien Grall 2019-06-01 16:07 ` Volodymyr Babchuk 2019-06-01 16:07 ` [Xen-devel] " Volodymyr Babchuk 2019-06-01 16:55 ` Julien Grall 2019-06-01 16:55 ` [Xen-devel] " Julien Grall 2019-06-04 13:31 ` Volodymyr Babchuk 2019-06-06 15:33 ` Julien Grall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2b7d24b8-02a0-3ff6-bfa3-56811063a70e@arm.com \ --to=julien.grall@arm.com \ --cc=Volodymyr_Babchuk@epam.com \ --cc=ian.jackson@eu.citrix.com \ --cc=tee-dev@lists.linaro.org \ --cc=wei.liu2@citrix.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.