All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacek Anaszewski <jacek.anaszewski-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Wu Fenglin <fenglinw-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	'Pavel Machek' <pavel-+ZI9xUNit7I@public.gmane.org>
Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	'Richard Purdie'
	<rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org>,
	'Rob Herring' <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	'Mark Rutland' <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	subbaram-jfJNa2p1gH1BDgjK7y7TUQ@public.gmane.org,
	aghayal-Rm6X0d1/PG5y9aJCnZT0Uw@public.gmane.org,
	wruan-jfJNa2p1gH1BDgjK7y7TUQ@public.gmane.org,
	kgunda-Rm6X0d1/PG5y9aJCnZT0Uw@public.gmane.org
Subject: Re: [PATCH V1 1/2] leds: leds-qti-rgb: Add LED driver for QTI TRI_LED module
Date: Thu, 1 Jun 2017 21:31:40 +0200	[thread overview]
Message-ID: <2c01fa38-b711-56af-5458-e726540d37ea@gmail.com> (raw)
In-Reply-To: <002d01d2da6e$42a987b0$c7fc9710$@codeaurora.org>

Hi Wu,

On 06/01/2017 02:30 AM, Wu Fenglin wrote:
> Thanks Pavel.
> I will remove these two dts properties and define the default on/off time
> values in C code.

There are many things to sort out regarding your patch. I'll be able to
give you a detailed feedback probably no sooner than at the weekend.

-- 
Best regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Wu Fenglin <fenglinw@codeaurora.org>, "'Pavel Machek'" <pavel@ucw.cz>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	"'Richard Purdie'" <rpurdie@rpsys.net>,
	"'Rob Herring'" <robh+dt@kernel.org>,
	"'Mark Rutland'" <mark.rutland@arm.com>,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	subbaram@quicinc.com, aghayal@qti.qualcomm.com,
	wruan@quicinc.com, kgunda@qti.qualcomm.com
Subject: Re: [PATCH V1 1/2] leds: leds-qti-rgb: Add LED driver for QTI TRI_LED module
Date: Thu, 1 Jun 2017 21:31:40 +0200	[thread overview]
Message-ID: <2c01fa38-b711-56af-5458-e726540d37ea@gmail.com> (raw)
In-Reply-To: <002d01d2da6e$42a987b0$c7fc9710$@codeaurora.org>

Hi Wu,

On 06/01/2017 02:30 AM, Wu Fenglin wrote:
> Thanks Pavel.
> I will remove these two dts properties and define the default on/off time
> values in C code.

There are many things to sort out regarding your patch. I'll be able to
give you a detailed feedback probably no sooner than at the weekend.

-- 
Best regards,
Jacek Anaszewski

  reply	other threads:[~2017-06-01 19:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-31  6:14 [PATCH V1 0/2] *** Add support for QTI TRI_LED and LPG module *** fenglinw
2017-05-31  6:14 ` [PATCH V1 1/2] leds: leds-qti-rgb: Add LED driver for QTI TRI_LED module fenglinw
     [not found]   ` <20170531061541.10808-2-fenglinw-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-05-31  7:55     ` Pavel Machek
2017-05-31  7:55       ` Pavel Machek
2017-05-31  8:23       ` Wu Fenglin
2017-05-31  8:23         ` Wu Fenglin
2017-05-31 16:55         ` Pavel Machek
2017-06-01  0:30           ` Wu Fenglin
2017-06-01  0:30             ` Wu Fenglin
2017-06-01 19:31             ` Jacek Anaszewski [this message]
2017-06-01 19:31               ` Jacek Anaszewski
2017-05-31  6:14 ` [PATCH V1 2/2] pwm: pwm-qti-lpg: Add PWM driver for QTI LPG module fenglinw
2017-06-03 23:20   ` kbuild test robot
2017-06-03 23:20     ` kbuild test robot
2017-06-07 21:19   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c01fa38-b711-56af-5458-e726540d37ea@gmail.com \
    --to=jacek.anaszewski-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=aghayal-Rm6X0d1/PG5y9aJCnZT0Uw@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=fenglinw-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=kgunda-Rm6X0d1/PG5y9aJCnZT0Uw@public.gmane.org \
    --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=pavel-+ZI9xUNit7I@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org \
    --cc=subbaram-jfJNa2p1gH1BDgjK7y7TUQ@public.gmane.org \
    --cc=wruan-jfJNa2p1gH1BDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.