From: Hector Martin <marcan@marcan.st>
To: Donghyeok Kim <dthex5d@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] irqchip/apple-aic: Fix annotation
Date: Thu, 2 Dec 2021 14:23:36 +0900 [thread overview]
Message-ID: <2c583fc9-e16c-6223-0a4a-f4f7e4954776@marcan.st> (raw)
In-Reply-To: <20211123161655.2943-1-dthex5d@gmail.com>
Hi,
On 24/11/2021 01.16, Donghyeok Kim wrote:
> Annotate aic_init_smp() as __init
>
> Signed-off-by: Donghyeok Kim <dthex5d@gmail.com>
> ---
> drivers/irqchip/irq-apple-aic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
> index 3759dc36cc8f..2543ef65825b 100644
> --- a/drivers/irqchip/irq-apple-aic.c
> +++ b/drivers/irqchip/irq-apple-aic.c
> @@ -707,7 +707,7 @@ static const struct irq_domain_ops aic_ipi_domain_ops = {
> .free = aic_ipi_free,
> };
>
> -static int aic_init_smp(struct aic_irq_chip *irqc, struct device_node *node)
> +static int __init aic_init_smp(struct aic_irq_chip *irqc, struct device_node *node)
> {
> struct irq_domain *ipi_domain;
> int base_ipi;
>
This looks fine, but can you use a more descriptive commit message?
Something like:
==
irqchip/apple-aic: Mark aic_init_smp() as __init
This function is only called from the driver init code.
==
Thanks,
--
Hector Martin (marcan@marcan.st)
Public Key: https://mrcn.st/pub
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-02 5:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 16:16 [PATCH] irqchip/apple-aic: Fix annotation Donghyeok Kim
2021-12-02 5:23 ` Hector Martin [this message]
2021-12-04 16:42 ` [PATCH v2] irqchip/apple-aic: Mark aic_init_smp() as __init Donghyeok Kim
2021-12-07 4:32 ` Hector Martin
2021-12-07 9:36 ` Marc Zyngier
2021-12-07 9:43 ` [irqchip: irq/irqchip-fixes] " irqchip-bot for Donghyeok Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c583fc9-e16c-6223-0a4a-f4f7e4954776@marcan.st \
--to=marcan@marcan.st \
--cc=dthex5d@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.