* [PATCH] irqchip/apple-aic: Fix annotation
@ 2021-11-23 16:16 Donghyeok Kim
2021-12-02 5:23 ` Hector Martin
0 siblings, 1 reply; 6+ messages in thread
From: Donghyeok Kim @ 2021-11-23 16:16 UTC (permalink / raw)
To: marcan; +Cc: linux-arm-kernel, Donghyeok Kim
Annotate aic_init_smp() as __init
Signed-off-by: Donghyeok Kim <dthex5d@gmail.com>
---
drivers/irqchip/irq-apple-aic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
index 3759dc36cc8f..2543ef65825b 100644
--- a/drivers/irqchip/irq-apple-aic.c
+++ b/drivers/irqchip/irq-apple-aic.c
@@ -707,7 +707,7 @@ static const struct irq_domain_ops aic_ipi_domain_ops = {
.free = aic_ipi_free,
};
-static int aic_init_smp(struct aic_irq_chip *irqc, struct device_node *node)
+static int __init aic_init_smp(struct aic_irq_chip *irqc, struct device_node *node)
{
struct irq_domain *ipi_domain;
int base_ipi;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] irqchip/apple-aic: Fix annotation
2021-11-23 16:16 [PATCH] irqchip/apple-aic: Fix annotation Donghyeok Kim
@ 2021-12-02 5:23 ` Hector Martin
2021-12-04 16:42 ` [PATCH v2] irqchip/apple-aic: Mark aic_init_smp() as __init Donghyeok Kim
0 siblings, 1 reply; 6+ messages in thread
From: Hector Martin @ 2021-12-02 5:23 UTC (permalink / raw)
To: Donghyeok Kim; +Cc: linux-arm-kernel
Hi,
On 24/11/2021 01.16, Donghyeok Kim wrote:
> Annotate aic_init_smp() as __init
>
> Signed-off-by: Donghyeok Kim <dthex5d@gmail.com>
> ---
> drivers/irqchip/irq-apple-aic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
> index 3759dc36cc8f..2543ef65825b 100644
> --- a/drivers/irqchip/irq-apple-aic.c
> +++ b/drivers/irqchip/irq-apple-aic.c
> @@ -707,7 +707,7 @@ static const struct irq_domain_ops aic_ipi_domain_ops = {
> .free = aic_ipi_free,
> };
>
> -static int aic_init_smp(struct aic_irq_chip *irqc, struct device_node *node)
> +static int __init aic_init_smp(struct aic_irq_chip *irqc, struct device_node *node)
> {
> struct irq_domain *ipi_domain;
> int base_ipi;
>
This looks fine, but can you use a more descriptive commit message?
Something like:
==
irqchip/apple-aic: Mark aic_init_smp() as __init
This function is only called from the driver init code.
==
Thanks,
--
Hector Martin (marcan@marcan.st)
Public Key: https://mrcn.st/pub
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v2] irqchip/apple-aic: Mark aic_init_smp() as __init
2021-12-02 5:23 ` Hector Martin
@ 2021-12-04 16:42 ` Donghyeok Kim
2021-12-07 4:32 ` Hector Martin
2021-12-07 9:43 ` [irqchip: irq/irqchip-fixes] " irqchip-bot for Donghyeok Kim
0 siblings, 2 replies; 6+ messages in thread
From: Donghyeok Kim @ 2021-12-04 16:42 UTC (permalink / raw)
To: marcan; +Cc: linux-arm-kernel, dthex5d
This function is only called from the driver init code.
Signed-off-by: Donghyeok Kim <dthex5d@gmail.com>
---
drivers/irqchip/irq-apple-aic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
index 3759dc36cc8f..2543ef65825b 100644
--- a/drivers/irqchip/irq-apple-aic.c
+++ b/drivers/irqchip/irq-apple-aic.c
@@ -707,7 +707,7 @@ static const struct irq_domain_ops aic_ipi_domain_ops = {
.free = aic_ipi_free,
};
-static int aic_init_smp(struct aic_irq_chip *irqc, struct device_node *node)
+static int __init aic_init_smp(struct aic_irq_chip *irqc, struct device_node *node)
{
struct irq_domain *ipi_domain;
int base_ipi;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] irqchip/apple-aic: Mark aic_init_smp() as __init
2021-12-04 16:42 ` [PATCH v2] irqchip/apple-aic: Mark aic_init_smp() as __init Donghyeok Kim
@ 2021-12-07 4:32 ` Hector Martin
2021-12-07 9:36 ` Marc Zyngier
2021-12-07 9:43 ` [irqchip: irq/irqchip-fixes] " irqchip-bot for Donghyeok Kim
1 sibling, 1 reply; 6+ messages in thread
From: Hector Martin @ 2021-12-07 4:32 UTC (permalink / raw)
To: Donghyeok Kim, Marc Zyngier; +Cc: linux-arm-kernel
On 05/12/2021 01.42, Donghyeok Kim wrote:
> This function is only called from the driver init code.
>
> Signed-off-by: Donghyeok Kim <dthex5d@gmail.com>
> ---
> drivers/irqchip/irq-apple-aic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
> index 3759dc36cc8f..2543ef65825b 100644
> --- a/drivers/irqchip/irq-apple-aic.c
> +++ b/drivers/irqchip/irq-apple-aic.c
> @@ -707,7 +707,7 @@ static const struct irq_domain_ops aic_ipi_domain_ops = {
> .free = aic_ipi_free,
> };
>
> -static int aic_init_smp(struct aic_irq_chip *irqc, struct device_node *node)
> +static int __init aic_init_smp(struct aic_irq_chip *irqc, struct device_node *node)
> {
> struct irq_domain *ipi_domain;
> int base_ipi;
>
Acked-by: Hector Martin <marcan@marcan.st>
Thanks! Marc, can you take this through the IRQ tree?
--
Hector Martin (marcan@marcan.st)
Public Key: https://mrcn.st/pub
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] irqchip/apple-aic: Mark aic_init_smp() as __init
2021-12-07 4:32 ` Hector Martin
@ 2021-12-07 9:36 ` Marc Zyngier
0 siblings, 0 replies; 6+ messages in thread
From: Marc Zyngier @ 2021-12-07 9:36 UTC (permalink / raw)
To: Hector Martin; +Cc: Donghyeok Kim, linux-arm-kernel
On Tue, 07 Dec 2021 04:32:30 +0000,
Hector Martin <marcan@marcan.st> wrote:
>
> On 05/12/2021 01.42, Donghyeok Kim wrote:
> > This function is only called from the driver init code.
> >
> > Signed-off-by: Donghyeok Kim <dthex5d@gmail.com>
> > ---
> > drivers/irqchip/irq-apple-aic.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
> > index 3759dc36cc8f..2543ef65825b 100644
> > --- a/drivers/irqchip/irq-apple-aic.c
> > +++ b/drivers/irqchip/irq-apple-aic.c
> > @@ -707,7 +707,7 @@ static const struct irq_domain_ops aic_ipi_domain_ops = {
> > .free = aic_ipi_free,
> > };
> > -static int aic_init_smp(struct aic_irq_chip *irqc, struct
> > device_node *node)
> > +static int __init aic_init_smp(struct aic_irq_chip *irqc, struct device_node *node)
> > {
> > struct irq_domain *ipi_domain;
> > int base_ipi;
> >
>
> Acked-by: Hector Martin <marcan@marcan.st>
>
> Thanks! Marc, can you take this through the IRQ tree?
Huh, thanks for spotting that patch. I'll queue that shortly.
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [irqchip: irq/irqchip-fixes] irqchip/apple-aic: Mark aic_init_smp() as __init
2021-12-04 16:42 ` [PATCH v2] irqchip/apple-aic: Mark aic_init_smp() as __init Donghyeok Kim
2021-12-07 4:32 ` Hector Martin
@ 2021-12-07 9:43 ` irqchip-bot for Donghyeok Kim
1 sibling, 0 replies; 6+ messages in thread
From: irqchip-bot for Donghyeok Kim @ 2021-12-07 9:43 UTC (permalink / raw)
To: linux-kernel; +Cc: Donghyeok Kim, Hector Martin, Marc Zyngier, tglx
The following commit has been merged into the irq/irqchip-fixes branch of irqchip:
Commit-ID: 3d9e575f2acef57528ed6950b5f8ba99f5e52f3f
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/3d9e575f2acef57528ed6950b5f8ba99f5e52f3f
Author: Donghyeok Kim <dthex5d@gmail.com>
AuthorDate: Sun, 05 Dec 2021 01:42:28 +09:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Tue, 07 Dec 2021 09:33:11
irqchip/apple-aic: Mark aic_init_smp() as __init
This function is only called from the driver init code.
Signed-off-by: Donghyeok Kim <dthex5d@gmail.com>
Acked-by: Hector Martin <marcan@marcan.st>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20211204164228.5920-1-dthex5d@gmail.com
---
drivers/irqchip/irq-apple-aic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
index 3759dc3..2543ef6 100644
--- a/drivers/irqchip/irq-apple-aic.c
+++ b/drivers/irqchip/irq-apple-aic.c
@@ -707,7 +707,7 @@ static const struct irq_domain_ops aic_ipi_domain_ops = {
.free = aic_ipi_free,
};
-static int aic_init_smp(struct aic_irq_chip *irqc, struct device_node *node)
+static int __init aic_init_smp(struct aic_irq_chip *irqc, struct device_node *node)
{
struct irq_domain *ipi_domain;
int base_ipi;
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-12-07 10:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-23 16:16 [PATCH] irqchip/apple-aic: Fix annotation Donghyeok Kim
2021-12-02 5:23 ` Hector Martin
2021-12-04 16:42 ` [PATCH v2] irqchip/apple-aic: Mark aic_init_smp() as __init Donghyeok Kim
2021-12-07 4:32 ` Hector Martin
2021-12-07 9:36 ` Marc Zyngier
2021-12-07 9:43 ` [irqchip: irq/irqchip-fixes] " irqchip-bot for Donghyeok Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.