From: Frank Rowand <frowand.list@gmail.com> To: Stephen Boyd <sboyd@kernel.org>, Michael Turquette <mturquette@baylibre.com> Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, patches@lists.linux.dev, Brendan Higgins <brendan.higgins@linux.dev>, David Gow <davidgow@google.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Rafael J . Wysocki" <rafael@kernel.org>, Richard Weinberger <richard@nod.at>, Anton Ivanov <anton.ivanov@cambridgegreys.com>, Johannes Berg <johannes@sipsolutions.net>, Vincent Whitchurch <vincent.whitchurch@axis.com>, Rob Herring <robh+dt@kernel.org>, Christian Marangi <ansuelsmth@gmail.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, devicetree@vger.kernel.org, linux-um@lists.infradead.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com Subject: Re: [PATCH 0/8] clk: Add kunit tests for fixed rate and parent data Date: Sat, 4 Mar 2023 09:50:29 -0600 [thread overview] Message-ID: <2ce31cd1-7a0e-18ac-8a5b-ed09d6539241@gmail.com> (raw) In-Reply-To: <20230302013822.1808711-1-sboyd@kernel.org> On 3/1/23 19:38, Stephen Boyd wrote: > This patch series adds unit tests for the clk fixed rate basic type and > the clk registration functions that use struct clk_parent_data. To get > there, we add support for loading a DTB into the UML kernel that's > running the unit tests along with probing platform drivers to bind to > device nodes specified in DT. > > With this series, we're able to exercise some of the code in the common > clk framework that uses devicetree lookups to find parents and the fixed > rate clk code that scans devicetree directly and creates clks. Please > review. I would _really_ like to _not_ have devicetree tests in two locations: DT unittests and kunit tests. For my testing, I already build and boot four times on real hardware: 1) no DT unittests 2) CONFIG_OF_UNITTEST 3) CONFIG_OF_UNITTEST CONFIG_OF_DYNAMIC 4) CONFIG_OF_UNITTEST CONFIG_OF_DYNAMIC CONFIG_OF_OVERLAY I really should also be testing the four configurations on UML, but at the moment I am not. I also check for new compile warnings at various warn levels for all four configurations. If I recall correctly, the kunit framework encourages more (many more?) kunit config options to select which test(s) are build for a test run. Someone please correct this paragraph if I am mis-stating. Adding devicetree tests to kunit adds additional build and boot cycles and additional test output streams to verify. Are there any issues with DT unittests that preclude adding clk tests into the DT unittests? -Frank > > I Cced everyone to all the patches so they get the full context. I'm > hoping I can take the whole pile through the clk tree as they almost all > depend on each other. In the future I imagine it will be easy to add > more test nodes to the clk.dtsi file and not need to go across various > maintainer trees like this series does. > > Stephen Boyd (8): > dt-bindings: Add linux,kunit binding > of: Enable DTB loading on UML for KUnit tests > kunit: Add test managed platform_device/driver APIs > clk: Add test managed clk provider/consumer APIs > dt-bindings: kunit: Add fixed rate clk consumer test > clk: Add KUnit tests for clk fixed rate basic type > dt-bindings: clk: Add KUnit clk_parent_data test > clk: Add KUnit tests for clks registered with struct clk_parent_data > > .../clock/linux,clk-kunit-parent-data.yaml | 47 ++ > .../kunit/linux,clk-kunit-fixed-rate.yaml | 35 ++ > .../bindings/kunit/linux,kunit.yaml | 24 + > arch/um/kernel/dtb.c | 29 +- > drivers/clk/.kunitconfig | 3 + > drivers/clk/Kconfig | 7 + > drivers/clk/Makefile | 6 + > drivers/clk/clk-fixed-rate_test.c | 296 ++++++++++++ > drivers/clk/clk-kunit.c | 204 ++++++++ > drivers/clk/clk-kunit.h | 28 ++ > drivers/clk/clk_test.c | 456 +++++++++++++++++- > drivers/of/Kconfig | 26 + > drivers/of/Makefile | 1 + > drivers/of/kunit/.kunitconfig | 4 + > drivers/of/kunit/Makefile | 4 + > drivers/of/kunit/clk.dtsi | 30 ++ > drivers/of/kunit/kunit.dtsi | 9 + > drivers/of/kunit/kunit.dtso | 4 + > drivers/of/kunit/uml_dtb_test.c | 55 +++ > include/kunit/platform_driver.h | 15 + > lib/kunit/Makefile | 6 + > lib/kunit/platform_driver-test.c | 107 ++++ > lib/kunit/platform_driver.c | 207 ++++++++ > 23 files changed, 1599 insertions(+), 4 deletions(-) > create mode 100644 Documentation/devicetree/bindings/clock/linux,clk-kunit-parent-data.yaml > create mode 100644 Documentation/devicetree/bindings/kunit/linux,clk-kunit-fixed-rate.yaml > create mode 100644 Documentation/devicetree/bindings/kunit/linux,kunit.yaml > create mode 100644 drivers/clk/clk-fixed-rate_test.c > create mode 100644 drivers/clk/clk-kunit.c > create mode 100644 drivers/clk/clk-kunit.h > create mode 100644 drivers/of/kunit/.kunitconfig > create mode 100644 drivers/of/kunit/Makefile > create mode 100644 drivers/of/kunit/clk.dtsi > create mode 100644 drivers/of/kunit/kunit.dtsi > create mode 100644 drivers/of/kunit/kunit.dtso > create mode 100644 drivers/of/kunit/uml_dtb_test.c > create mode 100644 include/kunit/platform_driver.h > create mode 100644 lib/kunit/platform_driver-test.c > create mode 100644 lib/kunit/platform_driver.c > > > base-commit: c9c3395d5e3dcc6daee66c6908354d47bf98cb0c
WARNING: multiple messages have this Message-ID (diff)
From: Frank Rowand <frowand.list@gmail.com> To: Stephen Boyd <sboyd@kernel.org>, Michael Turquette <mturquette@baylibre.com> Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, patches@lists.linux.dev, Brendan Higgins <brendan.higgins@linux.dev>, David Gow <davidgow@google.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Rafael J . Wysocki" <rafael@kernel.org>, Richard Weinberger <richard@nod.at>, Anton Ivanov <anton.ivanov@cambridgegreys.com>, Johannes Berg <johannes@sipsolutions.net>, Vincent Whitchurch <vincent.whitchurch@axis.com>, Rob Herring <robh+dt@kernel.org>, Christian Marangi <ansuelsmth@gmail.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, devicetree@vger.kernel.org, linux-um@lists.infradead.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com Subject: Re: [PATCH 0/8] clk: Add kunit tests for fixed rate and parent data Date: Sat, 4 Mar 2023 09:50:29 -0600 [thread overview] Message-ID: <2ce31cd1-7a0e-18ac-8a5b-ed09d6539241@gmail.com> (raw) In-Reply-To: <20230302013822.1808711-1-sboyd@kernel.org> On 3/1/23 19:38, Stephen Boyd wrote: > This patch series adds unit tests for the clk fixed rate basic type and > the clk registration functions that use struct clk_parent_data. To get > there, we add support for loading a DTB into the UML kernel that's > running the unit tests along with probing platform drivers to bind to > device nodes specified in DT. > > With this series, we're able to exercise some of the code in the common > clk framework that uses devicetree lookups to find parents and the fixed > rate clk code that scans devicetree directly and creates clks. Please > review. I would _really_ like to _not_ have devicetree tests in two locations: DT unittests and kunit tests. For my testing, I already build and boot four times on real hardware: 1) no DT unittests 2) CONFIG_OF_UNITTEST 3) CONFIG_OF_UNITTEST CONFIG_OF_DYNAMIC 4) CONFIG_OF_UNITTEST CONFIG_OF_DYNAMIC CONFIG_OF_OVERLAY I really should also be testing the four configurations on UML, but at the moment I am not. I also check for new compile warnings at various warn levels for all four configurations. If I recall correctly, the kunit framework encourages more (many more?) kunit config options to select which test(s) are build for a test run. Someone please correct this paragraph if I am mis-stating. Adding devicetree tests to kunit adds additional build and boot cycles and additional test output streams to verify. Are there any issues with DT unittests that preclude adding clk tests into the DT unittests? -Frank > > I Cced everyone to all the patches so they get the full context. I'm > hoping I can take the whole pile through the clk tree as they almost all > depend on each other. In the future I imagine it will be easy to add > more test nodes to the clk.dtsi file and not need to go across various > maintainer trees like this series does. > > Stephen Boyd (8): > dt-bindings: Add linux,kunit binding > of: Enable DTB loading on UML for KUnit tests > kunit: Add test managed platform_device/driver APIs > clk: Add test managed clk provider/consumer APIs > dt-bindings: kunit: Add fixed rate clk consumer test > clk: Add KUnit tests for clk fixed rate basic type > dt-bindings: clk: Add KUnit clk_parent_data test > clk: Add KUnit tests for clks registered with struct clk_parent_data > > .../clock/linux,clk-kunit-parent-data.yaml | 47 ++ > .../kunit/linux,clk-kunit-fixed-rate.yaml | 35 ++ > .../bindings/kunit/linux,kunit.yaml | 24 + > arch/um/kernel/dtb.c | 29 +- > drivers/clk/.kunitconfig | 3 + > drivers/clk/Kconfig | 7 + > drivers/clk/Makefile | 6 + > drivers/clk/clk-fixed-rate_test.c | 296 ++++++++++++ > drivers/clk/clk-kunit.c | 204 ++++++++ > drivers/clk/clk-kunit.h | 28 ++ > drivers/clk/clk_test.c | 456 +++++++++++++++++- > drivers/of/Kconfig | 26 + > drivers/of/Makefile | 1 + > drivers/of/kunit/.kunitconfig | 4 + > drivers/of/kunit/Makefile | 4 + > drivers/of/kunit/clk.dtsi | 30 ++ > drivers/of/kunit/kunit.dtsi | 9 + > drivers/of/kunit/kunit.dtso | 4 + > drivers/of/kunit/uml_dtb_test.c | 55 +++ > include/kunit/platform_driver.h | 15 + > lib/kunit/Makefile | 6 + > lib/kunit/platform_driver-test.c | 107 ++++ > lib/kunit/platform_driver.c | 207 ++++++++ > 23 files changed, 1599 insertions(+), 4 deletions(-) > create mode 100644 Documentation/devicetree/bindings/clock/linux,clk-kunit-parent-data.yaml > create mode 100644 Documentation/devicetree/bindings/kunit/linux,clk-kunit-fixed-rate.yaml > create mode 100644 Documentation/devicetree/bindings/kunit/linux,kunit.yaml > create mode 100644 drivers/clk/clk-fixed-rate_test.c > create mode 100644 drivers/clk/clk-kunit.c > create mode 100644 drivers/clk/clk-kunit.h > create mode 100644 drivers/of/kunit/.kunitconfig > create mode 100644 drivers/of/kunit/Makefile > create mode 100644 drivers/of/kunit/clk.dtsi > create mode 100644 drivers/of/kunit/kunit.dtsi > create mode 100644 drivers/of/kunit/kunit.dtso > create mode 100644 drivers/of/kunit/uml_dtb_test.c > create mode 100644 include/kunit/platform_driver.h > create mode 100644 lib/kunit/platform_driver-test.c > create mode 100644 lib/kunit/platform_driver.c > > > base-commit: c9c3395d5e3dcc6daee66c6908354d47bf98cb0c _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2023-03-04 15:50 UTC|newest] Thread overview: 120+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-02 1:38 [PATCH 0/8] clk: Add kunit tests for fixed rate and parent data Stephen Boyd 2023-03-02 1:38 ` Stephen Boyd 2023-03-02 1:38 ` [PATCH 1/8] dt-bindings: Add linux,kunit binding Stephen Boyd 2023-03-02 1:38 ` Stephen Boyd 2023-03-03 7:14 ` David Gow 2023-03-03 7:14 ` David Gow 2023-03-03 7:49 ` Geert Uytterhoeven 2023-03-03 7:49 ` Geert Uytterhoeven 2023-03-09 23:12 ` Stephen Boyd 2023-03-09 23:12 ` Stephen Boyd 2023-03-10 7:55 ` David Gow 2023-03-10 7:55 ` David Gow 2023-03-02 1:38 ` [PATCH 2/8] of: Enable DTB loading on UML for KUnit tests Stephen Boyd 2023-03-02 1:38 ` Stephen Boyd 2023-03-03 7:15 ` David Gow 2023-03-03 7:15 ` David Gow 2023-03-09 23:19 ` Stephen Boyd 2023-03-09 23:19 ` Stephen Boyd 2023-03-10 8:09 ` David Gow 2023-03-10 8:09 ` David Gow 2023-03-10 23:34 ` Stephen Boyd 2023-03-10 23:34 ` Stephen Boyd 2023-03-11 6:42 ` David Gow 2023-03-11 6:42 ` David Gow 2023-03-13 16:02 ` Frank Rowand 2023-03-13 16:02 ` Frank Rowand 2023-03-14 4:28 ` Frank Rowand 2023-03-14 4:28 ` Frank Rowand 2023-03-15 7:04 ` David Gow 2023-03-15 7:04 ` David Gow 2023-03-15 21:35 ` Frank Rowand 2023-03-15 21:35 ` Frank Rowand 2023-03-16 0:45 ` Frank Rowand 2023-03-16 0:45 ` Frank Rowand 2023-03-16 4:15 ` David Gow 2023-03-16 4:15 ` David Gow 2023-03-21 20:56 ` Stephen Boyd 2023-03-21 20:56 ` Stephen Boyd 2023-03-08 19:46 ` Rob Herring 2023-03-08 19:46 ` Rob Herring 2023-03-02 1:38 ` [PATCH 3/8] kunit: Add test managed platform_device/driver APIs Stephen Boyd 2023-03-02 1:38 ` Stephen Boyd 2023-03-03 7:15 ` David Gow 2023-03-03 7:15 ` David Gow 2023-03-03 14:35 ` Maxime Ripard 2023-03-03 14:35 ` Maxime Ripard 2023-03-09 23:31 ` Stephen Boyd 2023-03-09 23:31 ` Stephen Boyd 2023-03-15 8:27 ` Maxime Ripard 2023-03-15 8:27 ` Maxime Ripard 2023-03-09 23:25 ` Stephen Boyd 2023-03-09 23:25 ` Stephen Boyd 2023-03-10 8:19 ` David Gow 2023-03-10 8:19 ` David Gow 2023-03-02 1:38 ` [PATCH 4/8] clk: Add test managed clk provider/consumer APIs Stephen Boyd 2023-03-02 1:38 ` Stephen Boyd 2023-03-03 7:15 ` David Gow 2023-03-03 7:15 ` David Gow 2023-03-10 23:21 ` Stephen Boyd 2023-03-10 23:21 ` Stephen Boyd 2023-03-11 6:32 ` David Gow 2023-03-11 6:32 ` David Gow 2023-03-21 14:32 ` Maxime Ripard 2023-03-21 14:32 ` Maxime Ripard 2023-03-02 1:38 ` [PATCH 5/8] dt-bindings: kunit: Add fixed rate clk consumer test Stephen Boyd 2023-03-02 1:38 ` Stephen Boyd 2023-03-02 1:38 ` [PATCH 6/8] clk: Add KUnit tests for clk fixed rate basic type Stephen Boyd 2023-03-02 1:38 ` Stephen Boyd 2023-03-02 1:38 ` [PATCH 7/8] dt-bindings: clk: Add KUnit clk_parent_data test Stephen Boyd 2023-03-02 1:38 ` Stephen Boyd 2023-03-02 1:38 ` [PATCH 8/8] clk: Add KUnit tests for clks registered with struct clk_parent_data Stephen Boyd 2023-03-02 1:38 ` Stephen Boyd 2023-03-02 8:13 ` [PATCH 0/8] clk: Add kunit tests for fixed rate and parent data David Gow 2023-03-02 8:13 ` David Gow 2023-03-02 17:32 ` Rob Herring 2023-03-02 17:32 ` Rob Herring 2023-03-02 19:27 ` Stephen Boyd 2023-03-02 19:27 ` Stephen Boyd 2023-03-02 19:47 ` Geert Uytterhoeven 2023-03-02 19:47 ` Geert Uytterhoeven 2023-03-05 3:32 ` Frank Rowand 2023-03-05 3:32 ` Frank Rowand 2023-03-05 9:26 ` Geert Uytterhoeven 2023-03-05 9:26 ` Geert Uytterhoeven 2023-03-06 5:32 ` Frank Rowand 2023-03-06 5:32 ` Frank Rowand 2023-03-04 15:04 ` Frank Rowand 2023-03-04 15:04 ` Frank Rowand 2023-03-07 21:53 ` Stephen Boyd 2023-03-07 21:53 ` Stephen Boyd 2023-03-04 14:48 ` Frank Rowand 2023-03-04 14:48 ` Frank Rowand 2023-03-02 17:13 ` Rob Herring 2023-03-02 17:13 ` Rob Herring 2023-03-02 19:44 ` Stephen Boyd 2023-03-02 19:44 ` Stephen Boyd 2023-03-02 20:18 ` Rob Herring 2023-03-02 20:18 ` Rob Herring 2023-03-02 23:57 ` Stephen Boyd 2023-03-02 23:57 ` Stephen Boyd 2023-03-04 15:39 ` Frank Rowand 2023-03-04 15:39 ` Frank Rowand 2023-03-06 12:53 ` Rob Herring 2023-03-06 12:53 ` Rob Herring 2023-03-06 15:03 ` Frank Rowand 2023-03-06 15:03 ` Frank Rowand 2023-03-04 15:37 ` Frank Rowand 2023-03-04 15:37 ` Frank Rowand 2023-03-04 15:33 ` Frank Rowand 2023-03-04 15:33 ` Frank Rowand 2023-03-03 14:38 ` Maxime Ripard 2023-03-03 14:38 ` Maxime Ripard 2023-03-07 22:37 ` Stephen Boyd 2023-03-07 22:37 ` Stephen Boyd 2023-03-04 15:50 ` Frank Rowand [this message] 2023-03-04 15:50 ` Frank Rowand 2023-03-10 7:48 ` David Gow 2023-03-10 7:48 ` David Gow 2023-03-13 15:30 ` Frank Rowand 2023-03-13 15:30 ` Frank Rowand
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2ce31cd1-7a0e-18ac-8a5b-ed09d6539241@gmail.com \ --to=frowand.list@gmail.com \ --cc=ansuelsmth@gmail.com \ --cc=anton.ivanov@cambridgegreys.com \ --cc=brendan.higgins@linux.dev \ --cc=davidgow@google.com \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=johannes@sipsolutions.net \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=kunit-dev@googlegroups.com \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=linux-um@lists.infradead.org \ --cc=mturquette@baylibre.com \ --cc=patches@lists.linux.dev \ --cc=rafael@kernel.org \ --cc=richard@nod.at \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ --cc=vincent.whitchurch@axis.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.