All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: matthias.bgg@kernel.org, Qu Wenruo <wqu@suse.com>,
	Marek Behun <marek.behun@nic.cz>
Cc: u-boot@lists.denx.de, linux-btrfs@vger.kernel.org,
	Matthias Brugger <mbrugger@suse.com>
Subject: Re: [PATCH] fs: btrfs: Select SHA256 in Kconfig
Date: Wed, 27 Jan 2021 17:46:31 +0800	[thread overview]
Message-ID: <2e1865ff-af6e-feec-a224-2364dbb80a0c@gmx.com> (raw)
In-Reply-To: <20210127094231.11740-1-matthias.bgg@kernel.org>



On 2021/1/27 下午5:42, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
> Since commit 565a4147d17a ("fs: btrfs: Add more checksum algorithms")
> btrfs uses the sha256 checksum algorithm. But Kconfig lacks to select
> it. This leads to compilation errors:
> fs/built-in.o: In function `hash_sha256':
> fs/btrfs/crypto/hash.c:25: undefined reference to `sha256_starts'
> fs/btrfs/crypto/hash.c:26: undefined reference to `sha256_update'
> fs/btrfs/crypto/hash.c:27: undefined reference to `sha256_finish'
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>

Oh, forgot to select sha256.

Thanks for the fix.

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu
>
> ---
>
>   fs/btrfs/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig
> index f302b1fbef..2a32f42ad1 100644
> --- a/fs/btrfs/Kconfig
> +++ b/fs/btrfs/Kconfig
> @@ -4,6 +4,7 @@ config FS_BTRFS
>   	select LZO
>   	select ZSTD
>   	select RBTREE
> +	select SHA256
>   	help
>   	  This provides a single-device read-only BTRFS support. BTRFS is a
>   	  next-generation Linux file system based on the copy-on-write
>

WARNING: multiple messages have this Message-ID (diff)
From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: u-boot@lists.denx.de
Subject: [PATCH] fs: btrfs: Select SHA256 in Kconfig
Date: Wed, 27 Jan 2021 17:46:31 +0800	[thread overview]
Message-ID: <2e1865ff-af6e-feec-a224-2364dbb80a0c@gmx.com> (raw)
In-Reply-To: <20210127094231.11740-1-matthias.bgg@kernel.org>



On 2021/1/27 ??5:42, matthias.bgg at kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
> Since commit 565a4147d17a ("fs: btrfs: Add more checksum algorithms")
> btrfs uses the sha256 checksum algorithm. But Kconfig lacks to select
> it. This leads to compilation errors:
> fs/built-in.o: In function `hash_sha256':
> fs/btrfs/crypto/hash.c:25: undefined reference to `sha256_starts'
> fs/btrfs/crypto/hash.c:26: undefined reference to `sha256_update'
> fs/btrfs/crypto/hash.c:27: undefined reference to `sha256_finish'
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>

Oh, forgot to select sha256.

Thanks for the fix.

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu
>
> ---
>
>   fs/btrfs/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig
> index f302b1fbef..2a32f42ad1 100644
> --- a/fs/btrfs/Kconfig
> +++ b/fs/btrfs/Kconfig
> @@ -4,6 +4,7 @@ config FS_BTRFS
>   	select LZO
>   	select ZSTD
>   	select RBTREE
> +	select SHA256
>   	help
>   	  This provides a single-device read-only BTRFS support. BTRFS is a
>   	  next-generation Linux file system based on the copy-on-write
>

  reply	other threads:[~2021-01-27  9:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27  9:42 [PATCH] fs: btrfs: Select SHA256 in Kconfig matthias.bgg
2021-01-27  9:42 ` matthias.bgg at kernel.org
2021-01-27  9:46 ` Qu Wenruo [this message]
2021-01-27  9:46   ` Qu Wenruo
2021-01-27 12:01 ` David Sterba
2021-01-27 12:01   ` David Sterba
2021-01-27 12:14   ` Qu Wenruo
2021-01-27 12:14     ` Qu Wenruo
2021-01-27 13:47     ` David Sterba
2021-01-27 13:47       ` David Sterba
2021-01-27 13:57       ` Marek Behun
2021-01-27 13:57         ` Marek Behun
2021-01-30 19:21 ` Tom Rini
2021-01-30 19:21   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e1865ff-af6e-feec-a224-2364dbb80a0c@gmx.com \
    --to=quwenruo.btrfs@gmx.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=marek.behun@nic.cz \
    --cc=matthias.bgg@kernel.org \
    --cc=mbrugger@suse.com \
    --cc=u-boot@lists.denx.de \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.