* [PATCH] fs: btrfs: Select SHA256 in Kconfig
@ 2021-01-27 9:42 ` matthias.bgg at kernel.org
0 siblings, 0 replies; 14+ messages in thread
From: matthias.bgg at kernel.org @ 2021-01-27 9:42 UTC (permalink / raw)
To: u-boot
From: Matthias Brugger <mbrugger@suse.com>
Since commit 565a4147d17a ("fs: btrfs: Add more checksum algorithms")
btrfs uses the sha256 checksum algorithm. But Kconfig lacks to select
it. This leads to compilation errors:
fs/built-in.o: In function `hash_sha256':
fs/btrfs/crypto/hash.c:25: undefined reference to `sha256_starts'
fs/btrfs/crypto/hash.c:26: undefined reference to `sha256_update'
fs/btrfs/crypto/hash.c:27: undefined reference to `sha256_finish'
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
---
fs/btrfs/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig
index f302b1fbef..2a32f42ad1 100644
--- a/fs/btrfs/Kconfig
+++ b/fs/btrfs/Kconfig
@@ -4,6 +4,7 @@ config FS_BTRFS
select LZO
select ZSTD
select RBTREE
+ select SHA256
help
This provides a single-device read-only BTRFS support. BTRFS is a
next-generation Linux file system based on the copy-on-write
--
2.30.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH] fs: btrfs: Select SHA256 in Kconfig
2021-01-27 9:42 ` matthias.bgg at kernel.org
@ 2021-01-27 9:46 ` Qu Wenruo
-1 siblings, 0 replies; 14+ messages in thread
From: Qu Wenruo @ 2021-01-27 9:46 UTC (permalink / raw)
To: matthias.bgg, Qu Wenruo, Marek Behun
Cc: u-boot, linux-btrfs, Matthias Brugger
On 2021/1/27 下午5:42, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
> Since commit 565a4147d17a ("fs: btrfs: Add more checksum algorithms")
> btrfs uses the sha256 checksum algorithm. But Kconfig lacks to select
> it. This leads to compilation errors:
> fs/built-in.o: In function `hash_sha256':
> fs/btrfs/crypto/hash.c:25: undefined reference to `sha256_starts'
> fs/btrfs/crypto/hash.c:26: undefined reference to `sha256_update'
> fs/btrfs/crypto/hash.c:27: undefined reference to `sha256_finish'
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
Oh, forgot to select sha256.
Thanks for the fix.
Reviewed-by: Qu Wenruo <wqu@suse.com>
Thanks,
Qu
>
> ---
>
> fs/btrfs/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig
> index f302b1fbef..2a32f42ad1 100644
> --- a/fs/btrfs/Kconfig
> +++ b/fs/btrfs/Kconfig
> @@ -4,6 +4,7 @@ config FS_BTRFS
> select LZO
> select ZSTD
> select RBTREE
> + select SHA256
> help
> This provides a single-device read-only BTRFS support. BTRFS is a
> next-generation Linux file system based on the copy-on-write
>
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH] fs: btrfs: Select SHA256 in Kconfig
@ 2021-01-27 9:46 ` Qu Wenruo
0 siblings, 0 replies; 14+ messages in thread
From: Qu Wenruo @ 2021-01-27 9:46 UTC (permalink / raw)
To: u-boot
On 2021/1/27 ??5:42, matthias.bgg at kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
> Since commit 565a4147d17a ("fs: btrfs: Add more checksum algorithms")
> btrfs uses the sha256 checksum algorithm. But Kconfig lacks to select
> it. This leads to compilation errors:
> fs/built-in.o: In function `hash_sha256':
> fs/btrfs/crypto/hash.c:25: undefined reference to `sha256_starts'
> fs/btrfs/crypto/hash.c:26: undefined reference to `sha256_update'
> fs/btrfs/crypto/hash.c:27: undefined reference to `sha256_finish'
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
Oh, forgot to select sha256.
Thanks for the fix.
Reviewed-by: Qu Wenruo <wqu@suse.com>
Thanks,
Qu
>
> ---
>
> fs/btrfs/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig
> index f302b1fbef..2a32f42ad1 100644
> --- a/fs/btrfs/Kconfig
> +++ b/fs/btrfs/Kconfig
> @@ -4,6 +4,7 @@ config FS_BTRFS
> select LZO
> select ZSTD
> select RBTREE
> + select SHA256
> help
> This provides a single-device read-only BTRFS support. BTRFS is a
> next-generation Linux file system based on the copy-on-write
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] fs: btrfs: Select SHA256 in Kconfig
2021-01-27 9:42 ` matthias.bgg at kernel.org
@ 2021-01-27 12:01 ` David Sterba
-1 siblings, 0 replies; 14+ messages in thread
From: David Sterba @ 2021-01-27 12:01 UTC (permalink / raw)
To: matthias.bgg
Cc: Qu Wenruo, Marek Behun, u-boot, linux-btrfs, Matthias Brugger
On Wed, Jan 27, 2021 at 10:42:30AM +0100, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
> Since commit 565a4147d17a ("fs: btrfs: Add more checksum algorithms")
> btrfs uses the sha256 checksum algorithm. But Kconfig lacks to select
> it. This leads to compilation errors:
> fs/built-in.o: In function `hash_sha256':
> fs/btrfs/crypto/hash.c:25: undefined reference to `sha256_starts'
> fs/btrfs/crypto/hash.c:26: undefined reference to `sha256_update'
> fs/btrfs/crypto/hash.c:27: undefined reference to `sha256_finish'
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
So this is a fix for u-boot, got me confused and not for the first time
as there's Kconfig and the same fs/btrfs/ directory structure.
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH] fs: btrfs: Select SHA256 in Kconfig
@ 2021-01-27 12:01 ` David Sterba
0 siblings, 0 replies; 14+ messages in thread
From: David Sterba @ 2021-01-27 12:01 UTC (permalink / raw)
To: u-boot
On Wed, Jan 27, 2021 at 10:42:30AM +0100, matthias.bgg at kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
> Since commit 565a4147d17a ("fs: btrfs: Add more checksum algorithms")
> btrfs uses the sha256 checksum algorithm. But Kconfig lacks to select
> it. This leads to compilation errors:
> fs/built-in.o: In function `hash_sha256':
> fs/btrfs/crypto/hash.c:25: undefined reference to `sha256_starts'
> fs/btrfs/crypto/hash.c:26: undefined reference to `sha256_update'
> fs/btrfs/crypto/hash.c:27: undefined reference to `sha256_finish'
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
So this is a fix for u-boot, got me confused and not for the first time
as there's Kconfig and the same fs/btrfs/ directory structure.
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] fs: btrfs: Select SHA256 in Kconfig
2021-01-27 12:01 ` David Sterba
@ 2021-01-27 12:14 ` Qu Wenruo
-1 siblings, 0 replies; 14+ messages in thread
From: Qu Wenruo @ 2021-01-27 12:14 UTC (permalink / raw)
To: dsterba, matthias.bgg, Marek Behun, u-boot, linux-btrfs,
Matthias Brugger
On 2021/1/27 下午8:01, David Sterba wrote:
> On Wed, Jan 27, 2021 at 10:42:30AM +0100, matthias.bgg@kernel.org wrote:
>> From: Matthias Brugger <mbrugger@suse.com>
>>
>> Since commit 565a4147d17a ("fs: btrfs: Add more checksum algorithms")
>> btrfs uses the sha256 checksum algorithm. But Kconfig lacks to select
>> it. This leads to compilation errors:
>> fs/built-in.o: In function `hash_sha256':
>> fs/btrfs/crypto/hash.c:25: undefined reference to `sha256_starts'
>> fs/btrfs/crypto/hash.c:26: undefined reference to `sha256_update'
>> fs/btrfs/crypto/hash.c:27: undefined reference to `sha256_finish'
>>
>> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
>
> So this is a fix for u-boot, got me confused and not for the first time
> as there's Kconfig and the same fs/btrfs/ directory structure.
>
Well, sometimes too unified file structure/code base can also be a problem.
Considering I'm also going to continue cross-porting more code to
U-boot, any recommendation on this?
Using different prefix?
Thanks,
Qu
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH] fs: btrfs: Select SHA256 in Kconfig
@ 2021-01-27 12:14 ` Qu Wenruo
0 siblings, 0 replies; 14+ messages in thread
From: Qu Wenruo @ 2021-01-27 12:14 UTC (permalink / raw)
To: u-boot
On 2021/1/27 ??8:01, David Sterba wrote:
> On Wed, Jan 27, 2021 at 10:42:30AM +0100, matthias.bgg at kernel.org wrote:
>> From: Matthias Brugger <mbrugger@suse.com>
>>
>> Since commit 565a4147d17a ("fs: btrfs: Add more checksum algorithms")
>> btrfs uses the sha256 checksum algorithm. But Kconfig lacks to select
>> it. This leads to compilation errors:
>> fs/built-in.o: In function `hash_sha256':
>> fs/btrfs/crypto/hash.c:25: undefined reference to `sha256_starts'
>> fs/btrfs/crypto/hash.c:26: undefined reference to `sha256_update'
>> fs/btrfs/crypto/hash.c:27: undefined reference to `sha256_finish'
>>
>> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
>
> So this is a fix for u-boot, got me confused and not for the first time
> as there's Kconfig and the same fs/btrfs/ directory structure.
>
Well, sometimes too unified file structure/code base can also be a problem.
Considering I'm also going to continue cross-porting more code to
U-boot, any recommendation on this?
Using different prefix?
Thanks,
Qu
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] fs: btrfs: Select SHA256 in Kconfig
2021-01-27 12:14 ` Qu Wenruo
@ 2021-01-27 13:47 ` David Sterba
-1 siblings, 0 replies; 14+ messages in thread
From: David Sterba @ 2021-01-27 13:47 UTC (permalink / raw)
To: Qu Wenruo
Cc: dsterba, matthias.bgg, Marek Behun, u-boot, linux-btrfs,
Matthias Brugger
On Wed, Jan 27, 2021 at 08:14:31PM +0800, Qu Wenruo wrote:
>
>
> On 2021/1/27 下午8:01, David Sterba wrote:
> > On Wed, Jan 27, 2021 at 10:42:30AM +0100, matthias.bgg@kernel.org wrote:
> >> From: Matthias Brugger <mbrugger@suse.com>
> >>
> >> Since commit 565a4147d17a ("fs: btrfs: Add more checksum algorithms")
> >> btrfs uses the sha256 checksum algorithm. But Kconfig lacks to select
> >> it. This leads to compilation errors:
> >> fs/built-in.o: In function `hash_sha256':
> >> fs/btrfs/crypto/hash.c:25: undefined reference to `sha256_starts'
> >> fs/btrfs/crypto/hash.c:26: undefined reference to `sha256_update'
> >> fs/btrfs/crypto/hash.c:27: undefined reference to `sha256_finish'
> >>
> >> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> >
> > So this is a fix for u-boot, got me confused and not for the first time
> > as there's Kconfig and the same fs/btrfs/ directory structure.
> >
> Well, sometimes too unified file structure/code base can also be a problem.
>
> Considering I'm also going to continue cross-porting more code to
> U-boot, any recommendation on this?
> Using different prefix?
If it's a series then please mention u-boot in the cover letter, no need
to change the patches, I'll go check CC if I'm too confused about the
patch.
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH] fs: btrfs: Select SHA256 in Kconfig
@ 2021-01-27 13:47 ` David Sterba
0 siblings, 0 replies; 14+ messages in thread
From: David Sterba @ 2021-01-27 13:47 UTC (permalink / raw)
To: u-boot
On Wed, Jan 27, 2021 at 08:14:31PM +0800, Qu Wenruo wrote:
>
>
> On 2021/1/27 ??8:01, David Sterba wrote:
> > On Wed, Jan 27, 2021 at 10:42:30AM +0100, matthias.bgg at kernel.org wrote:
> >> From: Matthias Brugger <mbrugger@suse.com>
> >>
> >> Since commit 565a4147d17a ("fs: btrfs: Add more checksum algorithms")
> >> btrfs uses the sha256 checksum algorithm. But Kconfig lacks to select
> >> it. This leads to compilation errors:
> >> fs/built-in.o: In function `hash_sha256':
> >> fs/btrfs/crypto/hash.c:25: undefined reference to `sha256_starts'
> >> fs/btrfs/crypto/hash.c:26: undefined reference to `sha256_update'
> >> fs/btrfs/crypto/hash.c:27: undefined reference to `sha256_finish'
> >>
> >> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> >
> > So this is a fix for u-boot, got me confused and not for the first time
> > as there's Kconfig and the same fs/btrfs/ directory structure.
> >
> Well, sometimes too unified file structure/code base can also be a problem.
>
> Considering I'm also going to continue cross-porting more code to
> U-boot, any recommendation on this?
> Using different prefix?
If it's a series then please mention u-boot in the cover letter, no need
to change the patches, I'll go check CC if I'm too confused about the
patch.
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] fs: btrfs: Select SHA256 in Kconfig
2021-01-27 13:47 ` David Sterba
@ 2021-01-27 13:57 ` Marek Behun
-1 siblings, 0 replies; 14+ messages in thread
From: Marek Behun @ 2021-01-27 13:57 UTC (permalink / raw)
To: David Sterba
Cc: Qu Wenruo, matthias.bgg, u-boot, linux-btrfs, Matthias Brugger
On Wed, 27 Jan 2021 14:47:58 +0100
David Sterba <dsterba@suse.cz> wrote:
> If it's a series then please mention u-boot in the cover letter, no need
> to change the patches, I'll go check CC if I'm too confused about the
> patch.
I would suggest using subject prefix [PATCH u-boot]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] fs: btrfs: Select SHA256 in Kconfig
2021-01-27 9:42 ` matthias.bgg at kernel.org
@ 2021-01-30 19:21 ` Tom Rini
-1 siblings, 0 replies; 14+ messages in thread
From: Tom Rini @ 2021-01-30 19:21 UTC (permalink / raw)
To: matthias.bgg
Cc: Qu Wenruo, Marek Behun, u-boot, linux-btrfs, Matthias Brugger
[-- Attachment #1: Type: text/plain, Size: 714 bytes --]
On Wed, Jan 27, 2021 at 10:42:30AM +0100, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
> Since commit 565a4147d17a ("fs: btrfs: Add more checksum algorithms")
> btrfs uses the sha256 checksum algorithm. But Kconfig lacks to select
> it. This leads to compilation errors:
> fs/built-in.o: In function `hash_sha256':
> fs/btrfs/crypto/hash.c:25: undefined reference to `sha256_starts'
> fs/btrfs/crypto/hash.c:26: undefined reference to `sha256_update'
> fs/btrfs/crypto/hash.c:27: undefined reference to `sha256_finish'
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> Reviewed-by: Qu Wenruo <wqu@suse.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH] fs: btrfs: Select SHA256 in Kconfig
@ 2021-01-30 19:21 ` Tom Rini
0 siblings, 0 replies; 14+ messages in thread
From: Tom Rini @ 2021-01-30 19:21 UTC (permalink / raw)
To: u-boot
On Wed, Jan 27, 2021 at 10:42:30AM +0100, matthias.bgg at kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
> Since commit 565a4147d17a ("fs: btrfs: Add more checksum algorithms")
> btrfs uses the sha256 checksum algorithm. But Kconfig lacks to select
> it. This leads to compilation errors:
> fs/built-in.o: In function `hash_sha256':
> fs/btrfs/crypto/hash.c:25: undefined reference to `sha256_starts'
> fs/btrfs/crypto/hash.c:26: undefined reference to `sha256_update'
> fs/btrfs/crypto/hash.c:27: undefined reference to `sha256_finish'
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> Reviewed-by: Qu Wenruo <wqu@suse.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210130/c92ffe45/attachment.sig>
^ permalink raw reply [flat|nested] 14+ messages in thread