From: "elaine.zhang" <zhangqing@rock-chips.com> To: Johan Jonker <jbx6244@gmail.com>, heiko@sntech.de Cc: mturquette@baylibre.com, sboyd@kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: rockchip: mark pclk_uart2 as critical on rk3328 Date: Thu, 9 Jul 2020 09:32:05 +0800 [thread overview] Message-ID: <2f58b9df-9bcd-5639-65cc-306a6d36b310@rock-chips.com> (raw) In-Reply-To: <20200708144528.20465-1-jbx6244@gmail.com> 在 2020/7/8 下午10:45, Johan Jonker 写道: > The rk3328 uart2 port is used as boot console and to debug. > During the boot pclk_uart2 is disabled by a clk_disable_unused > initcall. Fix the uart2 function by marking pclk_uart2 > as critical on rk3328. Also add sclk_uart2 as that is needed > for the same DT node. > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > --- > drivers/clk/rockchip/clk-rk3328.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/clk/rockchip/clk-rk3328.c b/drivers/clk/rockchip/clk-rk3328.c > index c186a1985..cb7749cb7 100644 > --- a/drivers/clk/rockchip/clk-rk3328.c > +++ b/drivers/clk/rockchip/clk-rk3328.c > @@ -875,6 +875,8 @@ static const char *const rk3328_critical_clocks[] __initconst = { > "aclk_gmac_niu", > "pclk_gmac_niu", > "pclk_phy_niu", > + "pclk_uart2", > + "sclk_uart2", > }; > Not need to mark the uart2 as critical clocks, the uart clk will enabled by uart driver probe(dw8250_probe()). For your question, Please check the uart2 dts node "status = okay". Or You can send me the complete log, I check the status of uart2. > static void __init rk3328_clk_init(struct device_node *np)
WARNING: multiple messages have this Message-ID (diff)
From: "elaine.zhang" <zhangqing@rock-chips.com> To: Johan Jonker <jbx6244@gmail.com>, heiko@sntech.de Cc: sboyd@kernel.org, mturquette@baylibre.com, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] clk: rockchip: mark pclk_uart2 as critical on rk3328 Date: Thu, 9 Jul 2020 09:32:05 +0800 [thread overview] Message-ID: <2f58b9df-9bcd-5639-65cc-306a6d36b310@rock-chips.com> (raw) In-Reply-To: <20200708144528.20465-1-jbx6244@gmail.com> 在 2020/7/8 下午10:45, Johan Jonker 写道: > The rk3328 uart2 port is used as boot console and to debug. > During the boot pclk_uart2 is disabled by a clk_disable_unused > initcall. Fix the uart2 function by marking pclk_uart2 > as critical on rk3328. Also add sclk_uart2 as that is needed > for the same DT node. > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > --- > drivers/clk/rockchip/clk-rk3328.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/clk/rockchip/clk-rk3328.c b/drivers/clk/rockchip/clk-rk3328.c > index c186a1985..cb7749cb7 100644 > --- a/drivers/clk/rockchip/clk-rk3328.c > +++ b/drivers/clk/rockchip/clk-rk3328.c > @@ -875,6 +875,8 @@ static const char *const rk3328_critical_clocks[] __initconst = { > "aclk_gmac_niu", > "pclk_gmac_niu", > "pclk_phy_niu", > + "pclk_uart2", > + "sclk_uart2", > }; > Not need to mark the uart2 as critical clocks, the uart clk will enabled by uart driver probe(dw8250_probe()). For your question, Please check the uart2 dts node "status = okay". Or You can send me the complete log, I check the status of uart2. > static void __init rk3328_clk_init(struct device_node *np) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-09 1:40 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-08 14:45 [PATCH] clk: rockchip: mark pclk_uart2 as critical on rk3328 Johan Jonker 2020-07-08 14:45 ` Johan Jonker 2020-07-08 15:34 ` Robin Murphy 2020-07-08 15:34 ` Robin Murphy 2020-07-08 16:28 ` Johan Jonker 2020-07-08 16:28 ` Johan Jonker 2020-07-08 18:44 ` Robin Murphy 2020-07-08 18:44 ` Robin Murphy 2020-07-09 1:32 ` elaine.zhang [this message] 2020-07-09 1:32 ` elaine.zhang 2020-07-09 12:04 ` Johan Jonker 2020-07-09 12:04 ` Johan Jonker 2020-07-10 1:28 ` elaine.zhang 2020-07-10 1:28 ` elaine.zhang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2f58b9df-9bcd-5639-65cc-306a6d36b310@rock-chips.com \ --to=zhangqing@rock-chips.com \ --cc=heiko@sntech.de \ --cc=jbx6244@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=mturquette@baylibre.com \ --cc=sboyd@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.