Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: enable configuring GENEVE port

From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ophir Munk <ophirmu@nvidia.com>,
	dev@dpdk.org, Wenzhuo Lu <wenzhuo.lu@intel.com>,
	Beilei Xing <beilei.xing@intel.com>,
	Bernard Iremonger <bernard.iremonger@intel.com>
Cc: Ophir Munk <ophirmu@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: enable configuring GENEVE port
Date: Mon, 14 Sep 2020 18:31:16 +0100	[thread overview]
Message-ID: <30fe788b-7447-1b83-b847-bdbe3cd7d4f3@intel.com> (raw)
In-Reply-To: <20200827070244.32392-3-ophirmu@nvidia.com>

On 8/27/2020 8:02 AM, Ophir Munk wrote:
> From: Ophir Munk <ophirmu@mellanox.com>
> 
> IANA has assigned port 6081 as the fixed well-known destination port for
> GENEVE. Nevertheless draft-ietf-nvo3-geneve-09 recommends that
> implementations make this configurable.  This commit enables specifying
> any positive UDP destination port number for GENEVE.
> 
> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
> ---
>  app/test-pmd/parameters.c | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
> index 7cb0e3d..0d135b0 100644
> --- a/app/test-pmd/parameters.c
> +++ b/app/test-pmd/parameters.c
> @@ -70,7 +70,8 @@ usage(char* progname)
>  	       "--rxpt= | --rxht= | --rxwt= | --rxfreet= | "
>  	       "--txpt= | --txht= | --txwt= | --txfreet= | "
>  	       "--txrst= | --tx-offloads= | | --rx-offloads= | "
> -	       "--vxlan-gpe-port= ]\n",
> +	       "--vxlan-gpe-port= ] "
> +	       "--geneve-port= ]\n",
>  	       progname);

Hi Ophir,

Is there a command line to update the geneve port?

I can see there are some parameter for other tunneling too, but do you
find providing parameter useful? I think command line better since it is
more flexible, what do you think?