All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Arun Ramamurthy <arun.ramamurthy@broadcom.com>
Cc: linux-arm-kernel@lists.infradead.org,
	Alan Stern <stern@rowland.harvard.edu>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Scott Branden <sbranden@broadcom.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Ray Jui <rjui@broadcom.com>,
	linux-kernel@vger.kernel.org,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Jonathan Richardson <jonathar@broadcom.com>,
	Rob Herring <robh+dt@kernel.org>,
	bcm-kernel-feedback-list@broadcom.com,
	Dmitry Torokhov <dtor@google.com>,
	Kumar Gala <galak@codeaurora.org>,
	Anatol Pomazau <anatol@google.com>
Subject: Re: [PATCH 1/2] phy: usbphy: Add dt documentation for Broadcom Cygnus USB PHY driver
Date: Wed, 11 Mar 2015 22:47:30 +0100	[thread overview]
Message-ID: <3142298.YeoA7WAayD@wuerfel> (raw)
In-Reply-To: <5500B5B6.50609@broadcom.com>

On Wednesday 11 March 2015 14:37:58 Arun Ramamurthy wrote:
> On 15-03-10 01:27 PM, Arnd Bergmann wrote:
> > On Wednesday 25 February 2015 16:24:06 Arun Ramamurthy wrote:
> >>>>> Should I run this by Alan Stern?
> >>>>
> >>>> I've added him to Cc here. He clearly didn't know the background about
> >>>> the DT binding change, and should not need to, but he may have an opinion
> >>>> on what names we should use.
> >>>>
> >>>
> >> Arnd, should I re patch the ehci-platform driver to avoid phy-names
> >> entirely? Alan, if not do you have an opinion on what the usb phy names
> >> should be? The current patch uses "usbp" + port number such as "usbp0" ,
> >> "usbp1" etc
> >
> > I think avoiding the phy names would be best here, but it requires a
> > kernel API change first, because we do not have a way to get a phy
> > by index as we do for other subsystems (e.g. clocks or gpios).
> >
> Arnd , there is an existing api _of_phy_get that gets a phy by index. 
> However it is not exported and is called from of_phy_get which is in 
> turn called from devm_of_phy_get.
> 
> My plan is to create a new function maybe devm_of_phy_get_by_index that 
> calls _of_phy_get directly? What are your thoughts?

Sounds good to me.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Arun Ramamurthy
	<arun.ramamurthy-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Alan Stern
	<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Scott Branden <sbranden-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
	Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	Ian Campbell
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	Ray Jui <rjui-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>,
	Jonathan Richardson
	<jonathar-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org,
	Dmitry Torokhov <dtor-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	Anatol Pomazau <anatol-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 1/2] phy: usbphy: Add dt documentation for Broadcom Cygnus USB PHY driver
Date: Wed, 11 Mar 2015 22:47:30 +0100	[thread overview]
Message-ID: <3142298.YeoA7WAayD@wuerfel> (raw)
In-Reply-To: <5500B5B6.50609-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>

On Wednesday 11 March 2015 14:37:58 Arun Ramamurthy wrote:
> On 15-03-10 01:27 PM, Arnd Bergmann wrote:
> > On Wednesday 25 February 2015 16:24:06 Arun Ramamurthy wrote:
> >>>>> Should I run this by Alan Stern?
> >>>>
> >>>> I've added him to Cc here. He clearly didn't know the background about
> >>>> the DT binding change, and should not need to, but he may have an opinion
> >>>> on what names we should use.
> >>>>
> >>>
> >> Arnd, should I re patch the ehci-platform driver to avoid phy-names
> >> entirely? Alan, if not do you have an opinion on what the usb phy names
> >> should be? The current patch uses "usbp" + port number such as "usbp0" ,
> >> "usbp1" etc
> >
> > I think avoiding the phy names would be best here, but it requires a
> > kernel API change first, because we do not have a way to get a phy
> > by index as we do for other subsystems (e.g. clocks or gpios).
> >
> Arnd , there is an existing api _of_phy_get that gets a phy by index. 
> However it is not exported and is called from of_phy_get which is in 
> turn called from devm_of_phy_get.
> 
> My plan is to create a new function maybe devm_of_phy_get_by_index that 
> calls _of_phy_get directly? What are your thoughts?

Sounds good to me.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] phy: usbphy: Add dt documentation for Broadcom Cygnus USB PHY driver
Date: Wed, 11 Mar 2015 22:47:30 +0100	[thread overview]
Message-ID: <3142298.YeoA7WAayD@wuerfel> (raw)
In-Reply-To: <5500B5B6.50609@broadcom.com>

On Wednesday 11 March 2015 14:37:58 Arun Ramamurthy wrote:
> On 15-03-10 01:27 PM, Arnd Bergmann wrote:
> > On Wednesday 25 February 2015 16:24:06 Arun Ramamurthy wrote:
> >>>>> Should I run this by Alan Stern?
> >>>>
> >>>> I've added him to Cc here. He clearly didn't know the background about
> >>>> the DT binding change, and should not need to, but he may have an opinion
> >>>> on what names we should use.
> >>>>
> >>>
> >> Arnd, should I re patch the ehci-platform driver to avoid phy-names
> >> entirely? Alan, if not do you have an opinion on what the usb phy names
> >> should be? The current patch uses "usbp" + port number such as "usbp0" ,
> >> "usbp1" etc
> >
> > I think avoiding the phy names would be best here, but it requires a
> > kernel API change first, because we do not have a way to get a phy
> > by index as we do for other subsystems (e.g. clocks or gpios).
> >
> Arnd , there is an existing api _of_phy_get that gets a phy by index. 
> However it is not exported and is called from of_phy_get which is in 
> turn called from devm_of_phy_get.
> 
> My plan is to create a new function maybe devm_of_phy_get_by_index that 
> calls _of_phy_get directly? What are your thoughts?

Sounds good to me.

	Arnd

  reply	other threads:[~2015-03-11 21:48 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-17 19:20 [PATCH 0/2] USB PHY driver for Broadcom's Cygnus chipset Arun Ramamurthy
2015-02-17 19:20 ` Arun Ramamurthy
2015-02-17 19:20 ` Arun Ramamurthy
2015-02-17 19:20 ` [PATCH 1/2] phy: usbphy: Add dt documentation for Broadcom Cygnus USB PHY driver Arun Ramamurthy
2015-02-17 19:20   ` Arun Ramamurthy
2015-02-17 19:20   ` Arun Ramamurthy
2015-02-17 19:41   ` Arnd Bergmann
2015-02-17 19:41     ` Arnd Bergmann
2015-02-17 20:00     ` Arun Ramamurthy
2015-02-17 20:00       ` Arun Ramamurthy
2015-02-17 20:00       ` Arun Ramamurthy
2015-02-17 20:53       ` Arnd Bergmann
2015-02-17 20:53         ` Arnd Bergmann
2015-02-17 21:05         ` Arun Ramamurthy
2015-02-17 21:05           ` Arun Ramamurthy
2015-02-17 21:05           ` Arun Ramamurthy
2015-02-18 15:15           ` Arnd Bergmann
2015-02-18 15:15             ` Arnd Bergmann
2015-02-19  0:46             ` Arun Ramamurthy
2015-02-19  0:46               ` Arun Ramamurthy
2015-02-19  0:46               ` Arun Ramamurthy
2015-02-26  0:24               ` Arun Ramamurthy
2015-02-26  0:24                 ` Arun Ramamurthy
2015-02-26  0:24                 ` Arun Ramamurthy
2015-03-10 20:27                 ` Arnd Bergmann
2015-03-10 20:27                   ` Arnd Bergmann
2015-03-11 21:37                   ` Arun Ramamurthy
2015-03-11 21:37                     ` Arun Ramamurthy
2015-03-11 21:37                     ` Arun Ramamurthy
2015-03-11 21:47                     ` Arnd Bergmann [this message]
2015-03-11 21:47                       ` Arnd Bergmann
2015-03-11 21:47                       ` Arnd Bergmann
2015-02-17 19:20 ` [PATCH 2/2] phy: usbphy: Add " Arun Ramamurthy
2015-02-17 19:20   ` Arun Ramamurthy
2015-02-17 19:20   ` Arun Ramamurthy
2015-02-18  6:10   ` Kishon Vijay Abraham I
2015-02-18  6:10     ` Kishon Vijay Abraham I
2015-02-18  6:10     ` Kishon Vijay Abraham I
2015-03-05 22:33   ` Dmitry Torokhov
2015-03-05 22:33     ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3142298.YeoA7WAayD@wuerfel \
    --to=arnd@arndb.de \
    --cc=anatol@google.com \
    --cc=arun.ramamurthy@broadcom.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dtor@google.com \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jonathar@broadcom.com \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=rjui@broadcom.com \
    --cc=robh+dt@kernel.org \
    --cc=sbranden@broadcom.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.