From: Arun Ramamurthy <arun.ramamurthy@broadcom.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, <devicetree@vger.kernel.org>,
Jonathan Richardson <jonathar@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
<linux-arm-kernel@lists.infradead.org>,
<bcm-kernel-feedback-list@broadcom.com>,
<linux-kernel@vger.kernel.org>, Dmitry Torokhov <dtor@google.com>,
Anatol Pomazau <anatol@google.com>
Subject: Re: [PATCH 1/2] phy: usbphy: Add dt documentation for Broadcom Cygnus USB PHY driver
Date: Tue, 17 Feb 2015 12:00:49 -0800 [thread overview]
Message-ID: <54E39DF1.50409@broadcom.com> (raw)
In-Reply-To: <8242260.cl4QTECoeX@wuerfel>
Thank you for the review Arnd.
On 15-02-17 11:41 AM, Arnd Bergmann wrote:
> On Tuesday 17 February 2015 11:20:20 Arun Ramamurthy wrote:
>> + /* This nodes declares port 0
>> + and port 1 as host*/
>> +
>> + ehci0: usb@0x18048000 {
>> + compatible = "generic-ehci";
>> + reg = <0x18048000 0x100>;
>> + interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>;
>> + phys = <&usbphy0 0 1 &usbphy0 1>;
>
> The second reference in the example is missing the last cell,
> as you have #phy-cells = <2>.
>
I am missing a 1 for the port number, will update in next patchset,
thank you
>> + phy-names = "usbp0","usbp1";
>> + status = "okay";
>> + };
>
> Further, the binding for "generic-ehci" requires the name to be "usb",
> not "usbp0". You should probably update that binding if you can have
> multiple references to mention that.
>
> Can you make both names "usb"? If not, we should document a common
> naming scheme that the driver can use.
>
Arnd, I patched the ehci and ohci driver to accept multiple phys so they
require different names and cannot both be "usb". That patch was
accepted by Alen Stern but I did not update the bindings documentation.
I will send out another patch for that. Could we go with the naming
scheme of "usb" + "p" + port number or do you have other suggestions?
> Arnd
>
WARNING: multiple messages have this Message-ID (diff)
From: Arun Ramamurthy <arun.ramamurthy@broadcom.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org,
Jonathan Richardson <jonathar@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org, Dmitry Torokhov <dtor@google.com>,
Anatol Pomazau <anatol@google.com>
Subject: Re: [PATCH 1/2] phy: usbphy: Add dt documentation for Broadcom Cygnus USB PHY driver
Date: Tue, 17 Feb 2015 12:00:49 -0800 [thread overview]
Message-ID: <54E39DF1.50409@broadcom.com> (raw)
In-Reply-To: <8242260.cl4QTECoeX@wuerfel>
Thank you for the review Arnd.
On 15-02-17 11:41 AM, Arnd Bergmann wrote:
> On Tuesday 17 February 2015 11:20:20 Arun Ramamurthy wrote:
>> + /* This nodes declares port 0
>> + and port 1 as host*/
>> +
>> + ehci0: usb@0x18048000 {
>> + compatible = "generic-ehci";
>> + reg = <0x18048000 0x100>;
>> + interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>;
>> + phys = <&usbphy0 0 1 &usbphy0 1>;
>
> The second reference in the example is missing the last cell,
> as you have #phy-cells = <2>.
>
I am missing a 1 for the port number, will update in next patchset,
thank you
>> + phy-names = "usbp0","usbp1";
>> + status = "okay";
>> + };
>
> Further, the binding for "generic-ehci" requires the name to be "usb",
> not "usbp0". You should probably update that binding if you can have
> multiple references to mention that.
>
> Can you make both names "usb"? If not, we should document a common
> naming scheme that the driver can use.
>
Arnd, I patched the ehci and ohci driver to accept multiple phys so they
require different names and cannot both be "usb". That patch was
accepted by Alen Stern but I did not update the bindings documentation.
I will send out another patch for that. Could we go with the naming
scheme of "usb" + "p" + port number or do you have other suggestions?
> Arnd
>
WARNING: multiple messages have this Message-ID (diff)
From: arun.ramamurthy@broadcom.com (Arun Ramamurthy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] phy: usbphy: Add dt documentation for Broadcom Cygnus USB PHY driver
Date: Tue, 17 Feb 2015 12:00:49 -0800 [thread overview]
Message-ID: <54E39DF1.50409@broadcom.com> (raw)
In-Reply-To: <8242260.cl4QTECoeX@wuerfel>
Thank you for the review Arnd.
On 15-02-17 11:41 AM, Arnd Bergmann wrote:
> On Tuesday 17 February 2015 11:20:20 Arun Ramamurthy wrote:
>> + /* This nodes declares port 0
>> + and port 1 as host*/
>> +
>> + ehci0: usb at 0x18048000 {
>> + compatible = "generic-ehci";
>> + reg = <0x18048000 0x100>;
>> + interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>;
>> + phys = <&usbphy0 0 1 &usbphy0 1>;
>
> The second reference in the example is missing the last cell,
> as you have #phy-cells = <2>.
>
I am missing a 1 for the port number, will update in next patchset,
thank you
>> + phy-names = "usbp0","usbp1";
>> + status = "okay";
>> + };
>
> Further, the binding for "generic-ehci" requires the name to be "usb",
> not "usbp0". You should probably update that binding if you can have
> multiple references to mention that.
>
> Can you make both names "usb"? If not, we should document a common
> naming scheme that the driver can use.
>
Arnd, I patched the ehci and ohci driver to accept multiple phys so they
require different names and cannot both be "usb". That patch was
accepted by Alen Stern but I did not update the bindings documentation.
I will send out another patch for that. Could we go with the naming
scheme of "usb" + "p" + port number or do you have other suggestions?
> Arnd
>
next prev parent reply other threads:[~2015-02-17 19:59 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-17 19:20 [PATCH 0/2] USB PHY driver for Broadcom's Cygnus chipset Arun Ramamurthy
2015-02-17 19:20 ` Arun Ramamurthy
2015-02-17 19:20 ` Arun Ramamurthy
2015-02-17 19:20 ` [PATCH 1/2] phy: usbphy: Add dt documentation for Broadcom Cygnus USB PHY driver Arun Ramamurthy
2015-02-17 19:20 ` Arun Ramamurthy
2015-02-17 19:20 ` Arun Ramamurthy
2015-02-17 19:41 ` Arnd Bergmann
2015-02-17 19:41 ` Arnd Bergmann
2015-02-17 20:00 ` Arun Ramamurthy [this message]
2015-02-17 20:00 ` Arun Ramamurthy
2015-02-17 20:00 ` Arun Ramamurthy
2015-02-17 20:53 ` Arnd Bergmann
2015-02-17 20:53 ` Arnd Bergmann
2015-02-17 21:05 ` Arun Ramamurthy
2015-02-17 21:05 ` Arun Ramamurthy
2015-02-17 21:05 ` Arun Ramamurthy
2015-02-18 15:15 ` Arnd Bergmann
2015-02-18 15:15 ` Arnd Bergmann
2015-02-19 0:46 ` Arun Ramamurthy
2015-02-19 0:46 ` Arun Ramamurthy
2015-02-19 0:46 ` Arun Ramamurthy
2015-02-26 0:24 ` Arun Ramamurthy
2015-02-26 0:24 ` Arun Ramamurthy
2015-02-26 0:24 ` Arun Ramamurthy
2015-03-10 20:27 ` Arnd Bergmann
2015-03-10 20:27 ` Arnd Bergmann
2015-03-11 21:37 ` Arun Ramamurthy
2015-03-11 21:37 ` Arun Ramamurthy
2015-03-11 21:37 ` Arun Ramamurthy
2015-03-11 21:47 ` Arnd Bergmann
2015-03-11 21:47 ` Arnd Bergmann
2015-03-11 21:47 ` Arnd Bergmann
2015-02-17 19:20 ` [PATCH 2/2] phy: usbphy: Add " Arun Ramamurthy
2015-02-17 19:20 ` Arun Ramamurthy
2015-02-17 19:20 ` Arun Ramamurthy
2015-02-18 6:10 ` Kishon Vijay Abraham I
2015-02-18 6:10 ` Kishon Vijay Abraham I
2015-02-18 6:10 ` Kishon Vijay Abraham I
2015-03-05 22:33 ` Dmitry Torokhov
2015-03-05 22:33 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E39DF1.50409@broadcom.com \
--to=arun.ramamurthy@broadcom.com \
--cc=anatol@google.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=dtor@google.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jonathar@broadcom.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.