* [PATCH 1/3] cpufreq / gx: Fix __init attribute locations
@ 2013-08-13 10:20 Hanjun Guo
2013-08-13 10:20 ` [PATCH 2/3] cpufreq / pxa2xx: " Hanjun Guo
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Hanjun Guo @ 2013-08-13 10:20 UTC (permalink / raw)
To: Viresh Kumar
Cc: Rafael J. Wysocki, cpufreq, linux-pm, patches, linaro-kernel,
linaro-acpi, Hanjun Guo
__init belongs after the return type on functions, not before it.
Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
---
drivers/cpufreq/gx-suspmod.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/gx-suspmod.c b/drivers/cpufreq/gx-suspmod.c
index 3dfc99b..e30fd16 100644
--- a/drivers/cpufreq/gx-suspmod.c
+++ b/drivers/cpufreq/gx-suspmod.c
@@ -183,7 +183,7 @@ static void gx_write_byte(int reg, int value)
* gx_detect_chipset:
*
**/
-static __init struct pci_dev *gx_detect_chipset(void)
+static struct pci_dev * __init gx_detect_chipset(void)
{
struct pci_dev *gx_pci = NULL;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/3] cpufreq / pxa2xx: Fix __init attribute locations
2013-08-13 10:20 [PATCH 1/3] cpufreq / gx: Fix __init attribute locations Hanjun Guo
@ 2013-08-13 10:20 ` Hanjun Guo
2013-08-13 10:20 ` [PATCH 3/3] cpufreq / s3c24xx: " Hanjun Guo
2013-08-13 13:19 ` [PATCH 1/3] cpufreq / gx: " Rafael J. Wysocki
2 siblings, 0 replies; 4+ messages in thread
From: Hanjun Guo @ 2013-08-13 10:20 UTC (permalink / raw)
To: Viresh Kumar
Cc: Rafael J. Wysocki, cpufreq, linux-pm, patches, linaro-kernel,
linaro-acpi, Hanjun Guo
__init belongs after the return type on functions, not before it.
Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
---
drivers/cpufreq/pxa2xx-cpufreq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/cpufreq/pxa2xx-cpufreq.c b/drivers/cpufreq/pxa2xx-cpufreq.c
index fb3981a..8749eaf 100644
--- a/drivers/cpufreq/pxa2xx-cpufreq.c
+++ b/drivers/cpufreq/pxa2xx-cpufreq.c
@@ -191,7 +191,7 @@ static int pxa_cpufreq_change_voltage(pxa_freqs_t *pxa_freq)
return ret;
}
-static __init void pxa_cpufreq_init_voltages(void)
+static void __init pxa_cpufreq_init_voltages(void)
{
vcc_core = regulator_get(NULL, "vcc_core");
if (IS_ERR(vcc_core)) {
@@ -207,7 +207,7 @@ static int pxa_cpufreq_change_voltage(pxa_freqs_t *pxa_freq)
return 0;
}
-static __init void pxa_cpufreq_init_voltages(void) { }
+static void __init pxa_cpufreq_init_voltages(void) { }
#endif
static void find_freq_tables(struct cpufreq_frequency_table **freq_table,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/3] cpufreq / s3c24xx: Fix __init attribute locations
2013-08-13 10:20 [PATCH 1/3] cpufreq / gx: Fix __init attribute locations Hanjun Guo
2013-08-13 10:20 ` [PATCH 2/3] cpufreq / pxa2xx: " Hanjun Guo
@ 2013-08-13 10:20 ` Hanjun Guo
2013-08-13 13:19 ` [PATCH 1/3] cpufreq / gx: " Rafael J. Wysocki
2 siblings, 0 replies; 4+ messages in thread
From: Hanjun Guo @ 2013-08-13 10:20 UTC (permalink / raw)
To: Viresh Kumar
Cc: Rafael J. Wysocki, cpufreq, linux-pm, patches, linaro-kernel,
linaro-acpi, Hanjun Guo
__init belongs after the return type on functions, not before it.
Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
---
drivers/cpufreq/s3c24xx-cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/s3c24xx-cpufreq.c b/drivers/cpufreq/s3c24xx-cpufreq.c
index 87781eb..3d927d6 100644
--- a/drivers/cpufreq/s3c24xx-cpufreq.c
+++ b/drivers/cpufreq/s3c24xx-cpufreq.c
@@ -392,7 +392,7 @@ static int s3c_cpufreq_init(struct cpufreq_policy *policy)
return 0;
}
-static __init int s3c_cpufreq_initclks(void)
+static int __init s3c_cpufreq_initclks(void)
{
_clk_mpll = s3c_cpufreq_clk_get(NULL, "mpll");
_clk_xtal = s3c_cpufreq_clk_get(NULL, "xtal");
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] cpufreq / gx: Fix __init attribute locations
2013-08-13 10:20 [PATCH 1/3] cpufreq / gx: Fix __init attribute locations Hanjun Guo
2013-08-13 10:20 ` [PATCH 2/3] cpufreq / pxa2xx: " Hanjun Guo
2013-08-13 10:20 ` [PATCH 3/3] cpufreq / s3c24xx: " Hanjun Guo
@ 2013-08-13 13:19 ` Rafael J. Wysocki
2 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2013-08-13 13:19 UTC (permalink / raw)
To: Hanjun Guo
Cc: Viresh Kumar, cpufreq, linux-pm, patches, linaro-kernel, linaro-acpi
On Tuesday, August 13, 2013 06:20:08 PM Hanjun Guo wrote:
> __init belongs after the return type on functions, not before it.
>
> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
All 3 patches in the series queued up for 3.12.
Thanks,
Rafael
> ---
> drivers/cpufreq/gx-suspmod.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/gx-suspmod.c b/drivers/cpufreq/gx-suspmod.c
> index 3dfc99b..e30fd16 100644
> --- a/drivers/cpufreq/gx-suspmod.c
> +++ b/drivers/cpufreq/gx-suspmod.c
> @@ -183,7 +183,7 @@ static void gx_write_byte(int reg, int value)
> * gx_detect_chipset:
> *
> **/
> -static __init struct pci_dev *gx_detect_chipset(void)
> +static struct pci_dev * __init gx_detect_chipset(void)
> {
> struct pci_dev *gx_pci = NULL;
>
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-08-13 13:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-13 10:20 [PATCH 1/3] cpufreq / gx: Fix __init attribute locations Hanjun Guo
2013-08-13 10:20 ` [PATCH 2/3] cpufreq / pxa2xx: " Hanjun Guo
2013-08-13 10:20 ` [PATCH 3/3] cpufreq / s3c24xx: " Hanjun Guo
2013-08-13 13:19 ` [PATCH 1/3] cpufreq / gx: " Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.