All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Andre Przywara <andre.przywara@arm.com>
Cc: Rob Herring <robh@kernel.org>, Icenowy Zheng <icenowy@aosc.io>,
	Samuel Holland <samuel@sholland.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev,
	linux-kernel@vger.kernel.org, Ondrej Jirman <megous@megous.com>,
	Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	linux-rtc@vger.kernel.org
Subject: Re: [PATCH v8 06/11] rtc: sun6i: Add support for RTCs without external LOSCs
Date: Sun, 25 Jul 2021 08:18:23 +0200	[thread overview]
Message-ID: <3166830.bveH9cQ5e6@kista> (raw)
In-Reply-To: <20210723153838.6785-7-andre.przywara@arm.com>

Hi Andre!

Dne petek, 23. julij 2021 ob 17:38:33 CEST je Andre Przywara napisal(a):
> Some newer Allwinner RTCs (for instance the one in the H616 SoC) lack
> a pin for an external 32768 Hz oscillator. As a consequence, this LOSC
> can't be selected as the RTC clock source, and we must rely on the
> internal RC oscillator.
> To allow additions of clocks to the RTC node, add a feature bit to ignore
> any provided clocks for now (the current code would think this is the
> external LOSC). Later DTs and code can then for instance add the PLL
> based clock input, and older kernel won't get confused.
> 
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
>  drivers/rtc/rtc-sun6i.c | 16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)
> 

Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej



WARNING: multiple messages have this Message-ID (diff)
From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Andre Przywara <andre.przywara@arm.com>
Cc: Rob Herring <robh@kernel.org>, Icenowy Zheng <icenowy@aosc.io>,
	Samuel Holland <samuel@sholland.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev,
	linux-kernel@vger.kernel.org, Ondrej Jirman <megous@megous.com>,
	Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	linux-rtc@vger.kernel.org
Subject: Re: [PATCH v8 06/11] rtc: sun6i: Add support for RTCs without external LOSCs
Date: Sun, 25 Jul 2021 08:18:23 +0200	[thread overview]
Message-ID: <3166830.bveH9cQ5e6@kista> (raw)
In-Reply-To: <20210723153838.6785-7-andre.przywara@arm.com>

Hi Andre!

Dne petek, 23. julij 2021 ob 17:38:33 CEST je Andre Przywara napisal(a):
> Some newer Allwinner RTCs (for instance the one in the H616 SoC) lack
> a pin for an external 32768 Hz oscillator. As a consequence, this LOSC
> can't be selected as the RTC clock source, and we must rely on the
> internal RC oscillator.
> To allow additions of clocks to the RTC node, add a feature bit to ignore
> any provided clocks for now (the current code would think this is the
> external LOSC). Later DTs and code can then for instance add the PLL
> based clock input, and older kernel won't get confused.
> 
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
>  drivers/rtc/rtc-sun6i.c | 16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)
> 

Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-07-25  6:18 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-23 15:38 [PATCH v8 00/11] arm64: sunxi: Initial Allwinner H616 SoC support Andre Przywara
2021-07-23 15:38 ` Andre Przywara
2021-07-23 15:38 ` [PATCH v8 01/11] dt-bindings: mfd: axp20x: Add AXP305 compatible (plus optional IRQ) Andre Przywara
2021-07-23 15:38   ` Andre Przywara
2021-08-16 12:39   ` Lee Jones
2021-08-16 12:39     ` Lee Jones
2021-07-23 15:38 ` [PATCH v8 02/11] dt-bindings: rtc: sun6i: Add H616 compatible string Andre Przywara
2021-07-23 15:38   ` Andre Przywara
2021-07-23 22:34   ` Rob Herring
2021-07-23 22:34     ` Rob Herring
2021-07-26 14:41   ` Maxime Ripard
2021-07-26 14:41     ` Maxime Ripard
2021-08-02  0:39     ` Andre Przywara
2021-08-02  0:39       ` Andre Przywara
2021-08-17  7:38       ` Maxime Ripard
2021-08-17  7:38         ` Maxime Ripard
2021-08-17  8:13         ` Alexandre Belloni
2021-08-17  8:13           ` Alexandre Belloni
2021-08-19  7:56           ` Maxime Ripard
2021-08-19  7:56             ` Maxime Ripard
2021-08-18  9:04         ` Andre Przywara
2021-08-18  9:04           ` Andre Przywara
2021-08-20  3:57           ` Samuel Holland
2021-08-20  3:57             ` Samuel Holland
2021-09-01  7:21           ` Maxime Ripard
2021-09-01  7:21             ` Maxime Ripard
2021-07-23 15:38 ` [PATCH v8 03/11] rtc: sun6i: Fix time overflow handling Andre Przywara
2021-07-23 15:38   ` Andre Przywara
2021-07-25  5:44   ` Jernej Škrabec
2021-07-25  5:44     ` Jernej Škrabec
2021-07-23 15:38 ` [PATCH v8 04/11] rtc: sun6i: Add support for linear day storage Andre Przywara
2021-07-23 15:38   ` Andre Przywara
2021-07-25  5:51   ` Jernej Škrabec
2021-07-25  5:51     ` Jernej Škrabec
2021-07-23 15:38 ` [PATCH v8 05/11] rtc: sun6i: Add support for broken-down alarm registers Andre Przywara
2021-07-23 15:38   ` Andre Przywara
2021-07-25  6:11   ` Jernej Škrabec
2021-07-25  6:11     ` Jernej Škrabec
2021-08-02  0:39     ` Andre Przywara
2021-08-02  0:39       ` Andre Przywara
2021-07-23 15:38 ` [PATCH v8 06/11] rtc: sun6i: Add support for RTCs without external LOSCs Andre Przywara
2021-07-23 15:38   ` Andre Przywara
2021-07-25  6:18   ` Jernej Škrabec [this message]
2021-07-25  6:18     ` Jernej Škrabec
2021-07-23 15:38 ` [PATCH v8 07/11] rtc: sun6i: Add Allwinner H616 support Andre Przywara
2021-07-23 15:38   ` Andre Przywara
2021-07-25  6:19   ` Jernej Škrabec
2021-07-25  6:19     ` Jernej Škrabec
2021-07-23 15:38 ` [PATCH v8 08/11] arm64: dts: allwinner: Add Allwinner H616 .dtsi file Andre Przywara
2021-07-23 15:38   ` Andre Przywara
2021-07-23 15:38 ` [PATCH v8 09/11] dt-bindings: arm: sunxi: Add two H616 board compatible strings Andre Przywara
2021-07-23 15:38   ` Andre Przywara
2021-07-23 15:38 ` [PATCH v8 10/11] arm64: dts: allwinner: h616: Add OrangePi Zero 2 board support Andre Przywara
2021-07-23 15:38   ` Andre Przywara
2021-07-23 15:38 ` [PATCH v8 11/11] arm64: dts: allwinner: h616: Add X96 Mate TV box support Andre Przywara
2021-07-23 15:38   ` Andre Przywara
2021-07-25 16:41 ` [PATCH v8 00/11] arm64: sunxi: Initial Allwinner H616 SoC support Icenowy Zheng
2021-07-25 16:41   ` Icenowy Zheng
2021-07-25 16:41   ` Icenowy Zheng
2021-07-26 14:52 ` Maxime Ripard
2021-07-26 14:52   ` Maxime Ripard
2021-08-02  0:38   ` Andre Przywara
2021-08-02  0:38     ` Andre Przywara
2021-08-17  7:30     ` Maxime Ripard
2021-08-17  7:30       ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3166830.bveH9cQ5e6@kista \
    --to=jernej.skrabec@gmail.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andre.przywara@arm.com \
    --cc=icenowy@aosc.io \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=megous@megous.com \
    --cc=mripard@kernel.org \
    --cc=robh@kernel.org \
    --cc=samuel@sholland.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.