From: Johnson Wang <johnson.wang@mediatek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<ulf.hansson@linaro.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>
Cc: <linux-mmc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188
Date: Thu, 7 Jul 2022 15:30:40 +0800 [thread overview]
Message-ID: <3216ec92952c7d722feaeb76986e0a6a54340646.camel@mediatek.com> (raw)
In-Reply-To: <41e17a56-5cb0-8e90-c7ae-a7a56de986d0@linaro.org>
On Thu, 2022-07-07 at 08:46 +0200, Krzysztof Kozlowski wrote:
> On 07/07/2022 07:47, Johnson Wang wrote:
> > This commit adds dt-binding documentation of mmc for MediaTek
> > MT8188 SoC
> > platform.
> >
> > Signed-off-by: Johnson Wang <johnson.wang@mediatek.com>
> > ---
> > Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > index 2a2e9fa8c188..3fbf33ad4f7c 100644
> > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > @@ -32,6 +32,9 @@ properties:
> > - items:
> > - const: mediatek,mt8186-mmc
> > - const: mediatek,mt8183-mmc
> > + - items:
> > + - const: mediatek,mt8188-mmc
>
> You duplicate quite a lot. Use enum.
>
> Best regards,
> Krzysztof
Hi Krzysztof,
Thanks for you suggestion.
I will use 'enum' to place this compatible strings.
Just like this:
- items:
- enum:
- mediatek,mt8186-mmc
- mediatek,mt8188-mmc
- mediatek,mt8192-mmc
- mediatek,mt8195-mmc
- const: mediatek,mt8183-mmc
Moreover, it seems that missing an "items:" between oneOf and enum in
the compatible property.
Is my understanding wrong?
BRs,
Johnson Wang
WARNING: multiple messages have this Message-ID (diff)
From: Johnson Wang <johnson.wang@mediatek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<ulf.hansson@linaro.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>
Cc: <linux-mmc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188
Date: Thu, 7 Jul 2022 15:30:40 +0800 [thread overview]
Message-ID: <3216ec92952c7d722feaeb76986e0a6a54340646.camel@mediatek.com> (raw)
In-Reply-To: <41e17a56-5cb0-8e90-c7ae-a7a56de986d0@linaro.org>
On Thu, 2022-07-07 at 08:46 +0200, Krzysztof Kozlowski wrote:
> On 07/07/2022 07:47, Johnson Wang wrote:
> > This commit adds dt-binding documentation of mmc for MediaTek
> > MT8188 SoC
> > platform.
> >
> > Signed-off-by: Johnson Wang <johnson.wang@mediatek.com>
> > ---
> > Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > index 2a2e9fa8c188..3fbf33ad4f7c 100644
> > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > @@ -32,6 +32,9 @@ properties:
> > - items:
> > - const: mediatek,mt8186-mmc
> > - const: mediatek,mt8183-mmc
> > + - items:
> > + - const: mediatek,mt8188-mmc
>
> You duplicate quite a lot. Use enum.
>
> Best regards,
> Krzysztof
Hi Krzysztof,
Thanks for you suggestion.
I will use 'enum' to place this compatible strings.
Just like this:
- items:
- enum:
- mediatek,mt8186-mmc
- mediatek,mt8188-mmc
- mediatek,mt8192-mmc
- mediatek,mt8195-mmc
- const: mediatek,mt8183-mmc
Moreover, it seems that missing an "items:" between oneOf and enum in
the compatible property.
Is my understanding wrong?
BRs,
Johnson Wang
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-07 7:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 5:47 [PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188 Johnson Wang
2022-07-07 5:47 ` Johnson Wang
2022-07-07 6:46 ` Krzysztof Kozlowski
2022-07-07 6:46 ` Krzysztof Kozlowski
2022-07-07 7:30 ` Johnson Wang [this message]
2022-07-07 7:30 ` Johnson Wang
2022-07-11 11:02 ` Krzysztof Kozlowski
2022-07-11 11:02 ` Krzysztof Kozlowski
2022-07-11 12:03 ` Johnson Wang
2022-07-11 12:03 ` Johnson Wang
2022-07-07 9:51 ` AngeloGioacchino Del Regno
2022-07-07 9:51 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3216ec92952c7d722feaeb76986e0a6a54340646.camel@mediatek.com \
--to=johnson.wang@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.