All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Johnson Wang <johnson.wang@mediatek.com>,
	ulf.hansson@linaro.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188
Date: Mon, 11 Jul 2022 13:02:30 +0200	[thread overview]
Message-ID: <c8f8f5f4-173e-797d-e060-e5eaac7ca822@linaro.org> (raw)
In-Reply-To: <3216ec92952c7d722feaeb76986e0a6a54340646.camel@mediatek.com>

On 07/07/2022 09:30, Johnson Wang wrote:
> On Thu, 2022-07-07 at 08:46 +0200, Krzysztof Kozlowski wrote:
>> On 07/07/2022 07:47, Johnson Wang wrote:
>>> This commit adds dt-binding documentation of mmc for MediaTek
>>> MT8188 SoC
>>> platform.
>>>
>>> Signed-off-by: Johnson Wang <johnson.wang@mediatek.com>
>>> ---
>>>  Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>>> b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>>> index 2a2e9fa8c188..3fbf33ad4f7c 100644
>>> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>>> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>>> @@ -32,6 +32,9 @@ properties:
>>>        - items:
>>>            - const: mediatek,mt8186-mmc
>>>            - const: mediatek,mt8183-mmc
>>> +      - items:
>>> +          - const: mediatek,mt8188-mmc
>>
>> You duplicate quite a lot. Use enum.
>>
>> Best regards,
>> Krzysztof
> 
> Hi Krzysztof,
> 
> Thanks for you suggestion.
> 
> I will use 'enum' to place this compatible strings.
> 
> Just like this:
> - items:
>     - enum:
>         - mediatek,mt8186-mmc
>         - mediatek,mt8188-mmc
>         - mediatek,mt8192-mmc
>         - mediatek,mt8195-mmc
>     - const: mediatek,mt8183-mmc
> 
> Moreover, it seems that missing an "items:" between oneOf and enum in
> the compatible property.
> Is my understanding wrong?

I did not propose to remove items, so where are they missing? Not sure
what you are asking about...

Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Johnson Wang <johnson.wang@mediatek.com>,
	ulf.hansson@linaro.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188
Date: Mon, 11 Jul 2022 13:02:30 +0200	[thread overview]
Message-ID: <c8f8f5f4-173e-797d-e060-e5eaac7ca822@linaro.org> (raw)
In-Reply-To: <3216ec92952c7d722feaeb76986e0a6a54340646.camel@mediatek.com>

On 07/07/2022 09:30, Johnson Wang wrote:
> On Thu, 2022-07-07 at 08:46 +0200, Krzysztof Kozlowski wrote:
>> On 07/07/2022 07:47, Johnson Wang wrote:
>>> This commit adds dt-binding documentation of mmc for MediaTek
>>> MT8188 SoC
>>> platform.
>>>
>>> Signed-off-by: Johnson Wang <johnson.wang@mediatek.com>
>>> ---
>>>  Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>>> b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>>> index 2a2e9fa8c188..3fbf33ad4f7c 100644
>>> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>>> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
>>> @@ -32,6 +32,9 @@ properties:
>>>        - items:
>>>            - const: mediatek,mt8186-mmc
>>>            - const: mediatek,mt8183-mmc
>>> +      - items:
>>> +          - const: mediatek,mt8188-mmc
>>
>> You duplicate quite a lot. Use enum.
>>
>> Best regards,
>> Krzysztof
> 
> Hi Krzysztof,
> 
> Thanks for you suggestion.
> 
> I will use 'enum' to place this compatible strings.
> 
> Just like this:
> - items:
>     - enum:
>         - mediatek,mt8186-mmc
>         - mediatek,mt8188-mmc
>         - mediatek,mt8192-mmc
>         - mediatek,mt8195-mmc
>     - const: mediatek,mt8183-mmc
> 
> Moreover, it seems that missing an "items:" between oneOf and enum in
> the compatible property.
> Is my understanding wrong?

I did not propose to remove items, so where are they missing? Not sure
what you are asking about...

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-07-11 11:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-07  5:47 [PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188 Johnson Wang
2022-07-07  5:47 ` Johnson Wang
2022-07-07  6:46 ` Krzysztof Kozlowski
2022-07-07  6:46   ` Krzysztof Kozlowski
2022-07-07  7:30   ` Johnson Wang
2022-07-07  7:30     ` Johnson Wang
2022-07-11 11:02     ` Krzysztof Kozlowski [this message]
2022-07-11 11:02       ` Krzysztof Kozlowski
2022-07-11 12:03       ` Johnson Wang
2022-07-11 12:03         ` Johnson Wang
2022-07-07  9:51 ` AngeloGioacchino Del Regno
2022-07-07  9:51   ` AngeloGioacchino Del Regno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8f8f5f4-173e-797d-e060-e5eaac7ca822@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=johnson.wang@mediatek.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.