All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Tanmay Shah <tanmay@codeaurora.org>,
	swboyd@chromium.org, devicetree@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	robdclark@gmail.com
Cc: linux-kernel@vger.kernel.org, freedreno@lists.freedesktop.org,
	seanpaul@chromium.org, daniel@ffwll.ch, airlied@linux.ie,
	aravindh@codeaurora.org, abhinavk@codeaurora.org,
	khsieh@codeaurora.org, Chandan Uddaraju <chandanu@codeaurora.org>,
	Vara Reddy <varar@codeaurora.org>,
	Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH v10 2/5] drm/msm/dp: add displayPort driver support
Date: Fri, 14 Aug 2020 20:12:09 +0300	[thread overview]
Message-ID: <324d61b6-fc26-03ea-f8af-ff74a9767da2@linaro.org> (raw)
In-Reply-To: <20200812044223.19279-3-tanmay@codeaurora.org>

Hello,

On 12/08/2020 07:42, Tanmay Shah wrote:
> From: Chandan Uddaraju <chandanu@codeaurora.org>

[skipped]

> +		} else if ((dp_parser_check_prefix("ctrl", clk_name) ||
> +			   dp_parser_check_prefix("stream", clk_name))  &&
> +			   ctrl_clk_index < ctrl_clk_count) {
> +			struct dss_clk *clk =
> +				&ctrl_power->clk_config[ctrl_clk_index];
> +			strlcpy(clk->clk_name, clk_name, sizeof(clk->clk_name));
> +			ctrl_clk_index++;
> +
> +			if (!strncmp(clk_name, "ctrl_link",
> +					strlen("ctrl_link")) ||
> +					!strncmp(clk_name, "stream_pixel",
> +					strlen("ctrl_pixel")))

This should be "stream_pixel", I believe. I don't like macros, but most 
probably it would help here. Also function/brace alignment could be 
better (sorry, it really hides the issue here).


> +				clk->type = DSS_CLK_PCLK;
> +			else
> +				clk->type = DSS_CLK_AHB;
> +		}
> +	}


-- 
With best wishes
Dmitry

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Tanmay Shah <tanmay@codeaurora.org>,
	swboyd@chromium.org, devicetree@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	robdclark@gmail.com
Cc: airlied@linux.ie, linux-kernel@vger.kernel.org,
	abhinavk@codeaurora.org, khsieh@codeaurora.org,
	seanpaul@chromium.org, Guenter Roeck <groeck@chromium.org>,
	Vara Reddy <varar@codeaurora.org>,
	aravindh@codeaurora.org, freedreno@lists.freedesktop.org,
	Chandan Uddaraju <chandanu@codeaurora.org>
Subject: Re: [PATCH v10 2/5] drm/msm/dp: add displayPort driver support
Date: Fri, 14 Aug 2020 20:12:09 +0300	[thread overview]
Message-ID: <324d61b6-fc26-03ea-f8af-ff74a9767da2@linaro.org> (raw)
In-Reply-To: <20200812044223.19279-3-tanmay@codeaurora.org>

Hello,

On 12/08/2020 07:42, Tanmay Shah wrote:
> From: Chandan Uddaraju <chandanu@codeaurora.org>

[skipped]

> +		} else if ((dp_parser_check_prefix("ctrl", clk_name) ||
> +			   dp_parser_check_prefix("stream", clk_name))  &&
> +			   ctrl_clk_index < ctrl_clk_count) {
> +			struct dss_clk *clk =
> +				&ctrl_power->clk_config[ctrl_clk_index];
> +			strlcpy(clk->clk_name, clk_name, sizeof(clk->clk_name));
> +			ctrl_clk_index++;
> +
> +			if (!strncmp(clk_name, "ctrl_link",
> +					strlen("ctrl_link")) ||
> +					!strncmp(clk_name, "stream_pixel",
> +					strlen("ctrl_pixel")))

This should be "stream_pixel", I believe. I don't like macros, but most 
probably it would help here. Also function/brace alignment could be 
better (sorry, it really hides the issue here).


> +				clk->type = DSS_CLK_PCLK;
> +			else
> +				clk->type = DSS_CLK_AHB;
> +		}
> +	}


-- 
With best wishes
Dmitry
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-08-14 17:12 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-12  4:42 [PATCH v10 0/5] Add support for DisplayPort driver on SnapDragon Tanmay Shah
2020-08-12  4:42 ` Tanmay Shah
2020-08-12  4:42 ` [PATCH v10 1/5] drm: add constant N value in helper file Tanmay Shah
2020-08-12  4:42   ` Tanmay Shah
2020-08-12  4:42 ` [PATCH v10 2/5] drm/msm/dp: add displayPort driver support Tanmay Shah
2020-08-12  4:42   ` Tanmay Shah
2020-08-14 17:12   ` Dmitry Baryshkov [this message]
2020-08-14 17:12     ` Dmitry Baryshkov
2020-08-14 17:56     ` [Freedreno] " Tanmay Shah
2020-08-14 17:56       ` Tanmay Shah
2020-08-14 21:14       ` Tanmay Shah
2020-08-14 21:14         ` Tanmay Shah
2020-08-12  4:42 ` [PATCH v10 3/5] drm/msm/dp: add support for DP PLL driver Tanmay Shah
2020-08-12  4:42   ` Tanmay Shah
2020-08-14 17:05   ` Dmitry Baryshkov
2020-08-14 17:05     ` Dmitry Baryshkov
2020-08-14 23:22     ` Tanmay Shah
2020-08-14 23:22       ` Tanmay Shah
2020-08-15 11:45       ` Dmitry Baryshkov
2020-08-15 11:45         ` Dmitry Baryshkov
2020-08-17 18:06         ` Tanmay Shah
2020-08-17 18:06           ` Tanmay Shah
2020-08-15 20:20     ` Rob Clark
2020-08-15 20:20       ` Rob Clark
2020-08-15 21:21       ` [Freedreno] " Jonathan Marek
2020-08-15 21:21         ` Jonathan Marek
2020-08-15 22:45         ` Rob Clark
2020-08-15 22:45           ` Rob Clark
2020-08-17 20:00           ` Tanmay Shah
2020-08-17 20:00             ` Tanmay Shah
2020-08-17 20:32           ` Dmitry Baryshkov
2020-08-17 20:32             ` Dmitry Baryshkov
2020-08-17 20:37             ` Rob Clark
2020-08-17 20:37               ` Rob Clark
2020-08-12  4:42 ` [PATCH v10 4/5] drm/msm/dpu: add display port support in DPU Tanmay Shah
2020-08-12  4:42   ` Tanmay Shah
2020-08-12  4:42 ` [PATCH v10 5/5] drm/msm/dp: Add Display Port HPD feature Tanmay Shah
2020-08-12  4:42   ` Tanmay Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=324d61b6-fc26-03ea-f8af-ff74a9767da2@linaro.org \
    --to=dmitry.baryshkov@linaro.org \
    --cc=abhinavk@codeaurora.org \
    --cc=airlied@linux.ie \
    --cc=aravindh@codeaurora.org \
    --cc=chandanu@codeaurora.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=groeck@chromium.org \
    --cc=khsieh@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robdclark@gmail.com \
    --cc=seanpaul@chromium.org \
    --cc=swboyd@chromium.org \
    --cc=tanmay@codeaurora.org \
    --cc=varar@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.