From: "Heiko Stübner" <heiko@sntech.de>
To: Linus Walleij <linus.walleij@linaro.org>,
Peter Geis <pgwipeout@gmail.com>
Cc: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Jianqun Xu <jay.xu@rock-chips.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH v4] pinctrl: rockchip: add support for rk3568
Date: Sat, 10 Apr 2021 23:10:37 +0200 [thread overview]
Message-ID: <3262311.AJdgDx1Vlc@diego> (raw)
In-Reply-To: <CAMdYzYqk3k0UqCyFwB+W1tKKKTg39Mx0Vdsrj+eeC58nARaumQ@mail.gmail.com>
Hi Peter,
Am Samstag, 10. April 2021, 20:30:52 CEST schrieb Peter Geis:
> Good Afternoon,
>
> I'm currently working on the rk3566 early bringup support in mainline
> and encountered an issue with this patch set.
> Unfortunately in the rk3568/rk3566 the gpio registers switched to the
> (16 bits write enable / 16 bits config) register format that other
> rockchip registers use.
> This differs from previous chips where all 32 bits were used for gpio
> configuration.
> The patch fails to account for this, which causes all gpios to fail to function.
>
> For clarity, this only affects GPIO_SWPORT_DR and GPIO_SWPORT_DDR.
>
> I'm currently working on a patch to fix this issue, but I know that
> you are planning on breaking out the gpio functions into a separate
> driver and wanted to make you aware of this immediately.
just pointing to Jianqun's series providing the gpio controller support:
https://lore.kernel.org/r/20210324064704.950104-1-jay.xu@rock-chips.com
which introduces the necessary writemask-handling but seems to need an
update, judging by Ezequiel's reply to it.
Heiko
> Very Respectfully,
> Peter Geis
>
> On Fri, Apr 9, 2021 at 8:38 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> >
> > On Fri, Apr 9, 2021 at 6:17 AM Ezequiel Garcia
> > <ezequiel@vanguardiasur.com.ar> wrote:
> >
> > > Seems we are missing the dt-bindings for the new compatible string
> > > "rockchip,rk3568-pinctrl". Is there a patch for it somewhere?
> >
> > Nope please send one :)
> >
> > Yours,
> > Linus Walleij
> >
> > _______________________________________________
> > Linux-rockchip mailing list
> > Linux-rockchip@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-rockchip
>
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Linus Walleij <linus.walleij@linaro.org>,
Peter Geis <pgwipeout@gmail.com>
Cc: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Jianqun Xu <jay.xu@rock-chips.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH v4] pinctrl: rockchip: add support for rk3568
Date: Sat, 10 Apr 2021 23:10:37 +0200 [thread overview]
Message-ID: <3262311.AJdgDx1Vlc@diego> (raw)
In-Reply-To: <CAMdYzYqk3k0UqCyFwB+W1tKKKTg39Mx0Vdsrj+eeC58nARaumQ@mail.gmail.com>
Hi Peter,
Am Samstag, 10. April 2021, 20:30:52 CEST schrieb Peter Geis:
> Good Afternoon,
>
> I'm currently working on the rk3566 early bringup support in mainline
> and encountered an issue with this patch set.
> Unfortunately in the rk3568/rk3566 the gpio registers switched to the
> (16 bits write enable / 16 bits config) register format that other
> rockchip registers use.
> This differs from previous chips where all 32 bits were used for gpio
> configuration.
> The patch fails to account for this, which causes all gpios to fail to function.
>
> For clarity, this only affects GPIO_SWPORT_DR and GPIO_SWPORT_DDR.
>
> I'm currently working on a patch to fix this issue, but I know that
> you are planning on breaking out the gpio functions into a separate
> driver and wanted to make you aware of this immediately.
just pointing to Jianqun's series providing the gpio controller support:
https://lore.kernel.org/r/20210324064704.950104-1-jay.xu@rock-chips.com
which introduces the necessary writemask-handling but seems to need an
update, judging by Ezequiel's reply to it.
Heiko
> Very Respectfully,
> Peter Geis
>
> On Fri, Apr 9, 2021 at 8:38 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> >
> > On Fri, Apr 9, 2021 at 6:17 AM Ezequiel Garcia
> > <ezequiel@vanguardiasur.com.ar> wrote:
> >
> > > Seems we are missing the dt-bindings for the new compatible string
> > > "rockchip,rk3568-pinctrl". Is there a patch for it somewhere?
> >
> > Nope please send one :)
> >
> > Yours,
> > Linus Walleij
> >
> > _______________________________________________
> > Linux-rockchip mailing list
> > Linux-rockchip@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-rockchip
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2021-04-10 21:10 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 7:24 [PATCH] pinctrl: rockchip: add support for rk3568 Jianqun Xu
2021-02-23 7:24 ` Jianqun Xu
2021-02-23 10:08 ` Johan Jonker
2021-02-23 10:08 ` Johan Jonker
2021-02-23 10:11 ` Heiko Stübner
2021-02-23 10:11 ` Heiko Stübner
2021-02-24 11:39 ` [PATCH v2] " Jianqun Xu
2021-02-24 11:39 ` Jianqun Xu
2021-03-04 0:58 ` [PATCH v3] " Jianqun Xu
2021-03-04 0:58 ` Jianqun Xu
2021-03-04 1:33 ` [PATCH v3 RESEND] " Jianqun Xu
2021-03-04 1:33 ` Jianqun Xu
2021-03-05 1:24 ` Kever Yang
2021-03-05 1:24 ` Kever Yang
2021-03-19 8:11 ` [PATCH v3] " Jianqun Xu
2021-03-19 8:11 ` Jianqun Xu
2021-03-19 8:14 ` [PATCH v4] " Jianqun Xu
2021-03-19 8:14 ` Jianqun Xu
2021-03-19 11:28 ` jay.xu
2021-03-19 11:28 ` jay.xu
2021-04-08 13:40 ` Linus Walleij
2021-04-08 13:40 ` Linus Walleij
2021-04-09 4:17 ` Ezequiel Garcia
2021-04-09 4:17 ` Ezequiel Garcia
2021-04-09 12:37 ` Linus Walleij
2021-04-09 12:37 ` Linus Walleij
2021-04-10 18:30 ` Peter Geis
2021-04-10 18:30 ` Peter Geis
2021-04-10 21:10 ` Heiko Stübner [this message]
2021-04-10 21:10 ` Heiko Stübner
2021-04-11 0:40 ` Linus Walleij
2021-04-11 0:40 ` Linus Walleij
2021-04-11 3:40 ` Peter Geis
2021-04-11 3:40 ` Peter Geis
2021-04-11 7:55 ` Heiko Stübner
2021-04-11 7:55 ` Heiko Stübner
2021-04-14 7:31 ` Linus Walleij
2021-04-14 7:31 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3262311.AJdgDx1Vlc@diego \
--to=heiko@sntech.de \
--cc=catalin.marinas@arm.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=jay.xu@rock-chips.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pgwipeout@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.