Re: [PATCH 1/1] fs/erofs: silence erofs_probe()

[Huang Jianan <jnhuang95@gmail.com>]

在 2022/7/31 17:10, Heinrich Schuchardt 写道:
> fs_set_blk_dev() probes all file-systems until it finds one that matches
> the volume. We do not expect any console output for non-matching
> file-systems.
> 
> Convert error messages in erofs_read_superblock() to debug output.
> 
> Fixes: 830613f8f5bb ("fs/erofs: add erofs filesystem support")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>   fs/erofs/super.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/erofs/super.c b/fs/erofs/super.c
> index 4cca322b9e..095754dc28 100644
> --- a/fs/erofs/super.c
> +++ b/fs/erofs/super.c
> @@ -65,14 +65,14 @@ int erofs_read_superblock(void)
>   
>   	ret = erofs_blk_read(data, 0, 1);
>   	if (ret < 0) {
> -		erofs_err("cannot read erofs superblock: %d", ret);
> +		erofs_dbg("cannot read erofs superblock: %d", ret);
>   		return -EIO;
>   	}
>   	dsb = (struct erofs_super_block *)(data + EROFS_SUPER_OFFSET);
>   
>   	ret = -EINVAL;
>   	if (le32_to_cpu(dsb->magic) != EROFS_SUPER_MAGIC_V1) {
> -		erofs_err("cannot find valid erofs superblock");
> +		erofs_dbg("cannot find valid erofs superblock");
>   		return ret;
>   	}
>   
> @@ -81,7 +81,7 @@ int erofs_read_superblock(void)
>   	blkszbits = dsb->blkszbits;
>   	/* 9(512 bytes) + LOG_SECTORS_PER_BLOCK == LOG_BLOCK_SIZE */
>   	if (blkszbits != LOG_BLOCK_SIZE) {
> -		erofs_err("blksize %u isn't supported on this platform",
> +		erofs_dbg("blksize %u isn't supported on this platform",
>   			  1 << blkszbits);
>   		return ret;
>   	}
Reviewed-by: Huang Jianan <jnhuang95@gmail.com>

Thanks,
Jianan