From: Simon Glass <sjg@chromium.org> To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> Cc: Huang Jianan <jnhuang95@gmail.com>, linux-erofs@lists.ozlabs.org, U-Boot Mailing List <u-boot@lists.denx.de> Subject: Re: [PATCH 1/1] fs/erofs: silence erofs_probe() Date: Sun, 31 Jul 2022 12:41:19 -0600 [thread overview] Message-ID: <CAPnjgZ2mXuT5w5SKSeBnzUvBFvtwfmYqjZGWGutPiJ+4-fi_sg@mail.gmail.com> (raw) In-Reply-To: <20220731091006.50073-1-heinrich.schuchardt@canonical.com> On Sun, 31 Jul 2022 at 03:10, Heinrich Schuchardt <heinrich.schuchardt@canonical.com> wrote: > > fs_set_blk_dev() probes all file-systems until it finds one that matches > the volume. We do not expect any console output for non-matching > file-systems. > > Convert error messages in erofs_read_superblock() to debug output. > > Fixes: 830613f8f5bb ("fs/erofs: add erofs filesystem support") > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> > --- > fs/erofs/super.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org> > > diff --git a/fs/erofs/super.c b/fs/erofs/super.c > index 4cca322b9e..095754dc28 100644 > --- a/fs/erofs/super.c > +++ b/fs/erofs/super.c > @@ -65,14 +65,14 @@ int erofs_read_superblock(void) > > ret = erofs_blk_read(data, 0, 1); > if (ret < 0) { > - erofs_err("cannot read erofs superblock: %d", ret); > + erofs_dbg("cannot read erofs superblock: %d", ret); > return -EIO; > } > dsb = (struct erofs_super_block *)(data + EROFS_SUPER_OFFSET); > > ret = -EINVAL; > if (le32_to_cpu(dsb->magic) != EROFS_SUPER_MAGIC_V1) { > - erofs_err("cannot find valid erofs superblock"); > + erofs_dbg("cannot find valid erofs superblock"); > return ret; > } > > @@ -81,7 +81,7 @@ int erofs_read_superblock(void) > blkszbits = dsb->blkszbits; > /* 9(512 bytes) + LOG_SECTORS_PER_BLOCK == LOG_BLOCK_SIZE */ > if (blkszbits != LOG_BLOCK_SIZE) { > - erofs_err("blksize %u isn't supported on this platform", > + erofs_dbg("blksize %u isn't supported on this platform", > 1 << blkszbits); Does this message appear in normal scanning, or is it a genuine error? > return ret; > } > -- > 2.36.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Simon Glass <sjg@chromium.org> To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> Cc: U-Boot Mailing List <u-boot@lists.denx.de>, linux-erofs@lists.ozlabs.org Subject: Re: [PATCH 1/1] fs/erofs: silence erofs_probe() Date: Sun, 31 Jul 2022 12:41:19 -0600 [thread overview] Message-ID: <CAPnjgZ2mXuT5w5SKSeBnzUvBFvtwfmYqjZGWGutPiJ+4-fi_sg@mail.gmail.com> (raw) In-Reply-To: <20220731091006.50073-1-heinrich.schuchardt@canonical.com> On Sun, 31 Jul 2022 at 03:10, Heinrich Schuchardt <heinrich.schuchardt@canonical.com> wrote: > > fs_set_blk_dev() probes all file-systems until it finds one that matches > the volume. We do not expect any console output for non-matching > file-systems. > > Convert error messages in erofs_read_superblock() to debug output. > > Fixes: 830613f8f5bb ("fs/erofs: add erofs filesystem support") > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> > --- > fs/erofs/super.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org> > > diff --git a/fs/erofs/super.c b/fs/erofs/super.c > index 4cca322b9e..095754dc28 100644 > --- a/fs/erofs/super.c > +++ b/fs/erofs/super.c > @@ -65,14 +65,14 @@ int erofs_read_superblock(void) > > ret = erofs_blk_read(data, 0, 1); > if (ret < 0) { > - erofs_err("cannot read erofs superblock: %d", ret); > + erofs_dbg("cannot read erofs superblock: %d", ret); > return -EIO; > } > dsb = (struct erofs_super_block *)(data + EROFS_SUPER_OFFSET); > > ret = -EINVAL; > if (le32_to_cpu(dsb->magic) != EROFS_SUPER_MAGIC_V1) { > - erofs_err("cannot find valid erofs superblock"); > + erofs_dbg("cannot find valid erofs superblock"); > return ret; > } > > @@ -81,7 +81,7 @@ int erofs_read_superblock(void) > blkszbits = dsb->blkszbits; > /* 9(512 bytes) + LOG_SECTORS_PER_BLOCK == LOG_BLOCK_SIZE */ > if (blkszbits != LOG_BLOCK_SIZE) { > - erofs_err("blksize %u isn't supported on this platform", > + erofs_dbg("blksize %u isn't supported on this platform", > 1 << blkszbits); Does this message appear in normal scanning, or is it a genuine error? > return ret; > } > -- > 2.36.1 >
next prev parent reply other threads:[~2022-07-31 18:41 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-31 9:10 [PATCH 1/1] fs/erofs: silence erofs_probe() Heinrich Schuchardt 2022-07-31 9:10 ` Heinrich Schuchardt 2022-07-31 13:49 ` Huang Jianan 2022-07-31 13:49 ` Huang Jianan 2022-07-31 18:41 ` Simon Glass [this message] 2022-07-31 18:41 ` Simon Glass 2022-07-31 20:53 ` Heinrich Schuchardt 2022-07-31 20:53 ` Heinrich Schuchardt 2022-07-31 22:42 ` Gao Xiang 2022-07-31 22:42 ` Gao Xiang 2022-08-01 13:27 Heinrich Schuchardt 2022-08-01 13:27 ` Heinrich Schuchardt 2022-08-01 14:42 ` Huang Jianan 2022-08-01 14:42 ` Huang Jianan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAPnjgZ2mXuT5w5SKSeBnzUvBFvtwfmYqjZGWGutPiJ+4-fi_sg@mail.gmail.com \ --to=sjg@chromium.org \ --cc=heinrich.schuchardt@canonical.com \ --cc=jnhuang95@gmail.com \ --cc=linux-erofs@lists.ozlabs.org \ --cc=u-boot@lists.denx.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.