* [PATCH] regulator: tps65217: fix build error if REGULATOR is not enabled
@ 2012-07-18 6:41 ` AnilKumar Ch
0 siblings, 0 replies; 6+ messages in thread
From: AnilKumar Ch @ 2012-07-18 6:41 UTC (permalink / raw)
To: rdunlap
Cc: sfr, sameo, broonie, linux-next, linux-kernel, linux-omap, AnilKumar Ch
Fixes below build error if CONFIG_REGULATOR is not enabled.
drivers/built-in.o: In function `tps65217_probe':
tps65217.c:(.devinit.text+0x13e37): undefined reference to `of_regulator_match'
Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
---
drivers/mfd/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index e129c82..01c929a 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -159,6 +159,7 @@ config TPS6507X
config MFD_TPS65217
tristate "TPS65217 Power Management / White LED chips"
depends on I2C
+ depends on REGULATOR
select MFD_CORE
select REGMAP_I2C
help
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] regulator: tps65217: fix build error if REGULATOR is not enabled
@ 2012-07-18 6:41 ` AnilKumar Ch
0 siblings, 0 replies; 6+ messages in thread
From: AnilKumar Ch @ 2012-07-18 6:41 UTC (permalink / raw)
To: rdunlap
Cc: sfr, sameo, broonie, linux-next, linux-kernel, linux-omap, AnilKumar Ch
Fixes below build error if CONFIG_REGULATOR is not enabled.
drivers/built-in.o: In function `tps65217_probe':
tps65217.c:(.devinit.text+0x13e37): undefined reference to `of_regulator_match'
Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
---
drivers/mfd/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index e129c82..01c929a 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -159,6 +159,7 @@ config TPS6507X
config MFD_TPS65217
tristate "TPS65217 Power Management / White LED chips"
depends on I2C
+ depends on REGULATOR
select MFD_CORE
select REGMAP_I2C
help
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] regulator: tps65217: fix build error if REGULATOR is not enabled
2012-07-18 6:41 ` AnilKumar Ch
(?)
@ 2012-07-18 9:44 ` Mark Brown
2012-07-18 9:55 ` AnilKumar, Chimata
-1 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2012-07-18 9:44 UTC (permalink / raw)
To: AnilKumar Ch; +Cc: rdunlap, sfr, sameo, linux-next, linux-kernel, linux-omap
[-- Attachment #1: Type: text/plain, Size: 478 bytes --]
On Wed, Jul 18, 2012 at 12:11:03PM +0530, AnilKumar Ch wrote:
> Fixes below build error if CONFIG_REGULATOR is not enabled.
>
> drivers/built-in.o: In function `tps65217_probe':
> tps65217.c:(.devinit.text+0x13e37): undefined reference to `of_regulator_match'
This isn't a patch to the regulator driver, this is a patch to the MFD.
Normally this would be fixed by making the MFD driver not depend on the
regulator API - why is the MFD driver using the regulator API?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] regulator: tps65217: fix build error if REGULATOR is not enabled
2012-07-18 9:44 ` Mark Brown
@ 2012-07-18 9:55 ` AnilKumar, Chimata
2012-07-18 10:00 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: AnilKumar, Chimata @ 2012-07-18 9:55 UTC (permalink / raw)
To: Mark Brown; +Cc: rdunlap, sfr, sameo, linux-next, linux-kernel, linux-omap
Mark,
On Wed, Jul 18, 2012 at 15:14:49, Mark Brown wrote:
> On Wed, Jul 18, 2012 at 12:11:03PM +0530, AnilKumar Ch wrote:
> > Fixes below build error if CONFIG_REGULATOR is not enabled.
> >
> > drivers/built-in.o: In function `tps65217_probe':
> > tps65217.c:(.devinit.text+0x13e37): undefined reference to `of_regulator_match'
>
> This isn't a patch to the regulator driver, this is a patch to the MFD.
> Normally this would be fixed by making the MFD driver not depend on the
> regulator API - why is the MFD driver using the regulator API?
>
Regulators platform data is added to platform device in MFD driver, which we
need for regulator driver, of_regulator_match() is used to check the regulator
consumers if we pass DT data. If we do not enable CONFIG_REGULATOR then
of_regulator_match() is not exported, so we see this error.
Regards
AnilKumar
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] regulator: tps65217: fix build error if REGULATOR is not enabled
2012-07-18 9:55 ` AnilKumar, Chimata
@ 2012-07-18 10:00 ` Mark Brown
2012-07-19 12:35 ` AnilKumar, Chimata
0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2012-07-18 10:00 UTC (permalink / raw)
To: AnilKumar, Chimata
Cc: rdunlap, sfr, sameo, linux-next, linux-kernel, linux-omap
[-- Attachment #1: Type: text/plain, Size: 408 bytes --]
On Wed, Jul 18, 2012 at 09:55:57AM +0000, AnilKumar, Chimata wrote:
> Regulators platform data is added to platform device in MFD driver, which we
> need for regulator driver, of_regulator_match() is used to check the regulator
> consumers if we pass DT data. If we do not enable CONFIG_REGULATOR then
> of_regulator_match() is not exported, so we see this error.
Why are you doing that in the MFD driver?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] regulator: tps65217: fix build error if REGULATOR is not enabled
2012-07-18 10:00 ` Mark Brown
@ 2012-07-19 12:35 ` AnilKumar, Chimata
0 siblings, 0 replies; 6+ messages in thread
From: AnilKumar, Chimata @ 2012-07-19 12:35 UTC (permalink / raw)
To: Mark Brown; +Cc: rdunlap, sfr, sameo, linux-next, linux-kernel, linux-omap
Hi Mark,
On Wed, Jul 18, 2012 at 15:30:13, Mark Brown wrote:
> On Wed, Jul 18, 2012 at 09:55:57AM +0000, AnilKumar, Chimata wrote:
>
> > Regulators platform data is added to platform device in MFD driver, which we
> > need for regulator driver, of_regulator_match() is used to check the regulator
> > consumers if we pass DT data. If we do not enable CONFIG_REGULATOR then
> > of_regulator_match() is not exported, so we see this error.
>
> Why are you doing that in the MFD driver?
>
I got your point, I referred tps6586x driver while developing the initial driver.
Based on tps6586x MFD driver I added REGULATOR flag. I think tps6586x MFD driver
need to be cleaned up.
I will submit a patch to make tps65217 MFD driver independent of REGULATOR
framework.
Thanks
AnilKumar
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-07-19 12:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-18 6:41 [PATCH] regulator: tps65217: fix build error if REGULATOR is not enabled AnilKumar Ch
2012-07-18 6:41 ` AnilKumar Ch
2012-07-18 9:44 ` Mark Brown
2012-07-18 9:55 ` AnilKumar, Chimata
2012-07-18 10:00 ` Mark Brown
2012-07-19 12:35 ` AnilKumar, Chimata
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.