* Re: [dpdk-dev] [PATCH] lib/librte_kni: fix the type for mac address
2019-01-24 3:53 [PATCH] lib/librte_kni: fix the type for mac address Jie Pan
@ 2019-04-04 23:27 ` Thomas Monjalon
2019-04-09 19:47 ` Yigit, Ferruh
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: Thomas Monjalon @ 2019-04-04 23:27 UTC (permalink / raw)
To: ferruh.yigit; +Cc: dev, Jie Pan
24/01/2019 04:53, Jie Pan:
> The type for mac address in struct rte_kni_conf should be unsigned.
>
> Signed-off-by: Jie Pan <panjie5@jd.com>
> ---
> lib/librte_kni/rte_kni.h | 2 +-
> - char mac_addr[ETHER_ADDR_LEN]; /* MAC address assigned to KNI */
> + uint8_t mac_addr[ETHER_ADDR_LEN]; /* MAC address assigned to KNI */
Ferruh, it seems this patch is lacking a review.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [PATCH] lib/librte_kni: fix the type for mac address
2019-01-24 3:53 [PATCH] lib/librte_kni: fix the type for mac address Jie Pan
2019-04-04 23:27 ` [dpdk-dev] " Thomas Monjalon
@ 2019-04-09 19:47 ` Yigit, Ferruh
2019-04-10 6:20 ` [dpdk-dev] 答复: " 潘杰
2019-04-10 6:09 ` [dpdk-dev] [PATCH v2] kni: fix the type for MAC address Jie Pan
2019-04-10 6:20 ` Jie Pan
3 siblings, 1 reply; 9+ messages in thread
From: Yigit, Ferruh @ 2019-04-09 19:47 UTC (permalink / raw)
To: Jie Pan, ferruh.yigit; +Cc: dev
On 1/24/2019 3:53 AM, Jie Pan wrote:
> The type for mac address in struct rte_kni_conf should be unsigned.
>
> Signed-off-by: Jie Pan <panjie5@jd.com>
> ---
> lib/librte_kni/rte_kni.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_kni/rte_kni.h b/lib/librte_kni/rte_kni.h
> index 02ca43b..d44496c 100644
> --- a/lib/librte_kni/rte_kni.h
> +++ b/lib/librte_kni/rte_kni.h
> @@ -68,7 +68,7 @@ struct rte_kni_conf {
>
> __extension__
> uint8_t force_bind : 1; /* Flag to bind kernel thread */
> - char mac_addr[ETHER_ADDR_LEN]; /* MAC address assigned to KNI */
> + uint8_t mac_addr[ETHER_ADDR_LEN]; /* MAC address assigned to KNI */
> uint16_t mtu;
> };
>
>
Suggested title:
kni: fix the type for MAC address
In commit log, needs:
"
Fixes: 1cfe212ed17a ("kni: support MAC address change")
Cc: stable@dpdk.org
"
Hi Jie,
What do you think about 'rte_kni_common.h', 'struct rte_kni_device_info' 'char
mac_addr[6];' field, seems added with same patch adds above 'mac_addr', does it
make sense to fix it too?
also "(unsigned char *)(dev_info.mac_addr)" in 'kni_misc.c'...
If so can you please send a new version with above fixes?
Thanks,
ferruh
^ permalink raw reply [flat|nested] 9+ messages in thread* [dpdk-dev] 答复: [PATCH] lib/librte_kni: fix the type for mac address
2019-04-09 19:47 ` Yigit, Ferruh
@ 2019-04-10 6:20 ` 潘杰
0 siblings, 0 replies; 9+ messages in thread
From: 潘杰 @ 2019-04-10 6:20 UTC (permalink / raw)
To: Yigit, Ferruh; +Cc: dev
Hi, Ferruh
Sure, what you said is ok.
Re-fix have upload at following link.
https://patches.dpdk.org/patch/52526/
It generate another patchwork, is that OK?
I am not sure about this, I have used --in-reply-to option when "git send-email".
Thanks.
Jie.
-----邮件原件-----
发件人: Yigit, Ferruh <ferruh.yigit@linux.intel.com>
发送时间: 2019年4月10日 3:48
收件人: 潘杰 <panjie5@jd.com>; ferruh.yigit@intel.com
抄送: dev@dpdk.org
主题: Re: [dpdk-dev] [PATCH] lib/librte_kni: fix the type for mac address
On 1/24/2019 3:53 AM, Jie Pan wrote:
> The type for mac address in struct rte_kni_conf should be unsigned.
>
> Signed-off-by: Jie Pan <panjie5@jd.com>
> ---
> lib/librte_kni/rte_kni.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_kni/rte_kni.h b/lib/librte_kni/rte_kni.h index
> 02ca43b..d44496c 100644
> --- a/lib/librte_kni/rte_kni.h
> +++ b/lib/librte_kni/rte_kni.h
> @@ -68,7 +68,7 @@ struct rte_kni_conf {
>
> __extension__
> uint8_t force_bind : 1; /* Flag to bind kernel thread */
> - char mac_addr[ETHER_ADDR_LEN]; /* MAC address assigned to KNI */
> + uint8_t mac_addr[ETHER_ADDR_LEN]; /* MAC address assigned to KNI */
> uint16_t mtu;
> };
>
>
Suggested title:
kni: fix the type for MAC address
In commit log, needs:
"
Fixes: 1cfe212ed17a ("kni: support MAC address change")
Cc: stable@dpdk.org
"
Hi Jie,
What do you think about 'rte_kni_common.h', 'struct rte_kni_device_info' 'char mac_addr[6];' field, seems added with same patch adds above 'mac_addr', does it make sense to fix it too?
also "(unsigned char *)(dev_info.mac_addr)" in 'kni_misc.c'...
If so can you please send a new version with above fixes?
Thanks,
ferruh
^ permalink raw reply [flat|nested] 9+ messages in thread
* [dpdk-dev] [PATCH v2] kni: fix the type for MAC address
2019-01-24 3:53 [PATCH] lib/librte_kni: fix the type for mac address Jie Pan
2019-04-04 23:27 ` [dpdk-dev] " Thomas Monjalon
2019-04-09 19:47 ` Yigit, Ferruh
@ 2019-04-10 6:09 ` Jie Pan
2019-04-10 6:20 ` Jie Pan
3 siblings, 0 replies; 9+ messages in thread
From: Jie Pan @ 2019-04-10 6:09 UTC (permalink / raw)
To: ferruh.yigit; +Cc: dev, Jie Pan, stable
The type for MAC address should be unsigned.
Fixes: 1cfe212ed17a ("kni: support MAC address change")
Cc: stable@dpdk.org
Signed-off-by: Jie Pan <panjie5@jd.com>
---
kernel/linux/kni/kni_misc.c | 2 +-
lib/librte_eal/linux/eal/include/rte_kni_common.h | 2 +-
lib/librte_kni/rte_kni.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/linux/kni/kni_misc.c b/kernel/linux/kni/kni_misc.c
index 31845e1..b6f474d 100644
--- a/kernel/linux/kni/kni_misc.c
+++ b/kernel/linux/kni/kni_misc.c
@@ -447,7 +447,7 @@ struct kni_net {
ether_addr_copy(net_dev->dev_addr, kni->lad_dev->dev_addr);
else {
/* if user has provided a valid mac address */
- if (is_valid_ether_addr((unsigned char *)(dev_info.mac_addr)))
+ if (is_valid_ether_addr(dev_info.mac_addr))
memcpy(net_dev->dev_addr, dev_info.mac_addr, ETH_ALEN);
else
/*
diff --git a/lib/librte_eal/linux/eal/include/rte_kni_common.h b/lib/librte_eal/linux/eal/include/rte_kni_common.h
index 5afa087..5db5a13 100644
--- a/lib/librte_eal/linux/eal/include/rte_kni_common.h
+++ b/lib/librte_eal/linux/eal/include/rte_kni_common.h
@@ -127,7 +127,7 @@ struct rte_kni_device_info {
/* mbuf size */
unsigned mbuf_size;
unsigned int mtu;
- char mac_addr[6];
+ uint8_t mac_addr[6];
};
#define KNI_DEVICE "kni"
diff --git a/lib/librte_kni/rte_kni.h b/lib/librte_kni/rte_kni.h
index 9a9a7d7..c93d3a9 100644
--- a/lib/librte_kni/rte_kni.h
+++ b/lib/librte_kni/rte_kni.h
@@ -68,7 +68,7 @@ struct rte_kni_conf {
__extension__
uint8_t force_bind : 1; /* Flag to bind kernel thread */
- char mac_addr[ETHER_ADDR_LEN]; /* MAC address assigned to KNI */
+ uint8_t mac_addr[ETHER_ADDR_LEN]; /* MAC address assigned to KNI */
uint16_t mtu;
};
--
1.8.3.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [dpdk-dev] [PATCH v2] kni: fix the type for MAC address
2019-01-24 3:53 [PATCH] lib/librte_kni: fix the type for mac address Jie Pan
` (2 preceding siblings ...)
2019-04-10 6:09 ` [dpdk-dev] [PATCH v2] kni: fix the type for MAC address Jie Pan
@ 2019-04-10 6:20 ` Jie Pan
2019-04-19 12:15 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
3 siblings, 1 reply; 9+ messages in thread
From: Jie Pan @ 2019-04-10 6:20 UTC (permalink / raw)
To: ferruh.yigit; +Cc: dev, Jie Pan, stable
The type for MAC address should be unsigned.
Fixes: 1cfe212ed17a ("kni: support MAC address change")
Cc: stable@dpdk.org
Signed-off-by: Jie Pan <panjie5@jd.com>
---
kernel/linux/kni/kni_misc.c | 2 +-
lib/librte_eal/linux/eal/include/rte_kni_common.h | 2 +-
lib/librte_kni/rte_kni.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/linux/kni/kni_misc.c b/kernel/linux/kni/kni_misc.c
index 31845e1..b6f474d 100644
--- a/kernel/linux/kni/kni_misc.c
+++ b/kernel/linux/kni/kni_misc.c
@@ -447,7 +447,7 @@ struct kni_net {
ether_addr_copy(net_dev->dev_addr, kni->lad_dev->dev_addr);
else {
/* if user has provided a valid mac address */
- if (is_valid_ether_addr((unsigned char *)(dev_info.mac_addr)))
+ if (is_valid_ether_addr(dev_info.mac_addr))
memcpy(net_dev->dev_addr, dev_info.mac_addr, ETH_ALEN);
else
/*
diff --git a/lib/librte_eal/linux/eal/include/rte_kni_common.h b/lib/librte_eal/linux/eal/include/rte_kni_common.h
index 5afa087..5db5a13 100644
--- a/lib/librte_eal/linux/eal/include/rte_kni_common.h
+++ b/lib/librte_eal/linux/eal/include/rte_kni_common.h
@@ -127,7 +127,7 @@ struct rte_kni_device_info {
/* mbuf size */
unsigned mbuf_size;
unsigned int mtu;
- char mac_addr[6];
+ uint8_t mac_addr[6];
};
#define KNI_DEVICE "kni"
diff --git a/lib/librte_kni/rte_kni.h b/lib/librte_kni/rte_kni.h
index 9a9a7d7..c93d3a9 100644
--- a/lib/librte_kni/rte_kni.h
+++ b/lib/librte_kni/rte_kni.h
@@ -68,7 +68,7 @@ struct rte_kni_conf {
__extension__
uint8_t force_bind : 1; /* Flag to bind kernel thread */
- char mac_addr[ETHER_ADDR_LEN]; /* MAC address assigned to KNI */
+ uint8_t mac_addr[ETHER_ADDR_LEN]; /* MAC address assigned to KNI */
uint16_t mtu;
};
--
1.8.3.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] kni: fix the type for MAC address
2019-04-10 6:20 ` Jie Pan
@ 2019-04-19 12:15 ` Ferruh Yigit
2019-04-19 15:29 ` Rami Rosen
0 siblings, 1 reply; 9+ messages in thread
From: Ferruh Yigit @ 2019-04-19 12:15 UTC (permalink / raw)
To: Jie Pan; +Cc: dev, stable
On 4/10/2019 7:20 AM, Jie Pan wrote:
> The type for MAC address should be unsigned.
>
> Fixes: 1cfe212ed17a ("kni: support MAC address change")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jie Pan <panjie5@jd.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] kni: fix the type for MAC address
2019-04-19 12:15 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
@ 2019-04-19 15:29 ` Rami Rosen
2019-04-19 20:58 ` Thomas Monjalon
0 siblings, 1 reply; 9+ messages in thread
From: Rami Rosen @ 2019-04-19 15:29 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: Jie Pan, dev, stable
On 4/10/2019 7:20 AM, Jie Pan wrote:
> The type for MAC address should be unsigned.
>
> Fixes: 1cfe212ed17a ("kni: support MAC address change")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jie Pan <panjie5@jd.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Reviewed-by: Rami Rosen <ramirose@gmail.com>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] kni: fix the type for MAC address
2019-04-19 15:29 ` Rami Rosen
@ 2019-04-19 20:58 ` Thomas Monjalon
0 siblings, 0 replies; 9+ messages in thread
From: Thomas Monjalon @ 2019-04-19 20:58 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, Rami Rosen, Jie Pan, stable
19/04/2019 17:29, Rami Rosen:
> On 4/10/2019 7:20 AM, Jie Pan wrote:
> > The type for MAC address should be unsigned.
> >
> > Fixes: 1cfe212ed17a ("kni: support MAC address change")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Jie Pan <panjie5@jd.com>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Reviewed-by: Rami Rosen <ramirose@gmail.com>
Applied, thanks
^ permalink raw reply [flat|nested] 9+ messages in thread