[PATCH 0/4] ARM: dts: renesas: Enable FDP1 devices

[PATCH 0/4] ARM: dts: renesas: Enable FDP1 devices

[Laurent Pinchart]

Hello,

This patch series adds the FDP1 devices for all applicable Gen2 platforms
(H2, M2W, M2N and E2). There's no rocket science involved, the devices have
no I/O pin and need no resource other than a memory range, a functional clock
and an interrupt.

Laurent Pinchart (4):
  ARM: dts: renesas: r8a7790: Add FDP1 instances
  ARM: dts: renesas: r8a7791: Add FDP1 instances
  ARM: dts: renesas: r8a7793: Add FDP1 instances
  ARM: dts: renesas: r8a7794: Add FDP1 instances

 arch/arm/boot/dts/r8a7790.dtsi | 27 +++++++++++++++++++++++++++
 arch/arm/boot/dts/r8a7791.dtsi | 18 ++++++++++++++++++
 arch/arm/boot/dts/r8a7793.dtsi | 18 ++++++++++++++++++
 arch/arm/boot/dts/r8a7794.dtsi |  9 +++++++++
 4 files changed, 72 insertions(+)

-- 
Regards,

Laurent Pinchart

[PATCH 1/4] ARM: dts: renesas: r8a7790: Add FDP1 instances

[Laurent Pinchart]

The r8a7790 has three FDP1 instances.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 arch/arm/boot/dts/r8a7790.dtsi | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
index e4367cecad18..9c527ddfde56 100644
--- a/arch/arm/boot/dts/r8a7790.dtsi
+++ b/arch/arm/boot/dts/r8a7790.dtsi
@@ -1606,6 +1606,33 @@
 			resets = <&cpg 128>;
 		};
 
+		fdp1@fe940000 {
+			compatible = "renesas,fdp1";
+			reg = <0 0xfe940000 0 0x2400>;
+			interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 119>;
+			power-domains = <&sysc R8A7790_PD_ALWAYS_ON>;
+			resets = <&cpg 119>;
+		};
+
+		fdp1@fe944000 {
+			compatible = "renesas,fdp1";
+			reg = <0 0xfe944000 0 0x2400>;
+			interrupts = <GIC_SPI 263 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 118>;
+			power-domains = <&sysc R8A7790_PD_ALWAYS_ON>;
+			resets = <&cpg 118>;
+		};
+
+		fdp1@fe948000 {
+			compatible = "renesas,fdp1";
+			reg = <0 0xfe948000 0 0x2400>;
+			interrupts = <GIC_SPI 264 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 117>;
+			power-domains = <&sysc R8A7790_PD_ALWAYS_ON>;
+			resets = <&cpg 117>;
+		};
+
 		vsp@fe938000 {
 			compatible = "renesas,vsp1";
 			reg = <0 0xfe938000 0 0x8000>;
-- 
Regards,

Laurent Pinchart

[PATCH 2/4] ARM: dts: renesas: r8a7791: Add FDP1 instances

[Laurent Pinchart]

The r8a7791 has two FDP1 instances.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 arch/arm/boot/dts/r8a7791.dtsi | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi
index f11dab71b03a..55b5a56da35e 100644
--- a/arch/arm/boot/dts/r8a7791.dtsi
+++ b/arch/arm/boot/dts/r8a7791.dtsi
@@ -1621,6 +1621,24 @@
 			resets = <&cpg 127>;
 		};
 
+		fdp1@fe940000 {
+			compatible = "renesas,fdp1";
+			reg = <0 0xfe940000 0 0x2400>;
+			interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 119>;
+			power-domains = <&sysc R8A7791_PD_ALWAYS_ON>;
+			resets = <&cpg 119>;
+		};
+
+		fdp1@fe944000 {
+			compatible = "renesas,fdp1";
+			reg = <0 0xfe944000 0 0x2400>;
+			interrupts = <GIC_SPI 263 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 118>;
+			power-domains = <&sysc R8A7791_PD_ALWAYS_ON>;
+			resets = <&cpg 118>;
+		};
+
 		jpu: jpeg-codec@fe980000 {
 			compatible = "renesas,jpu-r8a7791",
 				     "renesas,rcar-gen2-jpu";
-- 
Regards,

Laurent Pinchart

[PATCH 3/4] ARM: dts: renesas: r8a7793: Add FDP1 instances

[Laurent Pinchart]

The r8a7793 has two FDP1 instances.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 arch/arm/boot/dts/r8a7793.dtsi | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7793.dtsi b/arch/arm/boot/dts/r8a7793.dtsi
index f9c5a557107d..61c58029e03e 100644
--- a/arch/arm/boot/dts/r8a7793.dtsi
+++ b/arch/arm/boot/dts/r8a7793.dtsi
@@ -1290,6 +1290,24 @@
 			resets = <&cpg 408>;
 		};
 
+		fdp1@fe940000 {
+			compatible = "renesas,fdp1";
+			reg = <0 0xfe940000 0 0x2400>;
+			interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 119>;
+			power-domains = <&sysc R8A7793_PD_ALWAYS_ON>;
+			resets = <&cpg 119>;
+		};
+
+		fdp1@fe944000 {
+			compatible = "renesas,fdp1";
+			reg = <0 0xfe944000 0 0x2400>;
+			interrupts = <GIC_SPI 263 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 118>;
+			power-domains = <&sysc R8A7793_PD_ALWAYS_ON>;
+			resets = <&cpg 118>;
+		};
+
 		du: display@feb00000 {
 			compatible = "renesas,du-r8a7793";
 			reg = <0 0xfeb00000 0 0x40000>,
-- 
Regards,

Laurent Pinchart

[PATCH 4/4] ARM: dts: renesas: r8a7794: Add FDP1 instances

[Laurent Pinchart]

The r8a7794 has one FDP1 instance.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 arch/arm/boot/dts/r8a7794.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7794.dtsi b/arch/arm/boot/dts/r8a7794.dtsi
index d588efa6aeaa..56f5fa6a2c0f 100644
--- a/arch/arm/boot/dts/r8a7794.dtsi
+++ b/arch/arm/boot/dts/r8a7794.dtsi
@@ -1323,6 +1323,15 @@
 			resets = <&cpg 128>;
 		};
 
+		fdp1@fe940000 {
+			compatible = "renesas,fdp1";
+			reg = <0 0xfe940000 0 0x2400>;
+			interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 119>;
+			power-domains = <&sysc R8A7794_PD_ALWAYS_ON>;
+			resets = <&cpg 119>;
+		};
+
 		du: display@feb00000 {
 			compatible = "renesas,du-r8a7794";
 			reg = <0 0xfeb00000 0 0x40000>;
-- 
Regards,

Laurent Pinchart

Re: [PATCH 2/4] ARM: dts: renesas: r8a7791: Add FDP1 instances

[Simon Horman]

On Sun, Apr 22, 2018 at 01:35:26PM +0300, Laurent Pinchart wrote:
> The r8a7791 has two FDP1 instances.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Thanks, applied.

Re: [PATCH 3/4] ARM: dts: renesas: r8a7793: Add FDP1 instances

[Simon Horman]

On Sun, Apr 22, 2018 at 01:35:27PM +0300, Laurent Pinchart wrote:
> The r8a7793 has two FDP1 instances.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Thanks, applied.

Re: [PATCH 4/4] ARM: dts: renesas: r8a7794: Add FDP1 instances

[Simon Horman]

On Sun, Apr 22, 2018 at 01:35:28PM +0300, Laurent Pinchart wrote:
> The r8a7794 has one FDP1 instance.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Thanks, applied.

Re: [PATCH 1/4] ARM: dts: renesas: r8a7790: Add FDP1 instances

[Simon Horman]

On Sun, Apr 22, 2018 at 01:35:25PM +0300, Laurent Pinchart wrote:
> The r8a7790 has three FDP1 instances.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Hi Laurent,

could you rearrange these nodes so they preserve the sorting
of sub-nodes of the soc node by bus address. The other patches
in the series seem fine in this regards and I have applied them.

Re: [PATCH 1/4] ARM: dts: renesas: r8a7790: Add FDP1 instances

[Geert Uytterhoeven]

On Sun, Apr 22, 2018 at 12:35 PM, Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
> The r8a7790 has three FDP1 instances.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> --- a/arch/arm/boot/dts/r8a7790.dtsi
> +++ b/arch/arm/boot/dts/r8a7790.dtsi
> @@ -1606,6 +1606,33 @@
>                         resets = <&cpg 128>;
>                 };
>
> +               fdp1@fe940000 {

Just wondering: should we go for "display-processor@foo"?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 2/4] ARM: dts: renesas: r8a7791: Add FDP1 instances

[Geert Uytterhoeven]

On Sun, Apr 22, 2018 at 12:35 PM, Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
> The r8a7791 has two FDP1 instances.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 3/4] ARM: dts: renesas: r8a7793: Add FDP1 instances

[Geert Uytterhoeven]

On Sun, Apr 22, 2018 at 12:35 PM, Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
> The r8a7793 has two FDP1 instances.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 4/4] ARM: dts: renesas: r8a7794: Add FDP1 instances

[Geert Uytterhoeven]

On Sun, Apr 22, 2018 at 12:35 PM, Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
> The r8a7794 has one FDP1 instance.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/4] ARM: dts: renesas: r8a7790: Add FDP1 instances

[Simon Horman]

On Tue, Apr 24, 2018 at 05:01:29PM +0200, Geert Uytterhoeven wrote:
> On Sun, Apr 22, 2018 at 12:35 PM, Laurent Pinchart
> <laurent.pinchart+renesas@ideasonboard.com> wrote:
> > The r8a7790 has three FDP1 instances.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks, applied.

> 
> > --- a/arch/arm/boot/dts/r8a7790.dtsi
> > +++ b/arch/arm/boot/dts/r8a7790.dtsi
> > @@ -1606,6 +1606,33 @@
> >                         resets = <&cpg 128>;
> >                 };
> >
> > +               fdp1@fe940000 {
> 
> Just wondering: should we go for "display-processor@foo"?
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 

Re: [PATCH 2/4] ARM: dts: renesas: r8a7791: Add FDP1 instances

[Simon Horman]

On Tue, Apr 24, 2018 at 05:01:52PM +0200, Geert Uytterhoeven wrote:
> On Sun, Apr 22, 2018 at 12:35 PM, Laurent Pinchart
> <laurent.pinchart+renesas@ideasonboard.com> wrote:
> > The r8a7791 has two FDP1 instances.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks, tag added.

Re: [PATCH 3/4] ARM: dts: renesas: r8a7793: Add FDP1 instances

[Simon Horman]

On Tue, Apr 24, 2018 at 05:02:10PM +0200, Geert Uytterhoeven wrote:
> On Sun, Apr 22, 2018 at 12:35 PM, Laurent Pinchart
> <laurent.pinchart+renesas@ideasonboard.com> wrote:
> > The r8a7793 has two FDP1 instances.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks, tag added.

Re: [PATCH 4/4] ARM: dts: renesas: r8a7794: Add FDP1 instances

[Simon Horman]

On Tue, Apr 24, 2018 at 05:02:26PM +0200, Geert Uytterhoeven wrote:
> On Sun, Apr 22, 2018 at 12:35 PM, Laurent Pinchart
> <laurent.pinchart+renesas@ideasonboard.com> wrote:
> > The r8a7794 has one FDP1 instance.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks, tag added.

Re: [PATCH 1/4] ARM: dts: renesas: r8a7790: Add FDP1 instances

[Laurent Pinchart]

Hi Simon,

On Monday, 23 April 2018 14:07:14 EEST Simon Horman wrote:
> On Sun, Apr 22, 2018 at 01:35:25PM +0300, Laurent Pinchart wrote:
> > The r8a7790 has three FDP1 instances.
> > 
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> 
> Hi Laurent,
> 
> could you rearrange these nodes so they preserve the sorting
> of sub-nodes of the soc node by bus address. The other patches
> in the series seem fine in this regards and I have applied them.

I would have if you hadn't merged the patch already :-) Would you like me to 
submit a follow-up patch ?

-- 
Regards,

Laurent Pinchart

Re: [PATCH 1/4] ARM: dts: renesas: r8a7790: Add FDP1 instances

[Simon Horman]

On Thu, Apr 26, 2018 at 12:29:47PM +0300, Laurent Pinchart wrote:
> Hi Simon,
> 
> On Monday, 23 April 2018 14:07:14 EEST Simon Horman wrote:
> > On Sun, Apr 22, 2018 at 01:35:25PM +0300, Laurent Pinchart wrote:
> > > The r8a7790 has three FDP1 instances.
> > > 
> > > Signed-off-by: Laurent Pinchart
> > > <laurent.pinchart+renesas@ideasonboard.com>
> > 
> > Hi Laurent,
> > 
> > could you rearrange these nodes so they preserve the sorting
> > of sub-nodes of the soc node by bus address. The other patches
> > in the series seem fine in this regards and I have applied them.
> 
> I would have if you hadn't merged the patch already :-) Would you like me to 
> submit a follow-up patch ?

Sorry about that. Yes, please submit a follow-up patch.

[PATCH] ARM: dts: r8a7790: Fix sort order of VSP1/FDP1 nodes

[Kieran Bingham]

Commit 5d3b50d3c04d ("ARM: dts: renesas: r8a7790: Add FDP1 instances")
introduced the FDP1 for the r8a7790, but broke the sort ordering of the
device tree nodes.

Move the last VSP up to it's peers to correct the ordering.

Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
 arch/arm/boot/dts/r8a7790.dtsi | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
index c244aae7a026..b66a18af28f1 100644
--- a/arch/arm/boot/dts/r8a7790.dtsi
+++ b/arch/arm/boot/dts/r8a7790.dtsi
@@ -1616,6 +1616,15 @@
 			resets = <&cpg 128>;
 		};
 
+		vsp@fe938000 {
+			compatible = "renesas,vsp1";
+			reg = <0 0xfe938000 0 0x8000>;
+			interrupts = <GIC_SPI 247 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 127>;
+			power-domains = <&sysc R8A7790_PD_ALWAYS_ON>;
+			resets = <&cpg 127>;
+		};
+
 		fdp1@fe940000 {
 			compatible = "renesas,fdp1";
 			reg = <0 0xfe940000 0 0x2400>;
@@ -1643,15 +1652,6 @@
 			resets = <&cpg 117>;
 		};
 
-		vsp@fe938000 {
-			compatible = "renesas,vsp1";
-			reg = <0 0xfe938000 0 0x8000>;
-			interrupts = <GIC_SPI 247 IRQ_TYPE_LEVEL_HIGH>;
-			clocks = <&cpg CPG_MOD 127>;
-			power-domains = <&sysc R8A7790_PD_ALWAYS_ON>;
-			resets = <&cpg 127>;
-		};
-
 		jpu: jpeg-codec@fe980000 {
 			compatible = "renesas,jpu-r8a7790",
 				     "renesas,rcar-gen2-jpu";
-- 
2.17.0

Re: [PATCH] ARM: dts: r8a7790: Fix sort order of VSP1/FDP1 nodes

[Laurent Pinchart]

Hi Kieran,

Thank you for the patch.

On Monday, 30 April 2018 13:53:25 EEST Kieran Bingham wrote:
> Commit 5d3b50d3c04d ("ARM: dts: renesas: r8a7790: Add FDP1 instances")
> introduced the FDP1 for the r8a7790, but broke the sort ordering of the
> device tree nodes.
> 
> Move the last VSP up to it's peers to correct the ordering.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  arch/arm/boot/dts/r8a7790.dtsi | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> index c244aae7a026..b66a18af28f1 100644
> --- a/arch/arm/boot/dts/r8a7790.dtsi
> +++ b/arch/arm/boot/dts/r8a7790.dtsi
> @@ -1616,6 +1616,15 @@
>  			resets = <&cpg 128>;
>  		};
> 
> +		vsp@fe938000 {
> +			compatible = "renesas,vsp1";
> +			reg = <0 0xfe938000 0 0x8000>;
> +			interrupts = <GIC_SPI 247 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&cpg CPG_MOD 127>;
> +			power-domains = <&sysc R8A7790_PD_ALWAYS_ON>;
> +			resets = <&cpg 127>;
> +		};
> +
>  		fdp1@fe940000 {
>  			compatible = "renesas,fdp1";
>  			reg = <0 0xfe940000 0 0x2400>;
> @@ -1643,15 +1652,6 @@
>  			resets = <&cpg 117>;
>  		};
> 
> -		vsp@fe938000 {
> -			compatible = "renesas,vsp1";
> -			reg = <0 0xfe938000 0 0x8000>;
> -			interrupts = <GIC_SPI 247 IRQ_TYPE_LEVEL_HIGH>;
> -			clocks = <&cpg CPG_MOD 127>;
> -			power-domains = <&sysc R8A7790_PD_ALWAYS_ON>;
> -			resets = <&cpg 127>;
> -		};
> -
>  		jpu: jpeg-codec@fe980000 {
>  			compatible = "renesas,jpu-r8a7790",
>  				     "renesas,rcar-gen2-jpu";


-- 
Regards,

Laurent Pinchart

Re: [PATCH] ARM: dts: r8a7790: Fix sort order of VSP1/FDP1 nodes

[Simon Horman]

On Mon, Apr 30, 2018 at 02:25:33PM +0300, Laurent Pinchart wrote:
> Hi Kieran,
> 
> Thank you for the patch.
> 
> On Monday, 30 April 2018 13:53:25 EEST Kieran Bingham wrote:
> > Commit 5d3b50d3c04d ("ARM: dts: renesas: r8a7790: Add FDP1 instances")
> > introduced the FDP1 for the r8a7790, but broke the sort ordering of the
> > device tree nodes.
> > 
> > Move the last VSP up to it's peers to correct the ordering.
> > 
> > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> 
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Thanks, applied.