From: Martin Kepplinger <martin.kepplinger@puri.sm> To: Pavel Machek <pavel@ucw.cz> Cc: robh@kernel.org, kernel@puri.sm, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, mchehab@kernel.org, Anson.Huang@nxp.com, agx@sigxcpu.org, angus@akkea.ca, broonie@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Daniel Baluta <daniel.baluta@nxp.com> Subject: Re: [PATCH v4 1/3] arm64: dts: Add a device tree for the Librem 5 phone Date: Tue, 28 Jul 2020 12:43:38 +0200 [thread overview] Message-ID: <3555a1ae-aeaf-196d-18b4-8615f90c854a@puri.sm> (raw) In-Reply-To: <20200727120240.bnivbjbfkjouucg4@duo.ucw.cz> On 27.07.20 14:02, Pavel Machek wrote: > Hi! > >> + pwmleds { >> + compatible = "pwm-leds"; >> + >> + blue { >> + label = "blue:status"; >> + max-brightness = <248>; >> + pwms = <&pwm2 0 50000>; >> + }; >> + >> + green { >> + label = "green:status"; >> + max-brightness = <248>; >> + pwms = <&pwm4 0 50000>; >> + }; >> + >> + red { >> + label = "red:status"; >> + max-brightness = <248>; >> + pwms = <&pwm3 0 50000>; >> + }; >> + }; > > Can we postpone this? I guess we can. It's indeed easier to add that interface once we know we can use a stable one. > > 1) green:status is not really name used anywhere else > > 2) this should really use multicolor framework, as it is single LED, > not three of them. > > Fixing that in future will be hard :-(. > Pavel > > thanks, martin
WARNING: multiple messages have this Message-ID (diff)
From: Martin Kepplinger <martin.kepplinger@puri.sm> To: Pavel Machek <pavel@ucw.cz> Cc: Daniel Baluta <daniel.baluta@nxp.com>, robh@kernel.org, kernel@puri.sm, Anson.Huang@nxp.com, devicetree@vger.kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, angus@akkea.ca, linux-kernel@vger.kernel.org, broonie@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, mchehab@kernel.org, festevam@gmail.com, agx@sigxcpu.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 1/3] arm64: dts: Add a device tree for the Librem 5 phone Date: Tue, 28 Jul 2020 12:43:38 +0200 [thread overview] Message-ID: <3555a1ae-aeaf-196d-18b4-8615f90c854a@puri.sm> (raw) In-Reply-To: <20200727120240.bnivbjbfkjouucg4@duo.ucw.cz> On 27.07.20 14:02, Pavel Machek wrote: > Hi! > >> + pwmleds { >> + compatible = "pwm-leds"; >> + >> + blue { >> + label = "blue:status"; >> + max-brightness = <248>; >> + pwms = <&pwm2 0 50000>; >> + }; >> + >> + green { >> + label = "green:status"; >> + max-brightness = <248>; >> + pwms = <&pwm4 0 50000>; >> + }; >> + >> + red { >> + label = "red:status"; >> + max-brightness = <248>; >> + pwms = <&pwm3 0 50000>; >> + }; >> + }; > > Can we postpone this? I guess we can. It's indeed easier to add that interface once we know we can use a stable one. > > 1) green:status is not really name used anywhere else > > 2) this should really use multicolor framework, as it is single LED, > not three of them. > > Fixing that in future will be hard :-(. > Pavel > > thanks, martin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-28 10:43 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-21 15:32 [PATCH v4 1/3] arm64: dts: Add a device tree for the Librem 5 phone Martin Kepplinger 2020-07-21 15:32 ` Martin Kepplinger 2020-07-21 15:32 ` [PATCH v4 2/3] MAINTAINERS: Add Purism Librem 5 section to the list Martin Kepplinger 2020-07-21 15:32 ` Martin Kepplinger 2020-07-21 15:32 ` [PATCH v4 3/3] dt-bindings: arm: fsl: Add the librem 5 phone Martin Kepplinger 2020-07-21 15:32 ` Martin Kepplinger 2020-07-23 17:09 ` Rob Herring 2020-07-23 17:09 ` Rob Herring 2020-07-27 12:02 ` [PATCH v4 1/3] arm64: dts: Add a device tree for the Librem " Pavel Machek 2020-07-27 12:02 ` Pavel Machek 2020-07-28 10:43 ` Martin Kepplinger [this message] 2020-07-28 10:43 ` Martin Kepplinger
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3555a1ae-aeaf-196d-18b4-8615f90c854a@puri.sm \ --to=martin.kepplinger@puri.sm \ --cc=Anson.Huang@nxp.com \ --cc=agx@sigxcpu.org \ --cc=angus@akkea.ca \ --cc=broonie@kernel.org \ --cc=daniel.baluta@nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=kernel@puri.sm \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mchehab@kernel.org \ --cc=pavel@ucw.cz \ --cc=robh@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.