From: Pavel Machek <pavel@ucw.cz>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: robh@kernel.org, kernel@puri.sm, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com, mchehab@kernel.org,
Anson.Huang@nxp.com, agx@sigxcpu.org, angus@akkea.ca,
broonie@kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Daniel Baluta <daniel.baluta@nxp.com>
Subject: Re: [PATCH v4 1/3] arm64: dts: Add a device tree for the Librem 5 phone
Date: Mon, 27 Jul 2020 14:02:40 +0200 [thread overview]
Message-ID: <20200727120240.bnivbjbfkjouucg4@duo.ucw.cz> (raw)
In-Reply-To: <20200721153225.7593-1-martin.kepplinger@puri.sm>
[-- Attachment #1: Type: text/plain, Size: 799 bytes --]
Hi!
> + pwmleds {
> + compatible = "pwm-leds";
> +
> + blue {
> + label = "blue:status";
> + max-brightness = <248>;
> + pwms = <&pwm2 0 50000>;
> + };
> +
> + green {
> + label = "green:status";
> + max-brightness = <248>;
> + pwms = <&pwm4 0 50000>;
> + };
> +
> + red {
> + label = "red:status";
> + max-brightness = <248>;
> + pwms = <&pwm3 0 50000>;
> + };
> + };
Can we postpone this?
1) green:status is not really name used anywhere else
2) this should really use multicolor framework, as it is single LED,
not three of them.
Fixing that in future will be hard :-(.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: Daniel Baluta <daniel.baluta@nxp.com>,
robh@kernel.org, kernel@puri.sm, Anson.Huang@nxp.com,
devicetree@vger.kernel.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, angus@akkea.ca,
linux-kernel@vger.kernel.org, broonie@kernel.org,
linux-imx@nxp.com, kernel@pengutronix.de, mchehab@kernel.org,
festevam@gmail.com, agx@sigxcpu.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 1/3] arm64: dts: Add a device tree for the Librem 5 phone
Date: Mon, 27 Jul 2020 14:02:40 +0200 [thread overview]
Message-ID: <20200727120240.bnivbjbfkjouucg4@duo.ucw.cz> (raw)
In-Reply-To: <20200721153225.7593-1-martin.kepplinger@puri.sm>
[-- Attachment #1.1: Type: text/plain, Size: 799 bytes --]
Hi!
> + pwmleds {
> + compatible = "pwm-leds";
> +
> + blue {
> + label = "blue:status";
> + max-brightness = <248>;
> + pwms = <&pwm2 0 50000>;
> + };
> +
> + green {
> + label = "green:status";
> + max-brightness = <248>;
> + pwms = <&pwm4 0 50000>;
> + };
> +
> + red {
> + label = "red:status";
> + max-brightness = <248>;
> + pwms = <&pwm3 0 50000>;
> + };
> + };
Can we postpone this?
1) green:status is not really name used anywhere else
2) this should really use multicolor framework, as it is single LED,
not three of them.
Fixing that in future will be hard :-(.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-27 12:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 15:32 [PATCH v4 1/3] arm64: dts: Add a device tree for the Librem 5 phone Martin Kepplinger
2020-07-21 15:32 ` Martin Kepplinger
2020-07-21 15:32 ` [PATCH v4 2/3] MAINTAINERS: Add Purism Librem 5 section to the list Martin Kepplinger
2020-07-21 15:32 ` Martin Kepplinger
2020-07-21 15:32 ` [PATCH v4 3/3] dt-bindings: arm: fsl: Add the librem 5 phone Martin Kepplinger
2020-07-21 15:32 ` Martin Kepplinger
2020-07-23 17:09 ` Rob Herring
2020-07-23 17:09 ` Rob Herring
2020-07-27 12:02 ` Pavel Machek [this message]
2020-07-27 12:02 ` [PATCH v4 1/3] arm64: dts: Add a device tree for the Librem " Pavel Machek
2020-07-28 10:43 ` Martin Kepplinger
2020-07-28 10:43 ` Martin Kepplinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727120240.bnivbjbfkjouucg4@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=Anson.Huang@nxp.com \
--cc=agx@sigxcpu.org \
--cc=angus@akkea.ca \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kernel@puri.sm \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.kepplinger@puri.sm \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.