From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: Andrew Lunn <andrew@lunn.ch>,
Aryan Srivastava <Aryan.Srivastava@alliedtelesis.co.nz>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"gregory.clement@bootlin.com" <gregory.clement@bootlin.com>,
"sebastian.hesselbarth@gmail.com"
<sebastian.hesselbarth@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] ARM: dts: mvebu: Add device tree for ATL-x530 Board
Date: Mon, 30 Nov 2020 23:57:59 +0000 [thread overview]
Message-ID: <3570cb6d-44e0-3ab5-b464-a013ba1007b1@alliedtelesis.co.nz> (raw)
In-Reply-To: <20201130230359.GH2073444@lunn.ch>
On 1/12/20 12:03 pm, Andrew Lunn wrote:
> On Tue, Dec 01, 2020 at 11:35:07AM +1300, Aryan Srivastava wrote:
>> Add device tree file for x530 board. This has an Armada 385 SoC. Has
>> NAND-flash for user storage and SPI for booting. Covers majority of x530
>> and GS980MX variants.
> Hi Aryan
>
> What exactly does that mean, it covers most variants?
We were trying to avoid the patch submission becoming marketing spam and
have probably been a little too vague.
Between the x530, x530L and GS980MX there are 24 different models. The
differences between them are in the type and number of switch ASICs, the
number of PSUs and whether PoE is supported. But the CPU block is
largely the same between models.
> I'm just wondering if this should be a .dtsi file, and then each
> variant has a .dts file specific to it?
This is what we've done in our kernel fork. But for upstreaming we
wanted to start slow and maybe move things into one or more common .dtsi
files if/when needed (in particular there are some models in development
now that use different i2c mux and hwmon chips).
> Or is the hardware itself the
> same, and only the software varies between the variants?
Kind of both. This patch submission basically represents the common
items among all the (currently shipping) variants.
WARNING: multiple messages have this Message-ID (diff)
From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: Andrew Lunn <andrew@lunn.ch>,
Aryan Srivastava <Aryan.Srivastava@alliedtelesis.co.nz>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"gregory.clement@bootlin.com" <gregory.clement@bootlin.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"sebastian.hesselbarth@gmail.com"
<sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v2] ARM: dts: mvebu: Add device tree for ATL-x530 Board
Date: Mon, 30 Nov 2020 23:57:59 +0000 [thread overview]
Message-ID: <3570cb6d-44e0-3ab5-b464-a013ba1007b1@alliedtelesis.co.nz> (raw)
In-Reply-To: <20201130230359.GH2073444@lunn.ch>
On 1/12/20 12:03 pm, Andrew Lunn wrote:
> On Tue, Dec 01, 2020 at 11:35:07AM +1300, Aryan Srivastava wrote:
>> Add device tree file for x530 board. This has an Armada 385 SoC. Has
>> NAND-flash for user storage and SPI for booting. Covers majority of x530
>> and GS980MX variants.
> Hi Aryan
>
> What exactly does that mean, it covers most variants?
We were trying to avoid the patch submission becoming marketing spam and
have probably been a little too vague.
Between the x530, x530L and GS980MX there are 24 different models. The
differences between them are in the type and number of switch ASICs, the
number of PSUs and whether PoE is supported. But the CPU block is
largely the same between models.
> I'm just wondering if this should be a .dtsi file, and then each
> variant has a .dts file specific to it?
This is what we've done in our kernel fork. But for upstreaming we
wanted to start slow and maybe move things into one or more common .dtsi
files if/when needed (in particular there are some models in development
now that use different i2c mux and hwmon chips).
> Or is the hardware itself the
> same, and only the software varies between the variants?
Kind of both. This patch submission basically represents the common
items among all the (currently shipping) variants.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-30 23:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 22:35 [PATCH v2] ARM: dts: mvebu: Add device tree for ATL-x530 Board Aryan Srivastava
2020-11-30 22:35 ` Aryan Srivastava
2020-11-30 23:03 ` Andrew Lunn
2020-11-30 23:03 ` Andrew Lunn
2020-11-30 23:57 ` Chris Packham [this message]
2020-11-30 23:57 ` Chris Packham
2020-12-01 18:22 ` Andrew Lunn
2020-12-01 18:22 ` Andrew Lunn
2021-04-07 20:40 ` Gregory CLEMENT
2021-04-07 20:40 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3570cb6d-44e0-3ab5-b464-a013ba1007b1@alliedtelesis.co.nz \
--to=chris.packham@alliedtelesis.co.nz \
--cc=Aryan.Srivastava@alliedtelesis.co.nz \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.