* [PATCH] Immediately append TCLIBCAPPEND to TMPDIR in defaultsetup.conf
@ 2011-08-03 21:54 Daniel Lazzari
2011-08-05 4:59 ` Chris Larson
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Lazzari @ 2011-08-03 21:54 UTC (permalink / raw)
To: 'openembedded-core@lists.openembedded.org'
Immediately append TCLIBCAPPEND to TMPDIR in defaultsetup.conf
instead of lazily appending it with _append. This fixes a bug where
the wrong cache was cleared when BB_SRCREV_POLICY = "clear".
Signed-off-by: Daniel Lazzari Jr <dlazzari@leapfrog.com>
---
meta/conf/distro/defaultsetup.conf | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/meta/conf/distro/defaultsetup.conf b/meta/conf/distro/defaultsetup.conf
index 072f03c..951e5be 100644
--- a/meta/conf/distro/defaultsetup.conf
+++ b/meta/conf/distro/defaultsetup.conf
@@ -14,7 +14,7 @@ require conf/distro/include/tclibc-${TCLIBC}.inc
# Allow single libc distros to disable this code
TCLIBCAPPEND ?= "-${TCLIBC}"
-TMPDIR_append = "${TCLIBCAPPEND}"
+TMPDIR := "${TMPDIR}${TCLIBCAPPEND}"
CACHE = "${TMPDIR}/cache/${TCMODE}-${TCLIBC}${@['', '/' + str(bb.data.getVar('MACHINE', d, 1))][bool(bb.data.getVar('MACHINE', d, 1))]}${@['', '/' + str(bb.data.getVar('SDKMACHINE', d, 1))][bool(bb.data.getVar('SDKMACHINE', d, 1))]}"
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Immediately append TCLIBCAPPEND to TMPDIR in defaultsetup.conf
2011-08-03 21:54 [PATCH] Immediately append TCLIBCAPPEND to TMPDIR in defaultsetup.conf Daniel Lazzari
@ 2011-08-05 4:59 ` Chris Larson
2011-08-05 17:19 ` Khem Raj
0 siblings, 1 reply; 3+ messages in thread
From: Chris Larson @ 2011-08-05 4:59 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Wed, Aug 3, 2011 at 2:54 PM, Daniel Lazzari <dlazzari@leapfrog.com> wrote:
> Immediately append TCLIBCAPPEND to TMPDIR in defaultsetup.conf
> instead of lazily appending it with _append. This fixes a bug where
> the wrong cache was cleared when BB_SRCREV_POLICY = "clear".
>
>
> Signed-off-by: Daniel Lazzari Jr <dlazzari@leapfrog.com>
> ---
> meta/conf/distro/defaultsetup.conf | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/conf/distro/defaultsetup.conf b/meta/conf/distro/defaultsetup.conf
> index 072f03c..951e5be 100644
> --- a/meta/conf/distro/defaultsetup.conf
> +++ b/meta/conf/distro/defaultsetup.conf
> @@ -14,7 +14,7 @@ require conf/distro/include/tclibc-${TCLIBC}.inc
>
> # Allow single libc distros to disable this code
> TCLIBCAPPEND ?= "-${TCLIBC}"
> -TMPDIR_append = "${TCLIBCAPPEND}"
> +TMPDIR := "${TMPDIR}${TCLIBCAPPEND}"
>
> CACHE = "${TMPDIR}/cache/${TCMODE}-${TCLIBC}${@['', '/' + str(bb.data.getVar('MACHINE', d, 1))][bool(bb.data.getVar('MACHINE', d, 1))]}${@['', '/' + str(bb.data.getVar('SDKMACHINE', d, 1))][bool(bb.data.getVar('SDKMACHINE', d, 1))]}"
If all you want is an immediate concatenation, you can use .=. Using
:= like this forces an early expansion of TMPDIR unnecessarily, as far
as I can tell.
--
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Immediately append TCLIBCAPPEND to TMPDIR in defaultsetup.conf
2011-08-05 4:59 ` Chris Larson
@ 2011-08-05 17:19 ` Khem Raj
0 siblings, 0 replies; 3+ messages in thread
From: Khem Raj @ 2011-08-05 17:19 UTC (permalink / raw)
To: openembedded-core
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 08/04/2011 09:59 PM, Chris Larson wrote:
> On Wed, Aug 3, 2011 at 2:54 PM, Daniel Lazzari
> <dlazzari@leapfrog.com> wrote:
>> Immediately append TCLIBCAPPEND to TMPDIR in defaultsetup.conf
>> instead of lazily appending it with _append. This fixes a bug
>> where the wrong cache was cleared when BB_SRCREV_POLICY = "clear".
>>
>>
>> Signed-off-by: Daniel Lazzari Jr <dlazzari@leapfrog.com> ---
>> meta/conf/distro/defaultsetup.conf | 2 +- 1 files changed, 1
>> insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/conf/distro/defaultsetup.conf
>> b/meta/conf/distro/defaultsetup.conf index 072f03c..951e5be 100644
>> --- a/meta/conf/distro/defaultsetup.conf +++
>> b/meta/conf/distro/defaultsetup.conf @@ -14,7 +14,7 @@ require
>> conf/distro/include/tclibc-${TCLIBC}.inc
>>
>> # Allow single libc distros to disable this code TCLIBCAPPEND ?=
>> "-${TCLIBC}" -TMPDIR_append = "${TCLIBCAPPEND}" +TMPDIR :=
>> "${TMPDIR}${TCLIBCAPPEND}"
>>
>> CACHE = "${TMPDIR}/cache/${TCMODE}-${TCLIBC}${@['', '/' +
>> str(bb.data.getVar('MACHINE', d,
>> 1))][bool(bb.data.getVar('MACHINE', d, 1))]}${@['', '/' +
>> str(bb.data.getVar('SDKMACHINE', d,
>> 1))][bool(bb.data.getVar('SDKMACHINE', d, 1))]}"
>
> If all you want is an immediate concatenation, you can use .=. Using
> := like this forces an early expansion of TMPDIR unnecessarily, as
> far as I can tell.
I think you mean TMPDIR .= "${TCLIBCAPPEND}" ?
I think that will work too. I have tested the original patch too and it
has worked ok but .= would be better I think let me try that as well.
- --
- -Khem
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iEYEARECAAYFAk48Jh0ACgkQuwUzVZGdMxT+FwCfcQ38C1x6DlSYtnLIlC0ov2aY
ZHYAn3SfzV483FUFCVdTZX67MJQQBZdw
=bUgM
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-08-05 17:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-03 21:54 [PATCH] Immediately append TCLIBCAPPEND to TMPDIR in defaultsetup.conf Daniel Lazzari
2011-08-05 4:59 ` Chris Larson
2011-08-05 17:19 ` Khem Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.