[PATCH v2] staging: r8188eu: Fix misspelling in comment

[PATCH v2] staging: r8188eu: Fix misspelling in comment

[hallblazzar]

As format check raised by scripts/checkpatch.pl, comment in the rtw_ap.c
looks misspelled by accident. Help fix it.

The original error is as below shows:

CHECK: 'followign' may be misspelled - perhaps 'following'?
+Set to 0 (HT pure) under the followign conditions

Signed-off-by: Siou-Jhih, Guo <hallblazzar@gmail.com>
---
 drivers/staging/r8188eu/core/rtw_ap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/r8188eu/core/rtw_ap.c b/drivers/staging/r8188eu/core/rtw_ap.c
index 94e02aad96b7..205168f960f6 100644
--- a/drivers/staging/r8188eu/core/rtw_ap.c
+++ b/drivers/staging/r8188eu/core/rtw_ap.c
@@ -744,7 +744,7 @@ void update_beacon(struct adapter *padapter, u8 ie_id, u8 *oui, u8 tx)
 
 /*
 op_mode
-Set to 0 (HT pure) under the followign conditions
+Set to 0 (HT pure) under the following conditions
     - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or
     - all STAs in the BSS are 20 MHz HT in 20 MHz BSS
 Set to 1 (HT non-member protection) if there may be non-HT STAs
-- 
2.25.1

Re: [PATCH v2] staging: r8188eu: Fix misspelling in comment

[Greg Kroah-Hartman]

On Wed, Sep 29, 2021 at 12:29:01PM +0100, hallblazzar wrote:
> As format check raised by scripts/checkpatch.pl, comment in the rtw_ap.c
> looks misspelled by accident. Help fix it.
> 
> The original error is as below shows:
> 
> CHECK: 'followign' may be misspelled - perhaps 'following'?
> +Set to 0 (HT pure) under the followign conditions
> 
> Signed-off-by: Siou-Jhih, Guo <hallblazzar@gmail.com>

This does not match with your "From" line in your email header :(

> ---
>  drivers/staging/r8188eu/core/rtw_ap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

What changed from v1?  That always has to go below the --- line as per
the documentation, right?

Please fix up and send a v3.

thanks,

greg k-h

Re: [PATCH v2] staging: r8188eu: Fix misspelling in comment

[Siou-Jhih, Guo]

On 05/10/2021 11:29, Greg Kroah-Hartman wrote:
> On Wed, Sep 29, 2021 at 12:29:01PM +0100, hallblazzar wrote:
>> As format check raised by scripts/checkpatch.pl, comment in the rtw_ap.c
>> looks misspelled by accident. Help fix it.
>>
>> The original error is as below shows:
>>
>> CHECK: 'followign' may be misspelled - perhaps 'following'?
>> +Set to 0 (HT pure) under the followign conditions
>>
>> Signed-off-by: Siou-Jhih, Guo <hallblazzar@gmail.com>
>
> This does not match with your "From" line in your email header :(
>
>> ---
>>  drivers/staging/r8188eu/core/rtw_ap.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> What changed from v1?  That always has to go below the --- line as per
> the documentation, right?
>
> Please fix up and send a v3.
>
> thanks,
>

> greg k-h

Hello Greg,

Really thankful for your time and point those issues out. I've fixed
the issues and re-sent v3 patch

  [PATCH v2] staging: r8188eu: Fix misspelling in comment   

If anything should I additionally aware, I'd like to fix them.

Regards,
Bill G.

Re: [PATCH v2] staging: r8188eu: Fix misspelling in comment

[Joe Perches]

On Tue, 2021-10-05 at 22:16 +0100, Siou-Jhih, Guo wrote:
> If anything should I additionally aware, I'd like to fix them.

Maybe fix these too?

$ git grep -w -i -P -n 'issuign|fittign|settign|enablign|followign|chargign|beign|startign|accordign|runnign'
arch/arm/mach-s3c/sleep-s3c64xx.S:33:    * requires to get the kernel runnign again. This code expects to be
drivers/crypto/ccree/cc_driver.c:278:   /* AXI interrupt config are obsoleted startign at cc7x3 */
drivers/hid/hid-thrustmaster.c:80: * beign conducted yet. The position and meaning of fields are a
drivers/net/ethernet/chelsio/cxgb4/t4fw_api.h:809: * our own HELLO may get lost if it happens right as the MASTER is issuign a
drivers/net/ethernet/qlogic/qede/qede_filter.c:2029:    /* Translate the flow specification into something fittign our DB */
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c:1158: * Overview:   88E change all channel tx power accordign to flag.
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c:1837: * Overview:   88E change all channel tx power accordign to flag.
drivers/power/supply/ab8500_charger.c:1325: * ab8500_charger_led_en() - turn on/off chargign led
drivers/power/supply/ab8500_charger.c:1327: * @on:              flag to turn on/off the chargign led
drivers/spi/spi-tegra20-slink.c:543:            /* HW need small delay after settign Packed mode */
drivers/staging/media/atomisp/pci/runtime/bufq/src/bufq.c:412:   * by some test apps. Enablign logging here floods the log
drivers/staging/media/atomisp/pci/runtime/bufq/src/bufq.c:434:   * by some test apps. Enablign logging here floods the log
drivers/staging/r8188eu/core/rtw_ap.c:747:Set to 0 (HT pure) under the followign conditions
drivers/staging/r8188eu/hal/HalPhyRf_8188e.c:72: * Overview:    88E change all channel tx power accordign to flag.
drivers/thermal/tegra/soctherm.c:844:    * programmed on a different one. This beign a LEVEL interrupt won't
drivers/usb/gadget/function/f_hid.c:312:         * Remove this from list to protect it from beign free()
net/mac80211/mesh_plink.c:1077:                  * B's peer link establishment or B beign

Re: [PATCH v2] staging: r8188eu: Fix misspelling in comment

[Siou-Jhih, Guo]

On 06/10/2021 02:02, Joe Perches wrote:
> On Tue, 2021-10-05 at 22:16 +0100, Siou-Jhih, Guo wrote:
>> If anything should I additionally aware, I'd like to fix them.
>
> Maybe fix these too?
>
> $ git grep -w -i -P -n 'issuign|fittign|settign|enablign|followign|chargign|beign|startign|accordign|runnign'
> arch/arm/mach-s3c/sleep-s3c64xx.S:33:    * requires to get the kernel runnign again. This code expects to be
> drivers/crypto/ccree/cc_driver.c:278:   /* AXI interrupt config are obsoleted startign at cc7x3 */
> drivers/hid/hid-thrustmaster.c:80: * beign conducted yet. The position and meaning of fields are a
> drivers/net/ethernet/chelsio/cxgb4/t4fw_api.h:809: * our own HELLO may get lost if it happens right as the MASTER is issuign a
> drivers/net/ethernet/qlogic/qede/qede_filter.c:2029:    /* Translate the flow specification into something fittign our DB */
> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c:1158: * Overview:   88E change all channel tx power accordign to flag.
> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c:1837: * Overview:   88E change all channel tx power accordign to flag.
> drivers/power/supply/ab8500_charger.c:1325: * ab8500_charger_led_en() - turn on/off chargign led
> drivers/power/supply/ab8500_charger.c:1327: * @on:              flag to turn on/off the chargign led
> drivers/spi/spi-tegra20-slink.c:543:            /* HW need small delay after settign Packed mode */
> drivers/staging/media/atomisp/pci/runtime/bufq/src/bufq.c:412:   * by some test apps. Enablign logging here floods the log
> drivers/staging/media/atomisp/pci/runtime/bufq/src/bufq.c:434:   * by some test apps. Enablign logging here floods the log
> drivers/staging/r8188eu/core/rtw_ap.c:747:Set to 0 (HT pure) under the followign conditions
> drivers/staging/r8188eu/hal/HalPhyRf_8188e.c:72: * Overview:    88E change all channel tx power accordign to flag.
> drivers/thermal/tegra/soctherm.c:844:    * programmed on a different one. This beign a LEVEL interrupt won't
> drivers/usb/gadget/function/f_hid.c:312:         * Remove this from list to protect it from beign free()
> net/mac80211/mesh_plink.c:1077:                  * B's peer link establishment or B beign
>
>

Hello Joe,

Thanks for your advice. It sounds really great. But this is my very
first patch, and I'm not sure adding so many modifications is proper or
not ... Maybe I could contribute after I could successfully pass my
first patch?

Regards,
Bill G.