* [PATCH 0/2] staging: wilc1000: follow coding guidelines
@ 2017-09-23 18:57 Keerthi Reddy
2017-09-23 18:57 ` [PATCH 1/2] staging: wilc1000: No space is necessary after a cast Keerthi Reddy
2017-09-23 18:58 ` [PATCH 2/2] staging: wilc1000: Blank lines aren't necessary before a close brace '}' Keerthi Reddy
0 siblings, 2 replies; 5+ messages in thread
From: Keerthi Reddy @ 2017-09-23 18:57 UTC (permalink / raw)
To: outreachy-kernel; +Cc: outreachy-kernel
This patch set fixes blank space related coding style
Keerthi Reddy (2):
staging: wilc1000: No space is necessary after a cast
staging: wilc1000: Blank lines aren't necessary before a close brace
'}'
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] staging: wilc1000: No space is necessary after a cast
2017-09-23 18:57 [PATCH 0/2] staging: wilc1000: follow coding guidelines Keerthi Reddy
@ 2017-09-23 18:57 ` Keerthi Reddy
2017-09-23 20:03 ` [Outreachy kernel] " Julia Lawall
2017-09-23 18:58 ` [PATCH 2/2] staging: wilc1000: Blank lines aren't necessary before a close brace '}' Keerthi Reddy
1 sibling, 1 reply; 5+ messages in thread
From: Keerthi Reddy @ 2017-09-23 18:57 UTC (permalink / raw)
To: outreachy-kernel; +Cc: outreachy-kernel
A space after type casting is not needed. All the other typecasts
in this file don't put space after typecast. so remove space
after typecast at this line.
checked with checkpatch.pl script
Signed-off-by: Keerthi Reddy <keerthigd4990@gmail.com>
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
index ac5aaaf..36dc2a0 100644
--- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
+++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
@@ -1617,7 +1617,7 @@ static int mgmt_tx(struct wiphy *wiphy,
*cookie = (unsigned long)buf;
priv->u64tx_cookie = *cookie;
- mgmt = (const struct ieee80211_mgmt *) buf;
+ mgmt = (const struct ieee80211_mgmt *)buf;
if (ieee80211_is_mgmt(mgmt->frame_control)) {
mgmt_tx = kmalloc(sizeof(struct p2p_mgmt_data), GFP_KERNEL);
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] staging: wilc1000: Blank lines aren't necessary before a close brace '}'
2017-09-23 18:57 [PATCH 0/2] staging: wilc1000: follow coding guidelines Keerthi Reddy
2017-09-23 18:57 ` [PATCH 1/2] staging: wilc1000: No space is necessary after a cast Keerthi Reddy
@ 2017-09-23 18:58 ` Keerthi Reddy
2017-09-23 20:04 ` [Outreachy kernel] " Julia Lawall
1 sibling, 1 reply; 5+ messages in thread
From: Keerthi Reddy @ 2017-09-23 18:58 UTC (permalink / raw)
To: outreachy-kernel; +Cc: outreachy-kernel
Before closing the brace, the blank line is not needed. That blank
line has not meaning here. so remove it.
Signed-off-by: Keerthi Reddy <keerthigd4990@gmail.com>
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
index 36dc2a0..e7882b2 100644
--- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
+++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
@@ -1111,7 +1111,6 @@ static int del_key(struct wiphy *wiphy, struct net_device *netdev,
g_key_gtk_params.key = NULL;
kfree(g_key_gtk_params.seq);
g_key_gtk_params.seq = NULL;
-
}
if (key_index >= 0 && key_index <= 3) {
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH 1/2] staging: wilc1000: No space is necessary after a cast
2017-09-23 18:57 ` [PATCH 1/2] staging: wilc1000: No space is necessary after a cast Keerthi Reddy
@ 2017-09-23 20:03 ` Julia Lawall
0 siblings, 0 replies; 5+ messages in thread
From: Julia Lawall @ 2017-09-23 20:03 UTC (permalink / raw)
To: Keerthi Reddy; +Cc: outreachy-kernel
On Sun, 24 Sep 2017, Keerthi Reddy wrote:
> A space after type casting is not needed. All the other typecasts
> in this file don't put space after typecast. so remove space
> after typecast at this line.
>
> checked with checkpatch.pl script
>
> Signed-off-by: Keerthi Reddy <keerthigd4990@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> index ac5aaaf..36dc2a0 100644
> --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> @@ -1617,7 +1617,7 @@ static int mgmt_tx(struct wiphy *wiphy,
>
> *cookie = (unsigned long)buf;
> priv->u64tx_cookie = *cookie;
> - mgmt = (const struct ieee80211_mgmt *) buf;
> + mgmt = (const struct ieee80211_mgmt *)buf;
>
> if (ieee80211_is_mgmt(mgmt->frame_control)) {
> mgmt_tx = kmalloc(sizeof(struct p2p_mgmt_data), GFP_KERNEL);
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/0a42225d2ac8416a7b74f2c9cea55bfd4d0521e8.1506192874.git.keerthigd4990%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH 2/2] staging: wilc1000: Blank lines aren't necessary before a close brace '}'
2017-09-23 18:58 ` [PATCH 2/2] staging: wilc1000: Blank lines aren't necessary before a close brace '}' Keerthi Reddy
@ 2017-09-23 20:04 ` Julia Lawall
0 siblings, 0 replies; 5+ messages in thread
From: Julia Lawall @ 2017-09-23 20:04 UTC (permalink / raw)
To: Keerthi Reddy; +Cc: outreachy-kernel
On Sun, 24 Sep 2017, Keerthi Reddy wrote:
> Before closing the brace, the blank line is not needed. That blank
> line has not meaning here. so remove it.
>
> Signed-off-by: Keerthi Reddy <keerthigd4990@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> index 36dc2a0..e7882b2 100644
> --- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> +++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> @@ -1111,7 +1111,6 @@ static int del_key(struct wiphy *wiphy, struct net_device *netdev,
> g_key_gtk_params.key = NULL;
> kfree(g_key_gtk_params.seq);
> g_key_gtk_params.seq = NULL;
> -
> }
>
> if (key_index >= 0 && key_index <= 3) {
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/366b2ad7e1bbc454659e73fda48ec695826ad673.1506192874.git.keerthigd4990%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-09-23 20:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-23 18:57 [PATCH 0/2] staging: wilc1000: follow coding guidelines Keerthi Reddy
2017-09-23 18:57 ` [PATCH 1/2] staging: wilc1000: No space is necessary after a cast Keerthi Reddy
2017-09-23 20:03 ` [Outreachy kernel] " Julia Lawall
2017-09-23 18:58 ` [PATCH 2/2] staging: wilc1000: Blank lines aren't necessary before a close brace '}' Keerthi Reddy
2017-09-23 20:04 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.