From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
<linux-samsung-soc@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
linux-clk <linux-clk@vger.kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>
Subject: Re: [PATCH] clk: samsung: exynos5433: Use of_clk_get_parent_count()
Date: Thu, 30 May 2019 20:24:46 +0800 [thread overview]
Message-ID: <3673777a-60dc-3eec-ccb8-9ffa1a3e5cf4@huawei.com> (raw)
In-Reply-To: <b57d66da-9b18-7b1d-ffa6-3b4600f9dc5a@samsung.com>
On 2019/5/30 19:13, Sylwester Nawrocki wrote:
> On 5/25/19 13:55, Kefeng Wang wrote:
>> Use of_clk_get_parent_count() instead of open coding.
>>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> Patch applied, thank you.
>
> In future please make sure to also Cc linux-clk@vger.kernel.org mailing list
> and the clk maintainers (Stephen, Michael) when sending clk patches.
OK, thanks for the tip.
>
>> ---
>> drivers/clk/samsung/clk-exynos5433.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c
>> index dae1c96de933..14e253915ca4 100644
>> --- a/drivers/clk/samsung/clk-exynos5433.c
>> +++ b/drivers/clk/samsung/clk-exynos5433.c
>> @@ -5590,8 +5590,8 @@ static int __init exynos5433_cmu_probe(struct platform_device *pdev)
>> data->nr_clk_save = info->nr_clk_regs;
>> data->clk_suspend = info->suspend_regs;
>> data->nr_clk_suspend = info->nr_suspend_regs;
>> - data->nr_pclks = of_count_phandle_with_args(dev->of_node, "clocks",
>> - "#clock-cells");
>> + data->nr_pclks = of_clk_get_parent_count(dev->of_node);
>> +
>> if (data->nr_pclks > 0) {
>> data->pclks = devm_kcalloc(dev, sizeof(struct clk *),
>> data->nr_pclks, GFP_KERNEL);
>>
WARNING: multiple messages have this Message-ID (diff)
From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Kukjin Kim <kgene@kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clk: samsung: exynos5433: Use of_clk_get_parent_count()
Date: Thu, 30 May 2019 20:24:46 +0800 [thread overview]
Message-ID: <3673777a-60dc-3eec-ccb8-9ffa1a3e5cf4@huawei.com> (raw)
In-Reply-To: <b57d66da-9b18-7b1d-ffa6-3b4600f9dc5a@samsung.com>
On 2019/5/30 19:13, Sylwester Nawrocki wrote:
> On 5/25/19 13:55, Kefeng Wang wrote:
>> Use of_clk_get_parent_count() instead of open coding.
>>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> Patch applied, thank you.
>
> In future please make sure to also Cc linux-clk@vger.kernel.org mailing list
> and the clk maintainers (Stephen, Michael) when sending clk patches.
OK, thanks for the tip.
>
>> ---
>> drivers/clk/samsung/clk-exynos5433.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c
>> index dae1c96de933..14e253915ca4 100644
>> --- a/drivers/clk/samsung/clk-exynos5433.c
>> +++ b/drivers/clk/samsung/clk-exynos5433.c
>> @@ -5590,8 +5590,8 @@ static int __init exynos5433_cmu_probe(struct platform_device *pdev)
>> data->nr_clk_save = info->nr_clk_regs;
>> data->clk_suspend = info->suspend_regs;
>> data->nr_clk_suspend = info->nr_suspend_regs;
>> - data->nr_pclks = of_count_phandle_with_args(dev->of_node, "clocks",
>> - "#clock-cells");
>> + data->nr_pclks = of_clk_get_parent_count(dev->of_node);
>> +
>> if (data->nr_pclks > 0) {
>> data->pclks = devm_kcalloc(dev, sizeof(struct clk *),
>> data->nr_pclks, GFP_KERNEL);
>>
WARNING: multiple messages have this Message-ID (diff)
From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Kukjin Kim <kgene@kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clk: samsung: exynos5433: Use of_clk_get_parent_count()
Date: Thu, 30 May 2019 20:24:46 +0800 [thread overview]
Message-ID: <3673777a-60dc-3eec-ccb8-9ffa1a3e5cf4@huawei.com> (raw)
In-Reply-To: <b57d66da-9b18-7b1d-ffa6-3b4600f9dc5a@samsung.com>
On 2019/5/30 19:13, Sylwester Nawrocki wrote:
> On 5/25/19 13:55, Kefeng Wang wrote:
>> Use of_clk_get_parent_count() instead of open coding.
>>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> Patch applied, thank you.
>
> In future please make sure to also Cc linux-clk@vger.kernel.org mailing list
> and the clk maintainers (Stephen, Michael) when sending clk patches.
OK, thanks for the tip.
>
>> ---
>> drivers/clk/samsung/clk-exynos5433.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c
>> index dae1c96de933..14e253915ca4 100644
>> --- a/drivers/clk/samsung/clk-exynos5433.c
>> +++ b/drivers/clk/samsung/clk-exynos5433.c
>> @@ -5590,8 +5590,8 @@ static int __init exynos5433_cmu_probe(struct platform_device *pdev)
>> data->nr_clk_save = info->nr_clk_regs;
>> data->clk_suspend = info->suspend_regs;
>> data->nr_clk_suspend = info->nr_suspend_regs;
>> - data->nr_pclks = of_count_phandle_with_args(dev->of_node, "clocks",
>> - "#clock-cells");
>> + data->nr_pclks = of_clk_get_parent_count(dev->of_node);
>> +
>> if (data->nr_pclks > 0) {
>> data->pclks = devm_kcalloc(dev, sizeof(struct clk *),
>> data->nr_pclks, GFP_KERNEL);
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-30 12:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190525114732epcas1p3ac5c2205bf004893dc002fe05c3adf7b@epcas1p3.samsung.com>
2019-05-25 11:55 ` [PATCH] clk: samsung: exynos5433: Use of_clk_get_parent_count() Kefeng Wang
2019-05-25 11:55 ` Kefeng Wang
2019-05-28 11:10 ` Andrzej Hajda
2019-05-29 5:32 ` Chanwoo Choi
2019-05-30 11:13 ` Sylwester Nawrocki
2019-05-30 11:13 ` Sylwester Nawrocki
2019-05-30 11:13 ` Sylwester Nawrocki
2019-05-30 12:24 ` Kefeng Wang [this message]
2019-05-30 12:24 ` Kefeng Wang
2019-05-30 12:24 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3673777a-60dc-3eec-ccb8-9ffa1a3e5cf4@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.